Skip to content

Commit 953615f

Browse files
committed
Fix: code smells, nameof()
1 parent f90c6a9 commit 953615f

File tree

8 files changed

+15
-15
lines changed

8 files changed

+15
-15
lines changed

src/System.Net.IPNetwork/IPNetwork2InternalParse.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ private static bool InternalParse(bool tryParse, string ipaddress, string netmas
5454
{
5555
if (!tryParse)
5656
{
57-
throw new ArgumentException("ipaddress");
57+
throw new ArgumentException(nameof(ipaddress));
5858
}
5959

6060
ipnetwork = null;
@@ -66,7 +66,7 @@ private static bool InternalParse(bool tryParse, string ipaddress, string netmas
6666
{
6767
if (!tryParse)
6868
{
69-
throw new ArgumentException("netmask");
69+
throw new ArgumentException(nameof(netmask));
7070
}
7171

7272
ipnetwork = null;
@@ -122,7 +122,7 @@ private static bool InternalParse(bool tryParse, string network, ICidrGuess cidr
122122

123123
if (!tryParse)
124124
{
125-
throw new ArgumentException("network");
125+
throw new ArgumentException(nameof(network));
126126
}
127127

128128
ipnetwork = null;
@@ -194,7 +194,7 @@ private static bool InternalParse(bool tryParse, IPAddress ipaddress, IPAddress
194194
{
195195
if (!tryParse)
196196
{
197-
throw new ArgumentException("netmask");
197+
throw new ArgumentException(nameof(netmask));
198198
}
199199

200200
ipnetwork = null;
@@ -238,7 +238,7 @@ private static bool InternalParse(bool tryParse, string ipaddress, byte cidr, ou
238238
{
239239
if (!tryParse)
240240
{
241-
throw new ArgumentException("ipaddress");
241+
throw new ArgumentException(nameof(ipaddress));
242242
}
243243

244244
ipnetwork = null;
@@ -250,7 +250,7 @@ private static bool InternalParse(bool tryParse, string ipaddress, byte cidr, ou
250250
{
251251
if (!tryParse)
252252
{
253-
throw new ArgumentException("cidr");
253+
throw new ArgumentException(nameof(cidr));
254254
}
255255

256256
ipnetwork = null;

src/System.Net.IPNetwork/IPNetwork2Subnet.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ internal static void InternalSubnet(bool trySubnet, IPNetwork2 network, byte cid
119119
{
120120
if (!trySubnet)
121121
{
122-
throw new ArgumentException("cidr");
122+
throw new ArgumentException(nameof(cidr));
123123
}
124124

125125
ipnetworkCollection = null;

src/System.Net.IPNetwork/IPNetwork2Supernet.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ internal static void InternalSupernet(
129129
{
130130
if (!trySupernet)
131131
{
132-
throw new ArgumentException("cidr");
132+
throw new ArgumentException(nameof(cidr));
133133
}
134134

135135
supernet = null;
@@ -164,7 +164,7 @@ internal static void InternalSupernet(
164164
{
165165
if (!trySupernet)
166166
{
167-
throw new ArgumentException("network");
167+
throw new ArgumentException(nameof(networkSupernet));
168168
}
169169

170170
supernet = null;

src/System.Net.IPNetwork/IPNetwork2ToCidr.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ private static bool InternalToCidr(bool tryParse, BigInteger netmask, AddressFam
7878
{
7979
if (!tryParse)
8080
{
81-
throw new ArgumentException("netmask");
81+
throw new ArgumentException(nameof(netmask));
8282
}
8383

8484
cidr = 0;

src/System.Net.IPNetwork/IPNetwork2ToIPAddress.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,14 @@ internal static byte[] Resize(byte[] bytes, AddressFamily family)
4444
if (family != AddressFamily.InterNetwork
4545
&& family != AddressFamily.InterNetworkV6)
4646
{
47-
throw new ArgumentException("family");
47+
throw new ArgumentException(nameof(family));
4848
}
4949

5050
int width = family == AddressFamily.InterNetwork ? 4 : 16;
5151

5252
if (bytes.Length > width)
5353
{
54-
throw new ArgumentException("bytes");
54+
throw new ArgumentException(nameof(bytes));
5555
}
5656

5757
byte[] result = new byte[width];

src/System.Net.IPNetwork/IPNetwork2ToNetmask.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ internal static void InternalToNetmask(bool tryParse, byte cidr, AddressFamily f
6363
{
6464
if (!tryParse)
6565
{
66-
throw new ArgumentException("family");
66+
throw new ArgumentException(nameof(family));
6767
}
6868

6969
netmask = null;

src/System.Net.IPNetwork/IPNetwork2ValidNetmask.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ internal static bool InternalValidNetmask(BigInteger netmask, AddressFamily fami
4545
if (family != AddressFamily.InterNetwork
4646
&& family != AddressFamily.InterNetworkV6)
4747
{
48-
throw new ArgumentException("family");
48+
throw new ArgumentException(nameof(family));
4949
}
5050

5151
BigInteger mask = family == AddressFamily.InterNetwork

src/System.Net.IPNetwork/IPNetwork2WideSubnet.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ internal static bool InternalWideSubnet(bool tryWide, IPNetwork2[] ipnetworks, o
150150
{
151151
if (!tryWide)
152152
{
153-
throw new ArgumentException("MixedAddressFamily");
153+
throw new ArgumentException(nameof(family));
154154
}
155155
ipnetwork = null;
156156
return false;

0 commit comments

Comments
 (0)