Skip to content

Commit b0c6a69

Browse files
lduchosallduchosal
committed
fix: snoarqube / smells
1 parent 7577c14 commit b0c6a69

File tree

5 files changed

+349
-349
lines changed

5 files changed

+349
-349
lines changed

‎src/TestProject/IPNetworkTest/IPNetworkParseTests.cs‎

Lines changed: 107 additions & 107 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public void TestParseIPAddressNetmaskAne11()
112112
{
113113
Assert.ThrowsExactly<ArgumentException>(() =>
114114
{
115-
IPNetwork2.Parse("0.0.0.0", 33);
115+
IPNetwork2.Parse("1.2.3.4", 33);
116116
});
117117
}
118118

@@ -161,13 +161,13 @@ public void TestParseString1()
161161
uint usable = 254;
162162

163163
var ipnetwork = IPNetwork2.Parse(ipaddress);
164-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
165-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
166-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
167-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
168-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
169-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
170-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
164+
Assert.AreEqual(network, ipnetwork.Network.ToString());
165+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
166+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
167+
Assert.AreEqual(cidr, ipnetwork.Cidr);
168+
Assert.AreEqual(usable, ipnetwork.Usable);
169+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
170+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
171171
}
172172

173173
/// <summary>
@@ -188,13 +188,13 @@ public void TestParseString2()
188188
uint usable = 254;
189189

190190
var ipnetwork = IPNetwork2.Parse(ipaddress);
191-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
192-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
193-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
194-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
195-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
196-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
197-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
191+
Assert.AreEqual(network, ipnetwork.Network.ToString());
192+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
193+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
194+
Assert.AreEqual(cidr, ipnetwork.Cidr);
195+
Assert.AreEqual(usable, ipnetwork.Usable);
196+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
197+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
198198
}
199199

200200
/// <summary>
@@ -215,13 +215,13 @@ public void TestParseString3()
215215
uint usable = 4294967294;
216216

217217
var ipnetwork = IPNetwork2.Parse(ipaddress);
218-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
219-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
220-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
221-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
222-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
223-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
224-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
218+
Assert.AreEqual(network, ipnetwork.Network.ToString());
219+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
220+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
221+
Assert.AreEqual(cidr, ipnetwork.Cidr);
222+
Assert.AreEqual(usable, ipnetwork.Usable);
223+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
224+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
225225
}
226226

227227
/// <summary>
@@ -242,13 +242,13 @@ public void TestParseString4()
242242
uint usable = 1;
243243

244244
var ipnetwork = IPNetwork2.Parse(ipaddress);
245-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
246-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
247-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
248-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
249-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
250-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
251-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
245+
Assert.AreEqual(network, ipnetwork.Network.ToString());
246+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
247+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
248+
Assert.AreEqual(cidr, ipnetwork.Cidr);
249+
Assert.AreEqual(usable, ipnetwork.Usable);
250+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
251+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
252252
}
253253

254254
/// <summary>
@@ -269,13 +269,13 @@ public void TestParseString5()
269269
uint usable = 1;
270270

271271
var ipnetwork = IPNetwork2.Parse(ipaddress);
272-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
273-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
274-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
275-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
276-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
277-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
278-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
272+
Assert.AreEqual(network, ipnetwork.Network.ToString());
273+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
274+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
275+
Assert.AreEqual(cidr, ipnetwork.Cidr);
276+
Assert.AreEqual(usable, ipnetwork.Usable);
277+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
278+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
279279
}
280280

281281
/// <summary>
@@ -285,7 +285,7 @@ public void TestParseString5()
285285
[TestMethod]
286286
public void TestParseIPAddressNoNetmask1()
287287
{
288-
string ipaddress = "10.0.0.0";
288+
string ipaddress = "10.1.2.3";
289289

290290
string network = "10.0.0.0";
291291
string netmask = "255.0.0.0";
@@ -296,13 +296,13 @@ public void TestParseIPAddressNoNetmask1()
296296
uint usable = 16777214;
297297

298298
var ipnetwork = IPNetwork2.Parse(ipaddress);
299-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
300-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
301-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
302-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
303-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
304-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
305-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
299+
Assert.AreEqual(network, ipnetwork.Network.ToString());
300+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
301+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
302+
Assert.AreEqual(cidr, ipnetwork.Cidr);
303+
Assert.AreEqual(usable, ipnetwork.Usable);
304+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
305+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
306306
}
307307

308308
/// <summary>
@@ -322,13 +322,13 @@ public void When_Parse_254_128_0_0_Should_Succeed()
322322
uint usable = 254;
323323

324324
var ipnetwork = IPNetwork2.Parse(ipaddress);
325-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
326-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
327-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
328-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
329-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
330-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
331-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
325+
Assert.AreEqual(network, ipnetwork.Network.ToString());
326+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
327+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
328+
Assert.AreEqual(cidr, ipnetwork.Cidr);
329+
Assert.AreEqual(usable, ipnetwork.Usable);
330+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
331+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
332332
}
333333

334334
/// <summary>
@@ -348,13 +348,13 @@ public void TestParseIPAddressNoNetmask2()
348348
uint usable = 65534;
349349

350350
var ipnetwork = IPNetwork2.Parse(ipaddress);
351-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
352-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
353-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
354-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
355-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
356-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
357-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
351+
Assert.AreEqual(network, ipnetwork.Network.ToString());
352+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
353+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
354+
Assert.AreEqual(cidr, ipnetwork.Cidr);
355+
Assert.AreEqual(usable, ipnetwork.Usable);
356+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
357+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
358358
}
359359

360360
/// <summary>
@@ -374,13 +374,13 @@ public void TestParseIPAddressNoNetmask3()
374374
uint usable = 254;
375375

376376
var ipnetwork = IPNetwork2.Parse(ipaddress);
377-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
378-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
379-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
380-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
381-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
382-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
383-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
377+
Assert.AreEqual(network, ipnetwork.Network.ToString());
378+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
379+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
380+
Assert.AreEqual(cidr, ipnetwork.Cidr);
381+
Assert.AreEqual(usable, ipnetwork.Usable);
382+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
383+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
384384
}
385385

386386
/// <summary>
@@ -402,13 +402,13 @@ public void TestParseIPAddressNoNetmask1_ClassFull()
402402
byte cidr = 8;
403403
uint usable = 16777214;
404404

405-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
406-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
407-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
408-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
409-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
410-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
411-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
405+
Assert.AreEqual(network, ipnetwork.Network.ToString());
406+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
407+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
408+
Assert.AreEqual(cidr, ipnetwork.Cidr);
409+
Assert.AreEqual(usable, ipnetwork.Usable);
410+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
411+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
412412
}
413413

414414
/// <summary>
@@ -430,13 +430,13 @@ public void TestParseIPAddressNoNetmask2_ClassFull()
430430
byte cidr = 16;
431431
uint usable = 65534;
432432

433-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
434-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
435-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
436-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
437-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
438-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
439-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
433+
Assert.AreEqual(network, ipnetwork.Network.ToString());
434+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
435+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
436+
Assert.AreEqual(cidr, ipnetwork.Cidr);
437+
Assert.AreEqual(usable, ipnetwork.Usable);
438+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
439+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
440440
}
441441

442442
/// <summary>
@@ -458,13 +458,13 @@ public void TestParseIPAddressNoNetmask3_ClassFull()
458458
byte cidr = 24;
459459
uint usable = 254;
460460

461-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
462-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
463-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
464-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
465-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
466-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
467-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
461+
Assert.AreEqual(network, ipnetwork.Network.ToString());
462+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
463+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
464+
Assert.AreEqual(cidr, ipnetwork.Cidr);
465+
Assert.AreEqual(usable, ipnetwork.Usable);
466+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
467+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
468468
}
469469

470470
/// <summary>
@@ -486,13 +486,13 @@ public void TestParseIPAddressNoNetmask1_ClassLess()
486486
byte cidr = 32;
487487
uint usable = 1;
488488

489-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
490-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
491-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
492-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
493-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
494-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
495-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
489+
Assert.AreEqual(network, ipnetwork.Network.ToString());
490+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
491+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
492+
Assert.AreEqual(cidr, ipnetwork.Cidr);
493+
Assert.AreEqual(usable, ipnetwork.Usable);
494+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
495+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
496496
}
497497

498498
/// <summary>
@@ -514,13 +514,13 @@ public void TestParseIPAddressNoNetmask2_ClassLess()
514514
byte cidr = 32;
515515
uint usable = 1;
516516

517-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
518-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
519-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
520-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
521-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
522-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
523-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
517+
Assert.AreEqual(network, ipnetwork.Network.ToString());
518+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
519+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
520+
Assert.AreEqual(cidr, ipnetwork.Cidr);
521+
Assert.AreEqual(usable, ipnetwork.Usable);
522+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
523+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
524524
}
525525

526526
/// <summary>
@@ -542,13 +542,13 @@ public void TestParseIPAddressNoNetmask3_ClassLess()
542542
byte cidr = 32;
543543
uint usable = 1;
544544

545-
Assert.AreEqual(network, ipnetwork.Network.ToString(), "Network");
546-
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString(), "Netmask");
547-
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString(), "Broadcast");
548-
Assert.AreEqual(cidr, ipnetwork.Cidr, "Cidr");
549-
Assert.AreEqual(usable, ipnetwork.Usable, "Usable");
550-
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString(), "FirstUsable");
551-
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString(), "LastUsable");
545+
Assert.AreEqual(network, ipnetwork.Network.ToString());
546+
Assert.AreEqual(netmask, ipnetwork.Netmask.ToString());
547+
Assert.AreEqual(broadcast, ipnetwork.Broadcast.ToString());
548+
Assert.AreEqual(cidr, ipnetwork.Cidr);
549+
Assert.AreEqual(usable, ipnetwork.Usable);
550+
Assert.AreEqual(firstUsable, ipnetwork.FirstUsable.ToString());
551+
Assert.AreEqual(lastUsable, ipnetwork.LastUsable.ToString());
552552
}
553553

554554
/// <summary>

0 commit comments

Comments
 (0)