Skip to content

Commit 3038269

Browse files
authored
Merge pull request #12 from jerry2013/patch-1
fix error event handler for shared worker
2 parents 27ab59a + 24837a3 commit 3038269

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/web/src/index.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,12 @@ const startWorker = ({
8181
}) => {
8282
try {
8383
if (type === TYPE_SHARED_WORKER) {
84-
workerPort = new window.SharedWorker(workerUrl, workerOptions).port
84+
const worker = new window.SharedWorker(workerUrl, workerOptions)
85+
worker.addEventListener('error', (event) => options.onError?.(event))
86+
workerPort = worker.port
8587
} else {
8688
workerPort = new window.Worker(workerUrl, workerOptions)
89+
workerPort.addEventListener('error', (event) => options.onError?.(event))
8790
}
8891
} catch (e) {
8992
return reject(e)
@@ -93,10 +96,7 @@ const startWorker = ({
9396
}
9497

9598
workerPort.addEventListener('message', (event) => handleWorkerMessages({ event, options }))
96-
if (options.onError) {
97-
workerPort.addEventListener('error', (event) => options.onError(event.toString()))
98-
workerPort.addEventListener('messageerror', (event) => options.onError(event.toString()))
99-
}
99+
workerPort.addEventListener('messageerror', (event) => options.onError?.(event))
100100

101101
if (type === TYPE_SHARED_WORKER) {
102102
workerPort.start() // we need start port only for shared worker

0 commit comments

Comments
 (0)