add test cases

Author: le0pard

.rubocop.yml

@@ -7,19 +7,22 @@ AllCops:
   SuggestExtensions: false
 
 Metrics/AbcSize:
-  Max: 30
+  Max: 60
 
 Metrics/ClassLength:
-  Max: 130
+  Max: 800
 
 Metrics/CyclomaticComplexity:
-  Max: 10
+  Max: 30
 
 Metrics/MethodLength:
-  Max: 30
+  Max: 70
 
 Metrics/PerceivedComplexity:
-  Max: 10
+  Max: 32
+
+Metrics/BlockNesting:
+  Max: 5
 
 Naming/PredicateMethod:
   Enabled: false

Rakefile

@@ -9,5 +9,4 @@ require 'rubocop/rake_task'
 
 RuboCop::RakeTask.new
 
-task default: %i[spec]
-# task default: %i[rubocop spec]
+task default: %i[rubocop spec]

lib/json_mend/parser.rb

@@ -667,9 +667,9 @@ def determine_complex_delimiter_action(lstring_delimiter, rstring_delimiter)
         return [false, false] if (1..i).all? { |j| peek_char(j).to_s.match(/\s/) }
 
         if current_context?(:object_value)
-          return check_unmatched_in_object_value(i, lstring_delimiter, rstring_delimiter)
+          return check_unmatched_in_object_value(index: i, lstring_delimiter:, rstring_delimiter:)
         elsif current_context?(:array)
-          return check_unmatched_in_array(i, rstring_delimiter)
+          return check_unmatched_in_array(rstring_delimiter:)
         elsif current_context?(:object_key)
           return [true, false]
         end
@@ -678,34 +678,34 @@ def determine_complex_delimiter_action(lstring_delimiter, rstring_delimiter)
       [false, false]
     end
 
-    def check_unmatched_in_object_value(i, lstring_delimiter, rstring_delimiter)
-      i = skip_whitespaces_at(start_idx: i + 1)
-      if peek_char(i) == ','
+    def check_unmatched_in_object_value(index:, lstring_delimiter:, rstring_delimiter:)
+      index = skip_whitespaces_at(start_idx: index + 1)
+      if peek_char(index) == ','
         # So we found a comma, this could be a case of a single quote like "va"lue",
         # Search if it's followed by another key, starting with the first delimeter
-        i = skip_to_character(lstring_delimiter, start_idx: i + 1)
-        i += 1
-        i = skip_to_character(rstring_delimiter, start_idx: i + 1)
-        i += 1
-        i = skip_whitespaces_at(start_idx: i)
-        next_c = peek_char(i)
+        index = skip_to_character(lstring_delimiter, start_idx: index + 1)
+        index += 1
+        index = skip_to_character(rstring_delimiter, start_idx: index + 1)
+        index += 1
+        index = skip_whitespaces_at(start_idx: index)
+        next_c = peek_char(index)
         return [true, false] if next_c == ':'
       end
       # We found a delimiter and we need to check if this is a key
       # so find a rstring_delimiter and a colon after
-      i = skip_to_character(rstring_delimiter, start_idx: i + 1)
-      i += 1
-      next_c = peek_char(i)
+      index = skip_to_character(rstring_delimiter, start_idx: index + 1)
+      index += 1
+      next_c = peek_char(index)
       while next_c && next_c != ':'
         if TERMINATORS_VALUE.include?(next_c) || (
           next_c == rstring_delimiter &&
-          peek_char(i - 1) != '\\'
+          peek_char(index - 1) != '\\'
         )
           break
         end
 
-        i += 1
-        next_c = peek_char(i)
+        index += 1
+        next_c = peek_char(index)
       end
 
       # Only if we fail to find a ':' then we know this is misplaced quote
@@ -714,7 +714,7 @@ def check_unmatched_in_object_value(i, lstring_delimiter, rstring_delimiter)
       [false, false]
     end
 
-    def check_unmatched_in_array(_i, rstring_delimiter)
+    def check_unmatched_in_array(rstring_delimiter:)
       # Heuristic: Check if this quote is a closer or internal.
       # 1. Find the NEXT delimiter (quote) index `j`.
       j = 1

spec/json_mend_spec.rb

@@ -1,12 +1,5 @@
 # frozen_string_literal: true
 
-require 'timeout'
-
-# Helper to enforce timeout for these specific tests
-def with_timeout(seconds = 1, &)
-  Timeout.timeout(seconds, &)
-end
-
 RSpec.describe JsonMend do
   it 'has a version number' do
     expect(described_class::VERSION).not_to be_nil
@@ -947,6 +940,31 @@ def with_timeout(seconds = 1, &)
 
     context 'with edge cases' do
       [
+        {
+          input: '1 ""',
+          expected_output: '1',
+          desc: 'multi-json with empty string skipped'
+        },
+        {
+          input: "[1, # comment inside array \n 2]",
+          expected_output: JSON.dump([1, 2]),
+          desc: 'array with hash-style line comment'
+        },
+        {
+          input: '[ "a", "b\"c" ]',
+          expected_output: JSON.dump(['a', 'b"c']),
+          desc: 'array with internal escaped quote logic'
+        },
+        {
+          input: '{"a": "val\'ue"}',
+          expected_output: JSON.dump({ 'a' => "val'ue" }),
+          desc: 'string with escaped single quote'
+        },
+        {
+          input: '{"key:colons": "value"}',
+          expected_output: JSON.dump({ 'key:colons' => 'value' }),
+          desc: 'key containing colon'
+        },
         {
           input: '[ "key": "value", "key2": "value2" ]',
           expected_output: JSON.dump([{ 'key' => 'value', 'key2' => 'value2' }]),
@@ -1050,35 +1068,6 @@ def with_timeout(seconds = 1, &)
       end
     end
 
-    context 'when provided valid complex standard json' do
-      [
-        {
-          input: '{"simple": "string", "number": 123, "bool": true, "nil": null}',
-          expected_output: JSON.dump({ simple: 'string', number: 123, bool: true, nil: nil })
-        },
-        {
-          input: '{"nested": {"array": [1, 2, {"deep": "obj"}]}}',
-          expected_output: JSON.dump({ nested: { array: [1, 2, { deep: 'obj' }] } })
-        },
-        {
-          input: '{"unicode": "こんにちは", "emoji": "👍"}',
-          expected_output: JSON.dump({ unicode: 'こんにちは', emoji: '👍' })
-        },
-        {
-          input: '{"escapes":"\" \\\\ / \\b \\f \\n \\r \\t"}',
-          expected_output: JSON.dump({ escapes: "\" \\ / \b \f \n \r \t" })
-        },
-        {
-          input: '{"empty_obj": {}, "empty_arr": []}',
-          expected_output: JSON.dump({ empty_obj: {}, empty_arr: [] })
-        }
-      ].each do |test_case|
-        it "preserves valid json: #{test_case[:input]}" do
-          expect(described_class.repair(test_case[:input])).to eq(test_case[:expected_output])
-        end
-      end
-    end
-
     context 'when provided ambiguous number formats' do
       [
         {
@@ -1173,5 +1162,46 @@ def with_timeout(seconds = 1, &)
         end
       end
     end
+
+    context 'with valid JSON (direct parser usage)' do
+      [
+        {
+          input: '{"a": 1}',
+          expected_output: JSON.dump({ 'a' => 1 })
+        },
+        {
+          input: '[1, 2, 3]',
+          expected_output: JSON.dump([1, 2, 3])
+        },
+        {
+          input: '{"a": [1, 2], "b": {"c": 3}}',
+          expected_output: JSON.dump({ 'a' => [1, 2], 'b' => { 'c' => 3 } })
+        },
+        {
+          input: '{"simple": "string", "number": 123, "bool": true, "nil": null}',
+          expected_output: JSON.dump({ simple: 'string', number: 123, bool: true, nil: nil })
+        },
+        {
+          input: '{"nested": {"array": [1, 2, {"deep": "obj"}]}}',
+          expected_output: JSON.dump({ nested: { array: [1, 2, { deep: 'obj' }] } })
+        },
+        {
+          input: '{"unicode": "こんにちは", "emoji": "👍"}',
+          expected_output: JSON.dump({ unicode: 'こんにちは', emoji: '👍' })
+        },
+        {
+          input: '{"escapes":"\" \\\\ / \\b \\f \\n \\r \\t"}',
+          expected_output: JSON.dump({ escapes: "\" \\ / \b \f \n \r \t" })
+        },
+        {
+          input: '{"empty_obj": {}, "empty_arr": []}',
+          expected_output: JSON.dump({ empty_obj: {}, empty_arr: [] })
+        }
+      ].each do |test_case|
+        it "parses valid JSON #{test_case[:input]}" do
+          expect(described_class.repair(test_case[:input])).to eq(test_case[:expected_output])
+        end
+      end
+    end
   end
 end

spec/spec_helper.rb

@@ -1,6 +1,12 @@
 # frozen_string_literal: true
 
 require 'json_mend'
+require 'timeout'
+
+# Helper to enforce timeout for these specific tests
+def with_timeout(seconds = 1, &)
+  Timeout.timeout(seconds, &)
+end
 
 RSpec.configure do |config|
   # Enable flags like --only-failures and --next-failure