Skip to content

Commit 1184670

Browse files
committed
is_flow -> is_flow_class
1 parent dca0701 commit 1184670

File tree

4 files changed

+29
-29
lines changed

4 files changed

+29
-29
lines changed

docs/flows.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -310,28 +310,28 @@ assert(flow_b._ == my_object)
310310

311311
## Utility Functions
312312

313-
### `is_flow(cls)`
313+
### `is_flow_class(cls)`
314314

315-
The `is_flow` function checks if a class is a Flow:
315+
The `is_flow_class` function checks if a class or instance is a Flow:
316316

317317
$dual_code{
318318
lua = [[
319319
local Flow = require("lapis.flow").Flow
320-
local is_flow = require("lapis.flow").is_flow
320+
local is_flow_class = require("lapis.flow").is_flow_class
321321

322322
MyFlow = Flow:extend({})
323323
some_object = {}
324324

325-
is_flow(MyFlow) --> true
326-
is_flow(some_object) --> false
325+
is_flow_class(MyFlow) --> true
326+
is_flow_class(some_object) --> false
327327
]],
328328
moon = [[
329-
import Flow, is_flow from require "lapis.flow"
329+
import Flow, is_flow_class from require "lapis.flow"
330330

331331
class MyFlow extends Flow
332332
some_object = {}
333333

334-
is_flow MyFlow --> true
335-
is_flow some_object --> false
334+
is_flow_class MyFlow --> true
335+
is_flow_class some_object --> false
336336
]]
337337
}

lapis/flow.lua

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ do
55
end
66
local unpack = table.unpack or unpack
77
local Flow
8-
local is_flow
9-
is_flow = function(cls)
8+
local is_flow_class
9+
is_flow_class = function(cls)
1010
if not (cls) then
1111
return false
1212
end
1313
if cls == Flow then
1414
return true
1515
end
16-
return is_flow(cls.__parent)
16+
return is_flow_class(cls.__parent)
1717
end
1818
local MEMO_KEY = setmetatable({ }, {
1919
__tostring = function()
@@ -50,7 +50,7 @@ do
5050
self._ = _
5151
assert(self._, "missing flow target")
5252
self._req = self._
53-
if is_flow(self._.__class) then
53+
if is_flow_class(self._.__class) then
5454
self._ = self._._
5555
end
5656
local old_mt = getmetatable(self)
@@ -126,7 +126,7 @@ do
126126
end
127127
return {
128128
Flow = Flow,
129-
is_flow = is_flow,
129+
is_flow_class = is_flow_class,
130130
MEMO_KEY = MEMO_KEY,
131131
memo = memo
132132
}

lapis/flow.moon

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ unpack = table.unpack or unpack
55

66
local Flow
77

8-
is_flow = (cls) ->
8+
is_flow_class = (cls) ->
99
return false unless cls
1010
return true if cls == Flow
11-
is_flow cls.__parent
11+
is_flow_class cls.__parent
1212

1313
MEMO_KEY = setmetatable {}, __tostring: -> "::memo_key::"
1414

@@ -48,7 +48,7 @@ class Flow
4848
@_req = @_ -- TODO: for legacy flows
4949

5050
-- get the real request if the object passed is another flow
51-
if is_flow @_.__class
51+
if is_flow_class @_.__class
5252
@_ = @_._
5353

5454
old_mt = getmetatable @
@@ -87,4 +87,4 @@ class Flow
8787
setmetatable @, mt
8888

8989

90-
{ :Flow, :is_flow, :MEMO_KEY, :memo }
90+
{ :Flow, :is_flow_class, :MEMO_KEY, :memo }

spec/flow_spec.moon

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
import Flow, is_flow from require "lapis.flow"
2+
import Flow, is_flow_class from require "lapis.flow"
33

44
describe "lapis.flow", ->
55
local base_object
@@ -186,39 +186,39 @@ describe "lapis.flow", ->
186186
assert.same {}, obj
187187
assert.same {[multiple]: {1, 2}}, f[MEMO_KEY]
188188

189-
describe "is_flow", ->
189+
describe "is_flow_class", ->
190190
it "returns false for nil", ->
191-
assert.false is_flow nil
191+
assert.false is_flow_class nil
192192

193193
it "returns false for false", ->
194-
assert.false is_flow false
194+
assert.false is_flow_class false
195195

196196
it "returns true for Flow class", ->
197-
assert.true is_flow Flow
197+
assert.true is_flow_class Flow
198198

199199
it "returns true for class extending Flow", ->
200200
class MyFlow extends Flow
201-
assert.true is_flow MyFlow
201+
assert.true is_flow_class MyFlow
202202

203203
it "returns true for deeply nested Flow subclass", ->
204204
class FirstFlow extends Flow
205205
class SecondFlow extends FirstFlow
206206
class ThirdFlow extends SecondFlow
207207

208-
assert.true is_flow SecondFlow
209-
assert.true is_flow ThirdFlow
208+
assert.true is_flow_class SecondFlow
209+
assert.true is_flow_class ThirdFlow
210210

211211
it "returns false for regular table", ->
212-
assert.false is_flow {}
212+
assert.false is_flow_class {}
213213

214214
it "returns false for regular class", ->
215215
class BaseClass
216216
class ChildClass extends BaseClass
217217

218-
assert.false is_flow BaseClass
219-
assert.false is_flow ChildClass
218+
assert.false is_flow_class BaseClass
219+
assert.false is_flow_class ChildClass
220220

221221
it "returns false when passing a Flow instance directly", ->
222222
class MyFlow extends Flow
223223
f = MyFlow {}
224-
assert.false is_flow f
224+
assert.false is_flow_class f

0 commit comments

Comments
 (0)