allow assignment in elseif

Author: leafo

moonscript/parse.lua

@@ -398,8 +398,10 @@ local build_grammar = wrap_env(function()
 		SwitchCase = key"when" * Exp * key"then"^-1 * Body / mark"case",
 		SwitchElse = key"else" * Body / mark"else",
 
-		If = key"if" * (Exp * Assign^-1 / format_assign_for_if) * key"then"^-1 * Body *
-			((Break * CheckIndent)^-1 * EmptyLine^0 * key"elseif" * Exp * key"then"^-1 * Body / mark"elseif")^0 *
+		IfCond = Exp * Assign^-1 / format_assign_for_if,
+
+		If = key"if" * IfCond * key"then"^-1 * Body *
+			((Break * CheckIndent)^-1 * EmptyLine^0 * key"elseif" * IfCond * key"then"^-1 * Body / mark"elseif")^0 *
 			((Break * CheckIndent)^-1 * EmptyLine^0 * key"else" * Body / mark"else")^-1 / mark"if",
 
 		While = key"while" * Exp * key"do"^-1 * Body / mark"while",

moonscript/transform.lua

@@ -250,6 +250,30 @@ hoist_declarations = function(body, rules)
     assigns
   })
 end
+local expand_elseif_assign
+expand_elseif_assign = function(ifstm)
+  for i = 4, #ifstm do
+    local case = ifstm[i]
+    if ntype(case) == "elseif" and ntype(case[2]) == "assign" then
+      local split = {
+        unpack(ifstm, 1, i - 1)
+      }
+      insert(split, {
+        "else",
+        {
+          {
+            "if",
+            case[2],
+            case[3],
+            unpack(ifstm, i + 1)
+          }
+        }
+      })
+      return split
+    end
+  end
+  return ifstm
+end
 local constructor_name = "new"
 local Transformer
 Transformer = (function()
@@ -526,8 +550,7 @@ Statement = Transformer({
     return node
   end,
   ["if"] = function(self, node, ret)
-    smart_node(node)
-    if ntype(node.cond) == "assign" then
+    if ntype(node[2]) == "assign" then
       local _, assign, body = unpack(node)
       local name = assign[2][1]
       return build["do"]({
@@ -539,7 +562,9 @@ Statement = Transformer({
         }
       })
     end
+    node = expand_elseif_assign(node)
     if ret then
+      smart_node(node)
       node['then'] = apply_to_last(node['then'], ret)
       for i = 4, #node do
         local case = node[i]

moonscript/transform.moon

@@ -100,6 +100,20 @@ hoist_declarations = (body, rules) ->
 
   table.insert body, 1, {"declare", assigns}
 
+expand_elseif_assign = (ifstm) ->
+  for i = 4, #ifstm
+    case = ifstm[i]
+    if ntype(case) == "elseif" and ntype(case[2]) == "assign"
+      split = { unpack ifstm, 1, i - 1 }
+      insert split, {
+        "else", {
+          {"if", case[2], case[3], unpack ifstm, i + 1}
+        }
+      }
+      return split
+
+  ifstm
+
 constructor_name = "new"
 
 class Transformer
@@ -231,19 +245,21 @@ Statement = Transformer {
     node
 
   if: (node, ret) =>
-    smart_node node
 
-    -- extract assigns in cond
-    if ntype(node.cond) == "assign"
+    -- expand assign in cond
+    if ntype(node[2]) == "assign"
       _, assign, body = unpack node
       name = assign[2][1]
       return build["do"] {
         assign
         {"if", name, unpack node, 3}
       }
 
-    -- handle cascading return decorator
+    node = expand_elseif_assign node
+
+    -- apply cascading return decorator
     if ret
+      smart_node node
       -- mutate all the bodies
       node['then'] = apply_to_last node['then'], ret
       for i = 4, #node

tests/inputs/cond.moon

@@ -66,3 +66,26 @@ else
 hello = 5 + if something = 10
   print something
 
+---
+
+z = false
+
+if false
+  one
+elseif x = true
+  two
+elseif z = true
+  three
+else
+  four
+
+
+out = if false
+  one
+elseif x = true
+  two
+elseif z = true
+  three
+else
+  four
+

tests/outputs/cond.lua

@@ -109,4 +109,44 @@ hello = 5 + (function()
       return print(something)
     end
   end
-end)()
+end)()
+local z = false
+if false then
+  local _ = one
+else
+  do
+    local x = true
+    if x then
+      local _ = two
+    else
+      do
+        z = true
+        if z then
+          local _ = three
+        else
+          local _ = four
+        end
+      end
+    end
+  end
+end
+local out
+if false then
+  out = one
+else
+  do
+    local x = true
+    if x then
+      out = two
+    else
+      do
+        z = true
+        if z then
+          out = three
+        else
+          out = four
+        end
+      end
+    end
+  end
+end