fix: Reduced no. of iterations in default schema binding

Author: fahimalizain

frappe_graphql/utils/resolver/__init__.py

@@ -1,16 +1,45 @@
-from graphql import GraphQLSchema
+from graphql import GraphQLSchema, GraphQLType
+
+import frappe
+from frappe.model.meta import Meta
 
 from .root_query import setup_root_query_resolvers
 from .link_field import setup_link_field_resolvers
 from .child_tables import setup_child_table_resolvers
+from .utils import get_singular_doctype
 
 
 def setup_default_resolvers(schema: GraphQLSchema):
     setup_root_query_resolvers(schema=schema)
-    setup_link_field_resolvers(schema=schema)
-    setup_select_field_resolvers(schema=schema)
-    setup_child_table_resolvers(schema=schema)
+
+    # Setup custom resolvers for DocTypes
+    for type_name, gql_type in schema.type_map.items():
+        dt = get_singular_doctype(type_name)
+        if not dt:
+            continue
+
+        meta = frappe.get_meta(dt)
+
+        setup_frappe_df(meta, gql_type)
+        setup_link_field_resolvers(meta, gql_type)
+        setup_select_field_resolvers(meta, gql_type)
+        setup_child_table_resolvers(meta, gql_type)
+
+
+def setup_frappe_df(meta: Meta, gql_type: GraphQLType):
+    """
+    Sets up frappe-DocField on the GraphQLFields as `frappe_df`.
+    This is useful when resolving:
+    - Link / Dynamic Link Fields
+    - Child Tables
+    - Checking if the leaf-node is translatable
+    """
+    for df in meta.fields:
+        if df.fieldname not in gql_type.fields:
+            continue
+
+        gql_type.fields[df.fieldname].frappe_df = df
 
 
-def setup_select_field_resolvers(schema: GraphQLSchema):
+def setup_select_field_resolvers(meta: Meta, gql_type: GraphQLType):
     pass

frappe_graphql/utils/resolver/child_tables.py

@@ -1,25 +1,18 @@
-from graphql import GraphQLSchema, GraphQLResolveInfo
+from graphql import GraphQLType, GraphQLResolveInfo
 
-import frappe
+from frappe.model.meta import Meta
 
 from .dataloaders import get_child_table_loader
-from .utils import get_singular_doctype
+from .utils import get_frappe_df_from_resolve_info
 
 
-def setup_child_table_resolvers(schema: GraphQLSchema):
-    for type_name, gql_type in schema.type_map.items():
-        dt = get_singular_doctype(type_name)
-        if not dt:
+def setup_child_table_resolvers(meta: Meta, gql_type: GraphQLType):
+    for df in meta.get_table_fields():
+        if df.fieldname not in gql_type.fields:
             continue
 
-        meta = frappe.get_meta(dt)
-        for df in meta.get_table_fields():
-            if df.fieldname not in gql_type.fields:
-                continue
-
-            gql_field = gql_type.fields[df.fieldname]
-            gql_field.frappe_docfield = df
-            gql_field.resolve = _child_table_resolver
+        gql_field = gql_type.fields[df.fieldname]
+        gql_field.resolve = _child_table_resolver
 
 
 def _child_table_resolver(obj, info: GraphQLResolveInfo, **kwargs):
@@ -28,7 +21,7 @@ def _child_table_resolver(obj, info: GraphQLResolveInfo, **kwargs):
     if obj.get(info.field_name) is not None:
         return obj.get(info.field_name)
 
-    df = getattr(info.parent_type.fields[info.field_name], "frappe_docfield", None)
+    df = get_frappe_df_from_resolve_info(info)
     if not df:
         return []
 

frappe_graphql/utils/resolver/link_field.py

@@ -1,46 +1,40 @@
-from graphql import GraphQLSchema, GraphQLResolveInfo
+from graphql import GraphQLResolveInfo, GraphQLType
 
 import frappe
+from frappe.model.meta import Meta
 
 from .dataloaders import get_doctype_dataloader
-from .utils import get_singular_doctype
+from .utils import get_frappe_df_from_resolve_info
 
 
-def setup_link_field_resolvers(schema: GraphQLSchema):
+def setup_link_field_resolvers(meta: Meta, gql_type: GraphQLType):
     """
     This will set up Link fields on DocTypes to resolve target docs
     """
-    for type_name, gql_type in schema.type_map.items():
-        dt = get_singular_doctype(type_name)
-        if not dt:
-            continue
-
-        meta = frappe.get_meta(dt)
-        link_dfs = meta.get_link_fields() + meta.get_dynamic_link_fields() + \
-            _get_default_field_links()
+    link_dfs = meta.get_link_fields() + meta.get_dynamic_link_fields() + \
+        _get_default_field_links()
 
-        for df in link_dfs:
-            if df.fieldname not in gql_type.fields:
-                continue
+    for df in link_dfs:
+        if df.fieldname not in gql_type.fields:
+            continue
 
-            gql_field = gql_type.fields[df.fieldname]
-            gql_field.frappe_docfield = df
-            if df.fieldtype == "Link":
-                gql_field.resolve = _resolve_link_field
-            elif df.fieldtype == "Dynamic Link":
-                gql_field.resolve = _resolve_dynamic_link_field
-            else:
-                continue
+        gql_field = gql_type.fields[df.fieldname]
+        if df.fieldtype == "Link":
+            gql_field.resolve = _resolve_link_field
+        elif df.fieldtype == "Dynamic Link":
+            gql_field.resolve = _resolve_dynamic_link_field
+        else:
+            continue
 
-            _name_df = f"{df.fieldname}__name"
-            if _name_df not in gql_type.fields:
-                continue
+        _name_df = f"{df.fieldname}__name"
+        if _name_df not in gql_type.fields:
+            continue
 
-            gql_type.fields[_name_df].resolve = _resolve_link_name_field
+        gql_type.fields[_name_df].resolve = _resolve_link_name_field
 
 
 def _resolve_link_field(obj, info: GraphQLResolveInfo, **kwargs):
-    df = _get_frappe_docfield_from_resolve_info(info)
+    df = get_frappe_df_from_resolve_info(info)
     if not df:
         return None
 
@@ -55,7 +49,7 @@ def _resolve_link_field(obj, info: GraphQLResolveInfo, **kwargs):
 
 
 def _resolve_dynamic_link_field(obj, info: GraphQLResolveInfo, **kwargs):
-    df = _get_frappe_docfield_from_resolve_info(info)
+    df = get_frappe_df_from_resolve_info(info)
     if not df:
         return None
 
@@ -76,10 +70,6 @@ def _resolve_link_name_field(obj, info: GraphQLResolveInfo, **kwargs):
     return obj.get(df)
 
 
-def _get_frappe_docfield_from_resolve_info(info: GraphQLResolveInfo):
-    return getattr(info.parent_type.fields[info.field_name], "frappe_docfield", None)
-
-
 def _get_default_field_links():
 
     def _get_default_field_df(fieldname):

frappe_graphql/utils/resolver/utils.py

@@ -1,3 +1,5 @@
+from graphql import GraphQLResolveInfo
+
 import frappe
 
 SINGULAR_DOCTYPE_MAP_REDIS_KEY = "singular_doctype_graphql_map"
@@ -42,3 +44,7 @@ def get_plural_doctype(name):
         frappe.cache().set_value(PLURAL_DOCTYPE_MAP_REDIS_KEY, plural_map)
 
     return plural_map.get(name, None)
+
+
+def get_frappe_df_from_resolve_info(info: GraphQLResolveInfo):
+    return getattr(info.parent_type.fields[info.field_name], "frappe_df", None)