Merge pull request #54 from leancloud/fix/upload-file

nicecui · web-flow · commit 8f78458a2645 · 2022-10-27T11:14:49.000+08:00
(fix) Close resp body when uploading file.
diff --git a/.gitignore b/.gitignore
@@ -1 +1,2 @@
 vendor
+.envrc
diff --git a/leancloud/file.go b/leancloud/file.go
@@ -176,6 +176,7 @@ func (file *File) uploadQiniu(token, uploadURL string, reader io.ReadSeeker) err
 	if err != nil {
 		return fmt.Errorf("unexpected error when upload file to Qiniu: %v", err)
 	}
+	defer resp.Body.Close()
 
 	err = <-done
 	if err != nil {
@@ -269,6 +270,7 @@ func (file *File) uploadCOS(token, uploadURL string, reader io.ReadSeeker) error
 	if err != nil {
 		return fmt.Errorf("unexpected error when upload file to COS: %v", err)
 	}
+	defer resp.Body.Close()
 
 	err = <-done
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,7 @@ func (file *File) uploadQiniu(token, uploadURL string, reader io.ReadSeeker) err`
`176`	`176`	`if err != nil {`
`177`	`177`	`return fmt.Errorf("unexpected error when upload file to Qiniu: %v", err)`
`178`	`178`	`}`
	`179`	`+ defer resp.Body.Close()`
`179`	`180`
`180`	`181`	`err = <-done`
`181`	`182`	`if err != nil {`
`@@ -269,6 +270,7 @@ func (file *File) uploadCOS(token, uploadURL string, reader io.ReadSeeker) error`
`269`	`270`	`if err != nil {`
`270`	`271`	`return fmt.Errorf("unexpected error when upload file to COS: %v", err)`
`271`	`272`	`}`
	`273`	`+ defer resp.Body.Close()`
`272`	`274`
`273`	`275`	`err = <-done`
`274`	`276`	`if err != nil {`