feat: LCObject: saveEventually retries only if LCException httpStatus is 0, 429, 499, or >= 500

Author: huangliling

CHANGELOG.md

@@ -5,6 +5,17 @@ Following is change logs for recently release versions, you can refer to [releas
 > Warning:
 > DONOT upgrade java-websocket to 1.15.0(or above), bcz it doesn't work on Android 5.1 or earlier version.
 
+## 8.2.28 release
+
+#### Break changes
+- None
+
+#### New features
+- LCObject: saveEventually retries only if LCException httpStatus is 0, 429, 499, or >= 500
+
+#### Optimization and fixed bugs
+- None
+
 ## 8.2.27 release
 
 #### Break changes

HOW-TO-PUBLISH.md

@@ -48,6 +48,10 @@ signing.keyId=
 signing.password=
 signing.secretKeyRingFile=
 ```
+增加环境变量
+```
+export GPG_PASSPHRASE={signing.password}
+```
 2. 修改 root directory 下的 `CHANGELOG.md` 文件，增加新版本说明。
 3. 修改 android-sdk 目录下的 build.gradle 文件，将 `sdkVersion = "8.2.19"` 改为要发布的新版本（修改 Android SDK 依赖的基础 SDK 版本号）。
 4. 修改 android-sdk 目录下的 gradle.properties 文件，将 `VERSION_NAME=8.2.19` 改为要发布的新版本（修改 Android SDK 自己的版本号）。

android-sdk/build.gradle

@@ -32,7 +32,7 @@ allprojects {
 }
 
 ext {
-    sdkVersion = "8.2.23"
+    sdkVersion = "8.2.28"
     supportLibVersion = "26.1.0"
     converterVersion = "2.1.0"
     rxandroidVersion = "2.1.1"

android-sdk/gradle.properties

@@ -15,7 +15,7 @@ org.gradle.jvmargs=-Xmx1536m
 # This option should only be used with decoupled projects. More details, visit
 # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
 # org.gradle.parallel=true
-VERSION_NAME=8.2.23
+VERSION_NAME=8.2.28
 VERSION_CODE=2695
 GROUP=cn.leancloud
 

core/src/main/java/cn/leancloud/ArchivedRequests.java

@@ -129,14 +129,16 @@ public void onNext(LCObject LCObject) {
 
           @Override
           public void onError(Throwable throwable) {
-            logger.w("failed to save archived request. cause: ", throwable);
             if (throwable instanceof LCException) {
               LCException lcException = (LCException) throwable;
               int status = lcException.getHttpStatus();
+              logger.w("failed to save archived request. cause: " + lcException.getMessage() + ", code: " + lcException.getCode() + ", status: " + status);
               if (status == 0 || status == 429 || status >= 499) {
                 return;
               }
               onNext(null);
+            } else {
+              logger.w("failed to save archived request. cause: ", throwable);
             }
           }
 

core/src/main/java/cn/leancloud/LCObject.java

@@ -1184,7 +1184,15 @@ public void onNext(LCObject LCObject) {
 
         @Override
         public void onError(Throwable throwable) {
-          // failed, save data to local file first;
+          if (throwable instanceof LCException) {
+            LCException lcException = (LCException) throwable;
+            int status = lcException.getHttpStatus();
+            logger.w("failed to save object. cause: " + lcException.getMessage() + ", code: " + lcException.getCode() + ", status: " + status);
+            if (status != 0 && status != 429 && status < 499) {
+              return;
+            }
+          }
+          // failed, save data to local file and retry later
           add2ArchivedRequest(false);
         }