Merge pull request #180 from leeyeh/deprecate-existed

[chore] Deprecate AV.Object.prototype.existed().

Author: killme2008

lib/object.js

@@ -112,7 +112,6 @@ module.exports = function(AV) {
   // Attach all inheritable methods to the AV.Object prototype.
   _.extend(AV.Object.prototype, AV.Events,
            /** @lends AV.Object.prototype */ {
-    _existed: false,
     _fetchWhenSave: false,
 
     /**
@@ -789,8 +788,8 @@ module.exports = function(AV) {
       var self = this;
       var request = AV._request("classes", this.className, this.id, 'GET',
                                 fetchOptions);
-      return request.then(function(response, status, xhr) {
-        self._finishFetch(self.parse(response, status, xhr), true);
+      return request.then(function(response) {
+        self._finishFetch(self.parse(response), true);
         return self;
       })._thenRunCallbacks(options, this);
     },
@@ -927,8 +926,8 @@ module.exports = function(AV) {
         var makeRequest = options._makeRequest || AV._request;
         var request = makeRequest(route, className, model.id, method, json);
 
-        request = request.then(function(resp, status, xhr) {
-          var serverAttrs = model.parse(resp, status, xhr);
+        request = request.then(function(resp) {
+          var serverAttrs = model.parse(resp);
           if (options.wait) {
             serverAttrs = _.extend(attrs || {}, serverAttrs);
           }
@@ -988,7 +987,7 @@ module.exports = function(AV) {
      * Converts a response into the hash of attributes to be set on the model.
      * @ignore
      */
-    parse: function(resp, status, xhr) {
+    parse: function(resp) {
       var output = _.clone(resp);
       _(["createdAt", "updatedAt"]).each(function(key) {
         if (output[key]) {
@@ -998,9 +997,6 @@ module.exports = function(AV) {
       if (!output.updatedAt) {
         output.updatedAt = output.createdAt;
       }
-      if (status) {
-        this._existed = (status !== 201);
-      }
       return output;
     },
 
@@ -1067,12 +1063,13 @@ module.exports = function(AV) {
     },
 
     /**
-     * Returns true if this object was created by the AV server when the
+     * (DEPRECATED) Returns true if this object was created by the AV server when the
      * object might have already been there (e.g. in the case of a Facebook
      * login)
      */
     existed: function() {
-      return this._existed;
+      console.warn('AV.Object.prototype.existed() is deprecated.');
+      return false;
     },
 
     /**
@@ -1494,12 +1491,12 @@ module.exports = function(AV) {
               };
             })
 
-          }).then(function(response, status, xhr) {
+          }).then(function(response) {
             var error;
             AV._arrayEach(batch, function(object, i) {
               if (response[i].success) {
                 object._finishSave(
-                  object.parse(response[i].success, status, xhr));
+                  object.parse(response[i].success));
               } else {
                 error = error || response[i].error;
                 object._cancelSave();