better code

Author: wangxiao

demo/test-es5.js

@@ -8,19 +8,22 @@ AV.init({
   appKey: appKey
 });
 
+// 基本存储
 var TestClass = AV.Object.extend('TestClass');
 var testObj = new TestClass();
 testObj.set({
   name: 'hjiang',
   phone: '123123123'
 });
+
 testObj.save().then(function () {
   console.log('success');
 }).catch(function (err) {
   console.log('failed');
   console.log(err);
 });
 
+// 存储文件
 var base64 = 'd29ya2luZyBhdCBhdm9zY2xvdWQgaXMgZ3JlYXQh';
 var file = new AV.File('myfile.txt', { base64: base64 });
 file.metaData('format', 'txt file');

demo/test-es6.js

@@ -6,19 +6,22 @@ AV.init({
   appKey: appKey
 });
 
+// 基本存储
 const TestClass = AV.Object.extend('TestClass');
 const testObj = new TestClass();
 testObj.set({
   name: 'hjiang',
   phone: '123123123'
 });
+
 testObj.save().then(() => {
   console.log('success');
 }).catch((err) => {
   console.log('failed');
   console.log(err);
 });
 
+// 存储文件
 const base64 = 'd29ya2luZyBhdCBhdm9zY2xvdWQgaXMgZ3JlYXQh';
 var file = new AV.File('myfile.txt', { base64: base64 });
 file.metaData('format', 'txt file');

src/browserify-wrapper/ajax-browser.js

@@ -32,7 +32,7 @@ const ajax = (method, url, data, success, error) => {
   const appKey = AV.applicationKey;
   const masterKey = AV.masterKey;
 
-  // 清理
+  // 清理原来多余的数据（如果不清理，会污染数据表）
   if (data) {
     delete data._ApplicationId;
     delete data._ApplicationKey;
@@ -77,7 +77,7 @@ const ajax = (method, url, data, success, error) => {
       } else {
         url = url + '&';
       }
-      url = url + k + '=' + JSON.stringify(data[k]);
+      url = url + k + '=' + encodeURIComponent(JSON.stringify(data[k]));
       i ++;
     }
   }

src/browserify-wrapper/upload-browser.js

@@ -20,7 +20,8 @@ module.exports = function upload(file, AV, saveOptions) {
     var uptoken = response.token;
 
     var data = new FormData();
-    data.append("file", dataFormat, self._name);
+    data.append("file", dataFormat);
+    data.append('name', self._name);
     data.append("key", self._qiniu_key);
     data.append("token", uptoken);
 

test/file.js

@@ -17,9 +17,11 @@ describe('files', function() {
         file.destroy().then(function(){
           done();
         }, function(error){
+          console.log(error);
           done(error);
         });
       }, function(error){
+        console.log(error);
         done(error);
       });
     });
@@ -38,10 +40,11 @@ describe('files', function() {
         return AV._ajax('get', url).then(function() {
           done(new Error('Should not parsed as JSON'));
         }).catch(function(err) {
-          if (err.responseText.indexOf('GIF89a\u0018\u0000\u0018') !== -1)
+          if (err.responseText.indexOf('GIF89a\u0018\u0000\u0018') !== -1) {
             done();
-          else
+          } else {
             done(new Error('Response is not a gif image'));
+          }
         });
       }).catch(function(error) {
         done(error);

test/query.js

@@ -3,7 +3,9 @@
 // queries
 var GameScore = AV.Object.extend('GameScore');
 var Person = AV.Object.extend('Person');
+var TestClass = AV.Object.extend('TestClass');
 var query = new AV.Query(GameScore);
+
 describe('Queries', function () {
   describe('#Basic Queries', function () {
     it('should return Class Array', function (done) {
@@ -25,28 +27,14 @@ describe('Queries', function () {
 
     });
 
-    it('should return TestClass', function(done) {
-      var TestClass = AV.Object.extend('TestClass');
-      var testObj = new TestClass();
-      testObj.set({
+    it('should return TestClass', function() {
+      return new TestClass({
         name: 'hjiang',
         phone: '123123123'
-      });
-      testObj.save().then(function() {
-        var query = new AV.Query('TestClass');
-        query.equalTo('name', 'hjiang');
-        query.find().then(function(datas) {
-          var obj = datas[0];
-          if (obj && obj.get('name') === 'hjiang') {
-            done();
-          } else {
-            done('failed');
-          }
-        }).catch(function(err) {
-          done(err);
-        });
-      }).catch(function(err) {
-        done(err);
+      }).save().then(function() {
+        return new AV.Query(TestClass).equalTo('name', 'hjiang').find();
+      }).then(function(testObjects) {
+        expect(testObjects[0].get('name')).to.be('hjiang');
       });
     });