style: fix some linting alerts

Author: leeyeh

src/file.js

@@ -244,7 +244,7 @@ module.exports = function(AV) {
        * Returns a JSON version of the object.
        * @return {Object}
        */
-      toJSON: function(key, holder, seenObjects = [this]) {
+      toJSON(key, holder, seenObjects = [this]) {
         return this._toFullJSON(seenObjects, false);
       },
 
@@ -264,15 +264,15 @@ module.exports = function(AV) {
        * Returns the ACL for this file.
        * @returns {AV.ACL} An instance of AV.ACL.
        */
-      getACL: function() {
+      getACL() {
         return this._acl;
       },
 
       /**
        * Sets the ACL to be used for this file.
        * @param {AV.ACL} acl An instance of AV.ACL.
        */
-      setACL: function(acl) {
+      setACL(acl) {
         if (!(acl instanceof AV.ACL)) {
           return new AVError(AVError.OTHER_CAUSE, 'ACL must be a AV.ACL.');
         }
@@ -284,7 +284,7 @@ module.exports = function(AV) {
        * given by the user. After save is called, that name gets prefixed with a
        * unique identifier.
        */
-      name: function() {
+      name() {
         return this.get('name');
       },
 
@@ -293,7 +293,7 @@ module.exports = function(AV) {
        * after you get the file from a AV.Object.
        * @return {String}
        */
-      url: function() {
+      url() {
         return this.get('url');
       },
 
@@ -302,7 +302,7 @@ module.exports = function(AV) {
        * @param {String} The attribute name which want to get.
        * @returns {Any}
        */
-      get: function(attrName) {
+      get(attrName) {
         switch (attrName) {
           case 'objectId':
             return this.id;
@@ -325,7 +325,7 @@ module.exports = function(AV) {
        * @param {Object} value is an optional metadata value.
        * @returns {String|Number|Array|Object}
        */
-      set: function(...args) {
+      set(...args) {
         const set = (attrName, value) => {
           switch (attrName) {
             case 'name':
@@ -380,7 +380,7 @@ module.exports = function(AV) {
        * @param {String} attr an optional metadata key.
        * @param {Object} value an optional metadata value.
        **/
-      metaData: function(attr, value) {
+      metaData(attr, value) {
         if (attr && value) {
           this.attributes.metaData[attr] = value;
           return this;
@@ -401,20 +401,23 @@ module.exports = function(AV) {
        * @param {String} fmt 格式，默认为png，也可以为jpeg,gif等格式。
        */
 
-      thumbnailURL: function(width, height, quality, scaleToFit, fmt) {
+      thumbnailURL(
+        width,
+        height,
+        quality = 100,
+        scaleToFit = true,
+        fmt = 'png'
+      ) {
         const url = this.attributes.url;
         if (!url) {
           throw new Error('Invalid url.');
         }
         if (!width || !height || width <= 0 || height <= 0) {
           throw new Error('Invalid width or height value.');
         }
-        quality = quality || 100;
-        scaleToFit = !scaleToFit ? true : scaleToFit;
         if (quality <= 0 || quality > 100) {
           throw new Error('Invalid quality value.');
         }
-        fmt = fmt || 'png';
         const mode = scaleToFit ? 2 : 1;
         return (
           url +
@@ -435,15 +438,15 @@ module.exports = function(AV) {
        * Returns the file's size.
        * @return {Number} The file's size in bytes.
        **/
-      size: function() {
+      size() {
         return this.metaData().size;
       },
 
       /**
        * Returns the file's owner.
        * @return {String} The file's owner id.
        */
-      ownerId: function() {
+      ownerId() {
         return this.metaData().owner;
       },
 
@@ -453,7 +456,7 @@ module.exports = function(AV) {
        * @return {Promise} A promise that is fulfilled when the destroy
        *     completes.
        */
-      destroy: function(options) {
+      destroy(options) {
         if (!this.id) {
           return Promise.reject(new Error('The file id does not eixst.'));
         }
@@ -631,7 +634,7 @@ module.exports = function(AV) {
        * @return {Promise} A promise that is fulfilled when the fetch
        *     completes.
        */
-      fetch: function(fetchOptions, options) {
+      fetch(fetchOptions, options) {
         var request = AVRequest(
           'files',
           null,
@@ -642,7 +645,7 @@ module.exports = function(AV) {
         );
         return request.then(this._finishFetch.bind(this));
       },
-      _finishFetch: function(response) {
+      _finishFetch(response) {
         var value = AV.Object.prototype.parse(response);
         value.attributes = {
           name: value.name,

src/object.js

@@ -462,7 +462,6 @@ module.exports = function(AV) {
        * @private
        */
       _cancelSave: function() {
-        var self = this;
         var failedChanges = _.first(this._opSetQueue);
         this._opSetQueue = _.rest(this._opSetQueue);
         var nextChanges = _.first(this._opSetQueue);
@@ -728,7 +727,6 @@ module.exports = function(AV) {
 
         options.changes = {};
         var escaped = this._escapedAttributes;
-        var prev = this._previousAttributes || {};
 
         // Update attributes.
         AV._arrayEach(_.keys(attrs), function(attr) {
@@ -984,7 +982,7 @@ module.exports = function(AV) {
        * @see AVError
        */
       save: function(arg1, arg2, arg3) {
-        var i, attrs, current, options, saved;
+        var attrs, current, options;
         if (_.isObject(arg1) || isNullOrUndefined(arg1)) {
           attrs = arg1;
           options = arg2;
@@ -1720,7 +1718,6 @@ module.exports = function(AV) {
                     var method = object.id ? 'PUT' : 'POST';
 
                     var json = object._getSaveJSON();
-                    var query = {};
 
                     _.extend(json, object._flags);
 

src/promise.js

@@ -1,4 +1,3 @@
-var _ = require('underscore');
 var Promise = require('es6-promise').Promise;
 
 Promise._continueWhile = function(predicate, asyncFunction) {

src/user.js

@@ -497,7 +497,7 @@ module.exports = function(AV) {
        * @see AV.Object#save
        */
       save: function(arg1, arg2, arg3) {
-        var i, attrs, current, options, saved;
+        var attrs, options;
         if (_.isObject(arg1) || _.isNull(arg1) || _.isUndefined(arg1)) {
           attrs = arg1;
           options = arg2;

src/utils/localstorage-browser.js

@@ -1,5 +1,4 @@
 var _ = require('underscore');
-var Promise = require('../promise');
 
 // interface Storage {
 //   readonly attribute boolean async;