Merge pull request #111 from killme2008/feature/2015.07.09

Feature/2015.07.09

Author: killme2008

lib/promise.js

@@ -44,6 +44,15 @@
   _.extend(AV.Promise, /** @lends AV.Promise */ {
 
     _isPromisesAPlusCompliant: true,
+    _debugError: false,
+
+    setPromisesAPlusCompliant: function(isCompliant) {
+      AV.Promise._isPromisesAPlusCompliant = isCompliant;
+    },
+
+    setDebugError: function(enable) {
+      AV.Promise._debugError = enable;
+    },
 
     /**
      * Returns true iff the given object fulfils the Promise interface.
@@ -361,6 +370,9 @@
             try {
               result = [resolvedCallback.apply(this, result)];
             } catch (e) {
+              if(AV.Promise._debugError && e) {
+                console.error('Error occurred in promise resolve callback.', e.stack || e);
+              }
               result = [AV.Promise.error(e)];
             }
           } else {
@@ -385,6 +397,9 @@
             try {
               result = [rejectedCallback(error)];
             } catch (e) {
+              if(AV.Promise._debugError && e) {
+                console.error('Error occurred in promise reject callback.', e.stack || e);
+              }
               result = [AV.Promise.error(e)];
             }
           } else {
@@ -412,8 +427,14 @@
         func.call();
       };
       if (AV.Promise._isPromisesAPlusCompliant) {
-        if (typeof(setImmediate) !== 'undefined' && _.isFunction(setImmediate)) {
-          runLater = setImmediate;
+        if (typeof(window) !== 'undefined' && _.isFunction(window.setImmediate)) {
+          runLater = function(func) {
+            window.setImmediate(func);
+          };
+        } else if (typeof(process) !== 'undefined' && process.nextTick) {
+          runLater = function(func) {
+             process.nextTick(func);
+          };
         } else if (typeof(setTimeout) !== 'undefined' && _.isFunction(setTimeout)) {
           runLater = function(func) {
             setTimeout(func, 0);
@@ -428,7 +449,7 @@
         });
       } else if (this._rejected) {
         runLater(function() {
-          wrappedRejectedCallback(self._error);
+          wrappedRejectedCallback.apply(self, [self._error]);
         });
       } else {
         this._resolvedCallbacks.push(wrappedResolvedCallback);

test/promise.js

@@ -23,6 +23,22 @@ describe('promise', function() {
     });
   });
 
+
+  describe('AV.Promise._debugError', function() {
+    it('should log error', function(done) {
+      AV.Promise.setDebugError(true);
+      var p = new AV.Promise();
+      p.then(function() {
+        noThisMethod();
+      });
+      p.resolve(100);
+      p.finally(function(){
+         AV.Promise.setDebugError(false);
+        done();
+      });
+    });
+  });
+
   describe('always and finally', function(){
     it('should call always and finally', function(done){
       var p = new AV.Promise(function(resolve, reject) {