fix(Object): stop attempting to get attributes from this (#336)

Author: leeyeh

src/file.js

@@ -486,14 +486,16 @@ module.exports = function(AV) {
     get: function(attrName) {
       switch (attrName) {
         case 'objectId':
-        // 兼容 objectId
-        return this.id;
+        case 'id':
+          return this.id;
+        case 'url':
+        case 'name':
+        case 'metaData':
+        case 'createdAt':
+        case 'updatedAt':
+          return this.attributes[attrName];
         default:
-        if (this.attributes[attrName] === undefined) {
           return this.attributes.metaData[attrName];
-        } else {
-          return this.attributes[attrName];
-        }
       }
     },
 

src/object.js

@@ -310,15 +310,13 @@ module.exports = function(AV) {
     get: function(attr) {
       switch (attr) {
         case 'objectId':
-        // 兼容 objectId
-        return this.id;
-        default:
-        // 兼容 createdAt、updatedAt
-        if (this.attributes[attr] === undefined) {
+        case 'id':
+          return this.id;
+        case 'createdAt':
+        case 'updatedAt':
           return this[attr];
-        } else {
+        default:
           return this.attributes[attr];
-        }
       }
     },
 

test/object.js

@@ -12,6 +12,17 @@ describe('Objects', function(){
       done();
     });
   });
+  it('getter/setter compatible', function() {
+    Object.defineProperty(Post.prototype, 'name', {
+      get: function() {
+        return this.get('name');
+      },
+      set: function(value) {
+        return this.set('name', value);
+      }
+    });
+    new Post().name;
+  });
   describe('#Saving Objects', function(){
     it('should crate a Object', function(done){
       //gameScore.set("newcol","sss")

test/user.js

@@ -24,7 +24,7 @@ describe("User", function() {
         },
         error: function(user, error) {
           // Show the error message somewhere and let the user try again.
-          throw error;
+          done(err)or;
         }
       });
 
@@ -56,13 +56,13 @@ describe("User", function() {
               done();
             },
             error: function(err) {
-              throw err;
+              done(err);
             }
           });
           // Do stuff after successful login.
         },
         error: function(user, error) {
-          throw error;
+          done(error);
           // The login failed. Check error to see why.
         }
       });
@@ -136,7 +136,7 @@ describe("User", function() {
               });
               },
               error: function(err){
-              throw err;
+              done(err);
               }
               });
               */
@@ -160,7 +160,7 @@ describe("User", function() {
           });
         },
         error: function(err) {
-          throw err;
+          done(err);
         }
       });
     });
@@ -201,7 +201,7 @@ describe("User", function() {
               done();
             },
             error: function(err) {
-              throw err;
+              done(err);
             }
           });
         }
@@ -237,18 +237,18 @@ describe("User", function() {
                       done();
                     },
                     error: function(err) {
-                      throw err;
+                      done(err);
                     }
                   });
                 }, function(err) {
-                  throw err;
+                  done(err);
                 });
               }, function(err) {
-                throw err;
+                done(err);
               });
             },
             error: function(err) {
-              throw err;
+              done(err);
             }
           });
         },
@@ -274,7 +274,7 @@ describe("User", function() {
         expect(user.id).to.be.ok();
         done();
       }).catch(function(error) {
-        throw error;
+        done(err)or;
       });
     });
   });