feat(Role): remove defaultACL (#465)

Author: leeyeh

src/role.js

@@ -18,8 +18,7 @@ module.exports = function(AV) {
     * cloud.
      * @class AV.Role
      * @param {String} name The name of the Role to create.
-     * @param {AV.ACL} [acl] The ACL for this role. if absent, the default ACL
-     *    `{'*': { read: true }}` will be used.
+     * @param {AV.ACL} acl The ACL for this role.
      */
     constructor: function(name, acl) {
       if (_.isString(name)) {
@@ -28,16 +27,12 @@ module.exports = function(AV) {
       } else {
         AV.Object.prototype.constructor.call(this, name, acl);
       }
-      if (acl === undefined) {
-        var defaultAcl = new AV.ACL();
-        defaultAcl.setPublicReadAccess(true);
-        if(!this.getACL()) {
-          this.setACL(defaultAcl);
+      if (acl) {
+        if (!(acl instanceof AV.ACL)) {
+          throw new TypeError('acl must be an instance of AV.ACL');
+        } else {
+          this.setACL(acl);
         }
-      } else if (!(acl instanceof AV.ACL)) {
-        throw new TypeError('acl must be an instance of AV.ACL');
-      } else {
-        this.setACL(acl);
       }
     },
 

storage.d.ts

@@ -478,7 +478,7 @@ declare namespace AV {
      */
     export class Role extends Object {
 
-        constructor(name: string, acl?: ACL);
+        constructor(name: string, acl: ACL);
 
         getRoles(): Relation;
         getUsers(): Relation;

test/role.js

@@ -8,14 +8,9 @@ describe("Role", function() {
       expect(role.getName()).to.be('foo');
       expect(role.getACL()).to.be(acl);
     });
-    it("acl is optional", function() {
+    it("acl is required", function() {
       var role = new AV.Role('foo');
-      expect(role.getName()).to.be('foo');
-      expect(role.getACL().toJSON()).to.eql({
-        '*': {
-          read: true
-        }
-      });
+      return role.save().should.be.rejected();
     });
     it("type check", function() {
       expect(function() {

test/user.js

@@ -135,7 +135,9 @@ describe("User", function() {
       }).catch(function() {
         // already destroyed
       }).then(function() {
-        var role = new AV.Role("testRole");
+        const acl = new AV.ACL();
+        acl.setPublicReadAccess(true);
+        var role = new AV.Role("testRole", acl);
         role.getUsers().add(user);
         return role.save()
       }).then(function() {