fix(Object): add support to object.add(key, array) (#298)

Ensure the second param of AV.Object#add, AV.Object#addUnique,
AV.Object#remove to be an Array.

Author: leeyeh

src/error.js

@@ -103,7 +103,7 @@ _.extend(AVError, {
   /**
    * Error code indicating an invalid channel name. A channel name is either
    * an empty string (the broadcast channel) or contains only a-zA-Z0-9_
-   * characters and starts with a letter.
+   * characters.
    * @constant
    */
   INVALID_CHANNEL_NAME: 112,

src/object.js

@@ -715,7 +715,7 @@ module.exports = function(AV) {
      * @param item {} The item to add.
      */
     add: function(attr, item) {
-      return this.set(attr, new AV.Op.Add([item]));
+      return this.set(attr, new AV.Op.Add(utils.ensureArray(item)));
     },
 
     /**
@@ -727,7 +727,7 @@ module.exports = function(AV) {
      * @param item {} The object to add.
      */
     addUnique: function(attr, item) {
-      return this.set(attr, new AV.Op.AddUnique([item]));
+      return this.set(attr, new AV.Op.AddUnique(utils.ensureArray(item)));
     },
 
     /**
@@ -738,7 +738,7 @@ module.exports = function(AV) {
      * @param item {} The object to remove.
      */
     remove: function(attr, item) {
-      return this.set(attr, new AV.Op.Remove([item]));
+      return this.set(attr, new AV.Op.Remove(utils.ensureArray(item)));
     },
 
     /**

src/utils.js

@@ -9,6 +9,16 @@ const request = require('./request');
 // Helper function to check null or undefined.
 const isNullOrUndefined = (x) => _.isNull(x) || _.isUndefined(x);
 
+const ensureArray = target => {
+  if (_.isArray(target)) {
+    return target;
+  }
+  if (target === undefined || target === null) {
+    return [];
+  }
+  return [target];
+};
+
 const init = (AV) => {
   // 挂载一些配置
   const AVConfig = AV._config;
@@ -551,4 +561,5 @@ const init = (AV) => {
 module.exports = {
   init,
   isNullOrUndefined,
+  ensureArray,
 };

test/object.js

@@ -156,7 +156,47 @@ describe('Objects', function(){
     });
   });
 
+  describe('Array Data', function () {
+    let post;
+    beforeEach(function() {
+      post = new Post({
+        data: [1, 2],
+      });
+      return post.save();
+    });
+    afterEach(function() {
+      return post.destroy();
+    });
 
+    it('add', function() {
+      return post.add('data', 2).save().then(function() {
+        return post.fetch();
+      }).then(function(post) {
+        expect(post.get('data')).to.be.eql([1,2,2]);
+      });
+    });
+    it('addUnique', function() {
+      return post.addUnique('data', 2).save().then(function() {
+        return post.fetch();
+      }).then(function(post) {
+        expect(post.get('data')).to.be.eql([1,2]);
+      });
+    });
+    it('remove', function() {
+      return post.remove('data', 2).save().then(function() {
+        return post.fetch();
+      }).then(function(post) {
+        expect(post.get('data')).to.be.eql([1]);
+      });
+    });
+    it('accept array param', function() {
+      return post.remove('data', [2]).save().then(function() {
+        return post.fetch();
+      }).then(function(post) {
+        expect(post.get('data')).to.be.eql([1]);
+      });
+    });
+  });
 
   describe("Relational Data",function(){