refactor: fix code review issues

Author: leeyeh

src/insight.js

@@ -7,7 +7,7 @@ module.exports = function(AV) {
    * 包含了使用了 LeanCloud
    *  <a href='/docs/leaninsight_guide.html'>离线数据分析功能</a>的函数。
    * <p><strong><em>
-   *   部分函数仅在云引擎运行环境下有效。
+   *   仅在云引擎运行环境下有效。
    * </em></strong></p>
    * @namespace
    */

src/request.js

@@ -82,7 +82,7 @@ const ajax = (method, resourceUrl, data, headers = {}, onprogress) => {
     }
     req.end((err, res) => {
       if (res) {
-        debug(`response(${count})`, res.status, res.body && res.text, res.header);
+        debug(`response(${count})`, res.status, res.body || res.text, res.header);
       }
       if (err) {
         if (res) {
@@ -117,20 +117,20 @@ const setHeaders = (sessionToken) => {
     headers['User-Agent'] = AV._config.userAgent || `AV/${AV.version}; Node.js/${process.version}`;
   }
 
-  return new Promise((resolve) => {
+  return Promise.resolve().then(() => {
     // Pass the session token
     if (sessionToken) {
       headers['X-LC-Session'] = sessionToken;
-      resolve(headers);
+      return headers;
     } else if (!AV._config.disableCurrentUser) {
-      AV.User.currentAsync().then((currentUser) => {
+      return AV.User.currentAsync().then((currentUser) => {
         if (currentUser && currentUser._sessionToken) {
           headers['X-LC-Session'] = currentUser._sessionToken;
         }
-        resolve(headers);
+        return headers;
       });
     } else {
-      resolve(headers);
+      return headers;
     }
   });
 };

src/status.js

@@ -57,7 +57,7 @@ module.exports = function(AV) {
      */
     destroy: function(options){
       if(!this.id)
-        return AV.Promise.reject('The status id is not exists.');
+        return AV.Promise.reject(new Error('The status id is not exists.'));
       var request = AVRequest('statuses', null, this.id, 'DELETE', options && options.sessionToken);
       return request;
     },
@@ -93,7 +93,7 @@ module.exports = function(AV) {
     *      });
     */
     send: function(options = {}){
-      if(!AV.User.current() && !options.sessionToken) {
+      if(!options.sessionToken && !AV.User.current()) {
         throw new Error('Please signin an user.');
       }
       if(!this.query){
@@ -149,7 +149,7 @@ module.exports = function(AV) {
    *      });
    */
   AV.Status.sendStatusToFollowers = function(status, options = {}) {
-    if(!AV.User.current() && !options.sessionToken){
+    if(!options.sessionToken && !AV.User.current()){
       throw new Error('Please signin an user.');
     }
     return getUserPointer(options).then(currUser => {
@@ -192,7 +192,7 @@ module.exports = function(AV) {
    *      });
    */
   AV.Status.sendPrivateStatus = function(status, target, options = {}) {
-    if(!AV.User.current() && !options.sessionToken){
+    if(!options.sessionToken && !AV.User.current()){
       throw new Error('Please signin an user.');
     }
     if(!target){
@@ -240,7 +240,7 @@ module.exports = function(AV) {
   AV.Status.countUnreadStatuses = function(owner){
     var options = (!_.isString(arguments[1]) ? arguments[1] : arguments[2]) || {};
     var inboxType =  !_.isString(arguments[1]) ? 'default' : arguments[1];
-    if(!AV.User.current() && !options.sessionToken && owner == null){
+    if(!options.sessionToken && owner == null && !AV.User.current()){
       throw new Error('Please signin an user or pass the owner objectId.');
     }
     return getUser(options).then(owner => {

test/status.js

@@ -1,6 +1,14 @@
 'use strict';
 
 describe("AV.Status",function(){
+  before(function() {
+    var userName = this.userName = 'StatusTest' + Date.now();
+    return AV.User.signUp(userName, userName).then(user => {
+      this.user = user;
+    });
+  });
+
+  after(() => AV.User.logOut());
 
   describe("Send status.",function(){
     it("should send status to followers.",function(){