Fixed AV.Promise.all

Author: killme2008

lib/promise.js

@@ -126,10 +126,14 @@
 
       var promise = new AV.Promise();
 
-      var resolveOne = function() {
+      var resolveOne = function(i) {
         total = total - 1;
+        if(hadError && !promise._rejected && isAll) {
+          return promise.reject(promise, errors[i]);
+        }
+
         if (total === 0) {
-          if (hadError) {
+          if (hadError && !isAll) {
             promise.reject(errors);
           } else {
             if(isAll) {
@@ -145,15 +149,15 @@
         if (AV.Promise.is(object)) {
           object.then(function(result) {
             results[i] = result;
-            resolveOne();
+            resolveOne(i);
           }, function(error) {
             errors[i] = error;
             hadError = true;
-            resolveOne();
+            resolveOne(i);
           });
         } else {
           results[i] = object;
-          resolveOne();
+          resolveOne(i);
         }
       });
 
@@ -253,7 +257,8 @@
 
   /**
    * Just like AV.Promise.when, but it calls resolveCallbck function
-   * with one results array.
+   * with one results array and calls rejectCallback function as soon as one
+   * of promises rejects.
    * @see AV.Promise.when
    */
   AV.Promise.all = function(promises) {