refactor: remove AV._config.isNode (#421)

use conditional compile instead

Author: leeyeh

package.json

@@ -11,9 +11,9 @@
     "test": "NODE_ENV=test nyc --reporter lcov --reporter text mocha --timeout 300000 test/index.js",
     "docs": "jsdoc src README.md package.json -d docs -c .jsdocrc.json",
     "build:node": "gulp babel-node",
-    "build:browser": "PLATFORM=Browser webpack --config webpack/browser.js",
-    "build:rn": "PLATFORM=ReactNative webpack --config webpack/rn.js",
-    "build:weapp": "PLATFORM=Weapp webpack --config webpack/weapp.js",
+    "build:browser": "CLIENT_PLATFORM=Browser webpack --config webpack/browser.js",
+    "build:rn": "CLIENT_PLATFORM=ReactNative webpack --config webpack/rn.js",
+    "build:weapp": "CLIENT_PLATFORM=Weapp webpack --config webpack/weapp.js",
     "uglify:browser": "cd dist; uglifyjs av.js -m -c -o av-min.js --in-source-map av.js.map --source-map av-min.js.map; cd ..;",
     "uglify:weapp": "cd dist; uglifyjs av-weapp.js -m -c -o av-weapp-min.js --in-source-map av-weapp.js.map --source-map av-weapp-min.js.map; cd ..;",
     "build": "gulp build"

src/av.js

@@ -18,9 +18,6 @@ _.extend(AVConfig, {
   // 服务器的 URL，默认初始化时被设置为大陆节点地址
   APIServerURL: AVConfig.APIServerURL || '',
 
-  // 当前是否为 nodejs 环境
-  isNode: false,
-
   // 禁用 currentUser，通常用于多用户环境
   disableCurrentUser: false,
 
@@ -37,11 +34,6 @@ _.extend(AVConfig, {
  * @namespace AV
  */
 
-// Check whether we are running in Node.js.
-if (typeof(process) !== 'undefined' && process.versions && process.versions.node) {
-  AVConfig.isNode = true;
-}
-
 // Helpers
 // -------
 

src/file.js

@@ -132,7 +132,7 @@ module.exports = function(AV) {
       if (!data.blob.type) {
         data.blob.type = mimeType;
       }
-      if (process.env.PLATFORM === 'ReactNative' || process.env.PLATFORM === 'Weapp') {
+      if (process.env.CLIENT_PLATFORM === 'ReactNative' || process.env.CLIENT_PLATFORM === 'Weapp') {
         this._extName = extname(data.blob.uri);
       }
       this._source = Promise.resolve({ data: data.blob, type: mimeType });

src/init.js

@@ -8,7 +8,9 @@ const initialize = (appId, appKey, masterKey, hookKey) => {
   AV.applicationId = appId;
   AV.applicationKey = appKey;
   AV.masterKey = masterKey;
-  AV.hookKey = hookKey || (AV._config.isNode && process.env.LEANCLOUD_APP_HOOK_KEY);
+  if (!process.env.CLIENT_PLATFORM) {
+    AV.hookKey = hookKey || process.env.LEANCLOUD_APP_HOOK_KEY;
+  }
   AV._useMasterKey = false;
 };
 
@@ -31,7 +33,7 @@ AV.init = (...args) => {
     case 1:
       const options = args[0];
       if (typeof options === 'object') {
-        if (!AV._config.isNode && options.masterKey) {
+        if (process.env.CLIENT_PLATFORM && options.masterKey) {
           masterKeyWarn();
         }
         initialize(options.appId, options.appKey, options.masterKey, options.hookKey);
@@ -47,7 +49,7 @@ AV.init = (...args) => {
       console.warn('Please use AV.init() to replace AV.initialize(), ' +
        'AV.init() need an Object param, like { appId: \'YOUR_APP_ID\', appKey: \'YOUR_APP_KEY\' } . ' +
        'Docs: https://leancloud.cn/docs/sdk_setup-js.html');
-      if (!AV._config.isNode && args.length === 3) {
+      if (process.env.CLIENT_PLATFORM && args.length === 3) {
         masterKeyWarn();
       }
       initialize(...args);
@@ -57,7 +59,7 @@ AV.init = (...args) => {
 };
 
 // If we're running in node.js, allow using the master key.
-if (AV._config.isNode) {
+if (!process.env.CLIENT_PLATFORM) {
   AV.Cloud = AV.Cloud || {};
   /**
    * Switches the LeanCloud SDK to using the Master key.  The Master key grants

src/request.js

@@ -139,7 +139,7 @@ const setHeaders = (authOptions = {}, signKey) => {
   if (AV._config.applicationProduction !== null) {
     headers['X-LC-Prod'] = String(AV._config.applicationProduction);
   }
-  headers[AV._config.isNode ? 'User-Agent' : 'X-LC-UA'] = AV._config.userAgent;
+  headers[!process.env.CLIENT_PLATFORM ? 'User-Agent' : 'X-LC-UA'] = AV._config.userAgent;
 
   return Promise.resolve().then(() => {
     // Pass the session token

src/ua/index.js

@@ -1,4 +1,4 @@
 const version = require('../version');
-const comments = [process.env.PLATFORM || 'Node.js'].concat(require('./comments'));
+const comments = [process.env.CLIENT_PLATFORM || 'Node.js'].concat(require('./comments'));
 
 module.exports = `LeanCloud-JS-SDK/${version} (${comments.join('; ')})`;

webpack/common.js

@@ -34,7 +34,7 @@ module.exports = function() {
     },
     plugins: [
       new webpack.EnvironmentPlugin([
-        "PLATFORM"
+        "CLIENT_PLATFORM"
       ])
     ]
   }