fix: AVCacheManager's getter of diskCachePath is not safe

zapcannon87 · zapcannon87 · commit 3c75308c1c5a · 2019-04-24T10:36:16.000+08:00
diff --git a/AVOS/AVOSCloud/Cache/AVCacheManager.m b/AVOS/AVOSCloud/Cache/AVCacheManager.m
@@ -38,6 +38,7 @@ - (instancetype)init {
     self = [super init];
     if (self) {
         _cacheQueue = dispatch_queue_create("avos.paas.cacheQueue", DISPATCH_QUEUE_SERIAL);
+        _diskCachePath = [AVCacheManager path];
     }
     return self;
 }
@@ -47,13 +48,6 @@ + (NSString *)path {
     return [AVPersistenceUtils avCacheDirectory];
 }
 
-- (NSString *)diskCachePath {
-    if (!_diskCachePath) {
-        _diskCachePath = [AVCacheManager path];
-    }
-    return _diskCachePath;
-}
-
 - (NSString *)pathForKey:(NSString *)key {
     return [self.diskCachePath stringByAppendingPathComponent:key];
 }

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ - (instancetype)init {`
`38`	`38`	`self = [super init];`
`39`	`39`	`if (self) {`
`40`	`40`	`_cacheQueue = dispatch_queue_create("avos.paas.cacheQueue", DISPATCH_QUEUE_SERIAL);`
	`41`	`+ _diskCachePath = [AVCacheManager path];`
`41`	`42`	`}`
`42`	`43`	`return self;`
`43`	`44`	`}`
`@@ -47,13 +48,6 @@ + (NSString *)path {`
`47`	`48`	`return [AVPersistenceUtils avCacheDirectory];`
`48`	`49`	`}`
`49`	`50`
`50`		`-- (NSString *)diskCachePath {`
`51`		`- if (!_diskCachePath) {`
`52`		`- _diskCachePath = [AVCacheManager path];`
`53`		`- }`
`54`		`- return _diskCachePath;`
`55`		`-}`
`56`		`-`
`57`	`51`	`- (NSString )pathForKey:(NSString )key {`
`58`	`52`	`return [self.diskCachePath stringByAppendingPathComponent:key];`
`59`	`53`	`}`