Skip to content

Commit 6ba95cd

Browse files
committed
chore: tweak code
1 parent b08dd93 commit 6ba95cd

File tree

3 files changed

+8
-54
lines changed

3 files changed

+8
-54
lines changed

AVOS/Sources/Foundation/File/LCFile.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55

66
#import <Foundation/Foundation.h>
77
#import "LCUtils.h"
8-
#import "LCACL.h"
98

9+
@class LCObject;
10+
@class LCACL;
1011
@class LCFileQuery;
1112

1213
NS_ASSUME_NONNULL_BEGIN

AVOS/Sources/Foundation/File/LCFile.m

Lines changed: 6 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -134,16 +134,7 @@ - (instancetype)initWithData:(NSData *)data
134134
mimeType ?: @"application/octet-stream";
135135
});
136136

137-
_rawJSONData[kLCFile_metaData] = ({
138-
139-
NSMutableDictionary *metaData = [NSMutableDictionary dictionary];
140-
metaData[kLCFile_size] = @(data.length);
141-
NSString *objectId = LCPaasClient.sharedInstance.currentUser.objectId;
142-
if (objectId && objectId.length > 0) {
143-
metaData[kLCFile_owner] = objectId;
144-
}
145-
metaData.copy;
146-
});
137+
_rawJSONData[kLCFile_metaData] = @{ kLCFile_size : @(data.length) };
147138

148139
_ACL = ({
149140

@@ -196,16 +187,8 @@ - (instancetype)initWithLocalPath:(NSString *)localPath
196187
mimeType ?: @"application/octet-stream";
197188
});
198189

199-
_rawJSONData[kLCFile_metaData] = ({
200-
201-
NSMutableDictionary *metaData = [NSMutableDictionary dictionary];
202-
metaData[kLCFile_size] = fileAttributes[NSFileSize];
203-
NSString *objectId = [LCPaasClient sharedInstance].currentUser.objectId;
204-
if (objectId && objectId.length > 0) {
205-
metaData[kLCFile_owner] = objectId;
206-
}
207-
metaData.copy;
208-
});
190+
NSNumber *fileSize = fileAttributes[NSFileSize];
191+
_rawJSONData[kLCFile_metaData] = fileSize ? @{ kLCFile_size : fileSize } : @{};
209192

210193
_ACL = ({
211194

@@ -247,7 +230,7 @@ - (instancetype)initWithRemoteURL:(NSURL *)remoteURL
247230
mimeType ?: @"application/octet-stream";
248231
});
249232

250-
_rawJSONData[kLCFile_metaData] = @{ kLCFile___source : @"external" };
233+
_rawJSONData[kLCFile_metaData] = @{ @"__source" : @"external" };
251234

252235
_ACL = ({
253236

@@ -425,7 +408,7 @@ - (NSString *)url {
425408
- (NSDictionary *)metaData {
426409
__block NSDictionary *metaData;
427410
[self internalSyncLock:^{
428-
metaData = [LCFile decodingMetaDataFromDic:self->_rawJSONData];
411+
metaData = [NSDictionary _lc_decoding:self->_rawJSONData key:kLCFile_metaData];
429412
}];
430413
return metaData;
431414
}
@@ -667,6 +650,7 @@ - (void)uploadLocalDataWithData:(NSData *)data
667650
completionHandler:(void (^)(BOOL succeeded, NSError *error))completionHandler
668651
{
669652
NSMutableDictionary *parameters = [self rawJSONDataMutableCopy];
653+
[parameters removeObjectsForKeys:@[@"__type", @"className"]];
670654
[self getFileTokensWithParameters:parameters callback:^(LCFileTokens *fileTokens, NSError *error) {
671655

672656
if (error) {
@@ -1285,19 +1269,6 @@ + (NSString *)decodingObjectIdFromDic:(NSDictionary *)dic
12851269
return value;
12861270
}
12871271

1288-
+ (NSDictionary *)decodingMetaDataFromDic:(NSDictionary *)dic
1289-
{
1290-
/* @note For compatibility, should decoding multiple keys ... ... */
1291-
1292-
NSDictionary *value = [NSDictionary _lc_decoding:dic key:kLCFile_metaData];
1293-
1294-
if (value) { return value; }
1295-
1296-
value = [NSDictionary _lc_decoding:dic key:kLCFile_metadata];
1297-
1298-
return value;
1299-
}
1300-
13011272
// MARK: Compatibility
13021273

13031274
- (void)saveInBackgroundWithBlock:(void (^)(BOOL, NSError * _Nullable))block

AVOS/Sources/Foundation/File/LCFile_Internal.h

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -8,36 +8,18 @@
88

99
#import "LCFile.h"
1010

11-
//# _File : {} #//
1211
static NSString * const kLCFile_mime_type = @"mime_type";
1312
static NSString * const kLCFile_key = @"key";
1413
static NSString * const kLCFile_name = @"name";
15-
static NSString * const kLCFile___type = @"__type";
1614
static NSString * const kLCFile_url = @"url";
1715
static NSString * const kLCFile_provider = @"provider";
18-
19-
//### Meta Data of File Object ###//
20-
/// @note Totally, has two Keys to identify 'metaData' in history, @"metaData" is the latest Key.
2116
static NSString * const kLCFile_metaData = @"metaData";
22-
static NSString * const kLCFile_metadata = @"metadata";
23-
//### Meta Data of File Object ###//
24-
25-
//## metaData : {} ##//
26-
static NSString * const kLCFile_owner = @"owner";
2717
static NSString * const kLCFile_size = @"size";
28-
static NSString * const kLCFile__checksum = @"_checksum";
29-
static NSString * const kLCFile___source = @"__source";
30-
//## metaData : {} ##//
31-
3218
static NSString * const kLCFile_bucket = @"bucket";
33-
34-
//### Object ID of File Object ###//
3519
/// @note Totally, has three Keys to identify 'objectId' in history, @"objectId" is the latest Key and @"objId" used in IM messages.
3620
static NSString * const kLCFile_objectId = @"objectId";
3721
static NSString * const kLCFile_objId = @"objId";
3822
static NSString * const kLCFile_id = @"id";
39-
//### Object ID of File Object ###//
40-
//# _File : {} #//
4123

4224
@interface LCFile ()
4325

0 commit comments

Comments
 (0)