Print error stack for 5xx FunctionError only

Author: juvenn

src/LeanCloud/Engine/LeanEngine.php

@@ -571,8 +571,11 @@ protected function dispatch($method, $url) {
         try {
             $this->__dispatch($method, $url);
         } catch (FunctionError $ex) {
-            error_log($ex);
-            error_log($ex->getTraceAsString());
+            $status = (int) $ex->status;
+            if ( $status >= 500) {
+                error_log($ex);
+                error_log($ex->getTraceAsString());
+            }
             $this->renderError("{$ex->getMessage()}", $ex->getCode(), $ex->status);
         } catch (CloudException $ex) {
             error_log($ex);

test/engine/LeanEngineTest.php

@@ -212,5 +212,15 @@ public function test_messageReceived() {
         $this->assertEquals(false, $resp["result"]["drop"]);
     }
 
+    public function testFunctionError() {
+        try {
+            $this->request("/1.1/functions/customError", "POST", array());
+        } catch (CloudException $ex) {
+            $this->assertEquals("My custom error.", $ex->getMessage());
+            $this->assertEquals(1, $ex->getCode());
+            $this->assertEquals(500, $ex->status);
+        }
+    }
+
 }
 

test/engine/index.php

@@ -5,6 +5,7 @@
 use LeanCloud\Client;
 use LeanCloud\Engine\LeanEngine;
 use LeanCloud\Engine\Cloud;
+use LeanCloud\Engine\FunctionError;
 use LeanCloud\Storage\CookieStorage;
 
 Client::initialize(
@@ -25,6 +26,10 @@
     return "hello {$params['name']}";
 });
 
+Cloud::define("customError", function($params, $user) {
+    throw new FunctionError("My custom error.", 1, 500);
+});
+
 Cloud::define("_messageReceived", function($params, $user){
     if ($params["convId"]) {
         return array("drop" => false);