Should patrol_cli and artifacts be versioned separately?
#324
Closed
bartekpacia
started this conversation in
Ideas
Replies: 2 comments 1 reply
-
|
IMO native servers are not a part of CLI |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
TL;DR I'd say that native automators are separate from the CLI. Their version would not be the same as |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Currently,
AutomatorServer/iosandAutomatorServer/iosare very tightly tied topatrol_cli.Problem that the current approach causes:
patrol_clipatrol_cli's changelogs are bigger and doesn't necessarily concernpatrol_cliitselfpatrol_cliis ambiguous. For example, features such as Toggle Wi-Fi on iOS #322 require work onpatrol, the Dart package, and the native iOS automation server living inAutomatorServer/ios. Assigning it only apatrollabel is insufficient, assigningpatrolandpatrol_cliis incorrect, because Toggle Wi-Fi on iOS #322 doesn't actually require any work on the CLI side. We could create new labels (automator-iosorautomator-android) but still, to make them publicly available, we have to update the CLI.Or maybe there is some other way to structure the project. I'm very open to ideas.
Related (supercedes?) to #309
cc: @mateuszwojtczak @jakubfijalkowski
Beta Was this translation helpful? Give feedback.
All reactions