Conversation
Member
Author
|
Just found a crash while trying to compile cheerpj :( |
DutChen18
force-pushed
the
remove-gpet-2
branch
from
d50e735 to
b78556e
Compare
yuri91
requested changes
Sep 8, 2025
yuri91
approved these changes
Sep 8, 2025
Member
yuri91
left a comment
yuri91
left a comment
There was a problem hiding this comment.
Looks good to me.
Absorb the last commit into the previous ones appropriately.
The call to getPointerElementType still exists, but it should disappear naturally when more AS changes are merged into master.
DutChen18
force-pushed
the
remove-gpet-2
branch
from
c8e5848 to
dc6845d
Compare
Member
Author
|
Done 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No getPointerElementType calls are actually removed in the current changes. This is just support work that is needed for them to be removed later.