added agnosticPrintString to accompany new test suite

[alexbenkey]

added agnosticPrintString function to preexecutor, allowing for strings to be printed from the preexecutor to conform more with lit testing suite. Validation logic can now be handled externally in the test.h file as follows:

void assertEqual(double value, double expected, double epsilon, const char* msg)
{
if (value >= expected - epsilon && value <= expected + epsilon){
char buffer[256];
sprintf(buffer, "%s%g", msg, value);
agnosticPrintString(buffer);
}
}

optionally, the validation logic can be ignored entirely as the lit CHECK lines will fail if output is incorrect.

This solution simplifies the process of output generation from tests, while still allowing for descriptive messaging showing point of failure in a given test.

[alexbenkey]

corresponding tests.h functions:

template<typename T>
size_t format_and_append_value(char * buffer, size_t valueLength, T value){

	if constexpr (std::is_same_v<T, double>){
		return sprintf(buffer + valueLength, "%.10f ", value);
	}
	else if constexpr(std::is_same_v<T, float>){
		return sprintf(buffer + valueLength, "%.10f ", (double)value);
	}
	if constexpr (std::is_same_v<T, const char *>){
		return sprintf(buffer + valueLength, "%s ", value);
	}
	else if constexpr(std::is_integral_v<T>){
		return sprintf(buffer + valueLength, "%lld ", (long long)value);
	}

	return (0);
}

template<typename... Args>
void __preexecute_print_case(const char *msg, Args... vals)
#ifdef PRE_EXECUTE_TEST
; // defined in preexecuter
#else
{
	char buffer[1024];
	size_t offset = 0;

	offset += sprintf(buffer, "%s", msg);
	((offset += format_and_append_value(buffer, offset, vals)), ...);

	cheerp::console_log(buffer);

}
#endif

[yuri91]

and we should remove this. __preexecute_print_case is just a superset of it.

[yuri91]

corresponding tests.h functions:

template<typename T>
size_t format_and_append_value(char * buffer, size_t valueLength, T value){

	if constexpr (std::is_same_v<T, double>){
		return sprintf(buffer + valueLength, "%.10f ", value);
	}
	else if constexpr(std::is_same_v<T, float>){
		return sprintf(buffer + valueLength, "%.10f ", (double)value);
	}
	if constexpr (std::is_same_v<T, const char *>){
		return sprintf(buffer + valueLength, "%s ", value);
	}
	else if constexpr(std::is_integral_v<T>){
		return sprintf(buffer + valueLength, "%lld ", (long long)value);
	}

	return (0);
}

template<typename... Args>
void __preexecute_print_case(const char *msg, Args... vals)
#ifdef PRE_EXECUTE_TEST
; // defined in preexecuter
#else
{
	char buffer[1024];
	size_t offset = 0;

	offset += sprintf(buffer, "%s", msg);
	((offset += format_and_append_value(buffer, offset, vals)), ...);

	cheerp::console_log(buffer);

}
#endif

we should not use sprintf, but instead use js-native methods to convert numbers to strings (like toFixed(10) and toString()), and log a client::String*

[yuri91]

looks good now, but please squash all the commits together and put a relevant commit message