Merge pull request #90 from leanix/feature/cid-3656-fix-download-artifact

cid-3656: Fix download artifact

Author: henriq-amaral-leanix

src/main/kotlin/net/leanix/githubagent/handler/ArtifactDownloadHandler.kt

@@ -9,6 +9,7 @@ import net.leanix.githubagent.services.WebSocketService
 import org.slf4j.LoggerFactory
 import org.springframework.beans.factory.annotation.Autowired
 import org.springframework.context.annotation.Lazy
+import org.springframework.http.HttpStatus
 import org.springframework.messaging.simp.stomp.StompFrameHandler
 import org.springframework.messaging.simp.stomp.StompHeaders
 import org.springframework.stereotype.Component
@@ -72,11 +73,16 @@ class ArtifactDownloadHandler(
 
     private fun downloadAndSendArtifact(dto: ArtifactDownloadDTO, artifact: Artifact, token: String) = runCatching {
         val owner = dto.repositoryOwner
-        val repo = dto.repositoryOwner
-        gitHubClient.downloadArtifact(owner, repo, artifact.id, token).body()?.use { body ->
-            val artifactContent = Base64.getEncoder().encodeToString(body.asInputStream().readAllBytes())
-            sendArtifactEvent(dto, artifact.name, artifactContent)
-        } ?: logger.error("Failed to download artifact: ${artifact.name}")
+        val repo = dto.repositoryName
+        val response = gitHubClient.downloadArtifact(owner, repo, artifact.id, token)
+        if (response.status() == HttpStatus.OK.value()) {
+            response.body()?.use { body ->
+                val artifactContent = Base64.getEncoder().encodeToString(body.asInputStream().readAllBytes())
+                sendArtifactEvent(dto, artifact.name, artifactContent)
+            }
+        } else {
+            logger.error("Failed to download artifact: ${artifact.name}")
+        }
     }.onFailure {
         logger.error("Error processing artifact: ${artifact.name}", it)
     }

src/test/kotlin/net/leanix/githubagent/handler/ArtifactDownloadHandlerTest.kt

@@ -59,6 +59,7 @@ class ArtifactDownloadHandlerTest {
         every { gitHubClient.downloadArtifact(any(), any(), any(), any()) } returns Response
             .builder()
             .request(request)
+            .status(200)
             .body(readSbomFile()).build()
 
         // when
@@ -104,7 +105,9 @@ class ArtifactDownloadHandlerTest {
         every { gitHubClient.downloadArtifact(any(), any(), any(), any()) } returns Response
             .builder()
             .request(request)
-            .body(readSbomFile()).build()
+            .body(readSbomFile())
+            .status(200)
+            .build()
 
         // when
         artifactDownloadHandler.handleFrame(
@@ -122,6 +125,52 @@ class ArtifactDownloadHandlerTest {
             webSocketService.sendMessage("/artifact", any())
         }
     }
+
+    @Test
+    fun `it should receive message from server and not send empty artifact`() {
+        // given
+        every { gitHubAuthenticationService.getInstallationToken(any()) } returns "token"
+        every { gitHubClient.getRunArtifacts(any(), any(), any(), any()) } returns ArtifactsListResponse(
+            totalCount = 2,
+            artifacts = listOf(
+                Artifact(
+                    id = 1,
+                    name = "leanix-sbom-test-sbom",
+                    url = "http://download.url",
+                    archiveDownloadUrl = "http://download.url"
+                ),
+                Artifact(
+                    id = 2,
+                    name = "invalid-name",
+                    url = "http://download.url",
+                    archiveDownloadUrl = "http://download.url"
+                )
+            )
+        )
+        val request = mockk<Request>()
+        every { gitHubClient.downloadArtifact(any(), any(), any(), any()) } returns Response
+            .builder()
+            .request(request)
+            .status(404)
+            .build()
+
+        // when
+        artifactDownloadHandler.handleFrame(
+            StompHeaders(),
+            ArtifactDownloadDTO(
+                repositoryName = "repository",
+                repositoryOwner = "leanix",
+                runId = 1,
+                installationId = 1,
+            )
+        )
+
+        // then
+        verify(exactly = 0) {
+            webSocketService.sendMessage("/artifact", any())
+        }
+    }
+
     private fun readSbomFile(): ByteArray {
         val filePath = Paths.get("src/test/resources/sbom/leanix-sbom-test-sbom.zip")
         return Files.readAllBytes(filePath)