cid-3582: Change methods names, and add logs

Author: henriq-amaral-leanix

src/main/kotlin/net/leanix/githubagent/client/GitHubClient.kt

@@ -70,7 +70,7 @@ interface GitHubClient {
     ): GitHubSearchResponse
 
     @GetMapping("/api/v3/repos/{owner}/{repo}/actions/runs/{runId}/artifacts")
-    fun listRunArtifacts(
+    fun getRunArtifacts(
         @PathVariable("owner") owner: String,
         @PathVariable("repo") repo: String,
         @PathVariable("runId") runId: Long,

src/main/kotlin/net/leanix/githubagent/services/WebhookEventService.kt

@@ -55,7 +55,7 @@ class WebhookEventService(
         val owner = pushEventPayload.repository.owner.name
         val defaultBranch = pushEventPayload.repository.defaultBranch
 
-        val installationToken = getInstallationToken(pushEventPayload.installation.id)
+        val installationToken = gitHubAuthenticationService.getInstallationToken(pushEventPayload.installation.id)
 
         if (headCommit != null && pushEventPayload.ref == "refs/heads/$defaultBranch") {
             handleManifestFileChanges(
@@ -146,16 +146,6 @@ class WebhookEventService(
         }
     }
 
-    private fun getInstallationToken(installationId: Int): String {
-        var installationToken = cachingService.get("installationToken:$installationId")?.toString()
-        if (installationToken == null) {
-            gitHubAuthenticationService.refreshTokens()
-            installationToken = cachingService.get("installationToken:$installationId")?.toString()
-            require(installationToken != null) { "Installation token not found/ expired" }
-        }
-        return installationToken
-    }
-
     @SuppressWarnings("LongParameterList")
     private fun handleAddedOrModifiedManifestFile(
         repositoryFullName: String,

src/main/kotlin/net/leanix/githubagent/services/WorkflowRunService.kt

@@ -23,16 +23,22 @@ class WorkflowRunService(
     private val sbomConfig = SbomConfig()
 
     fun consumeWebhookPayload(payload: String) {
-        val event = parseEvent(payload) ?: return
-        if (!event.isCompleted()) return
+        runCatching {
+            val event = parseEvent(payload) ?: return
+            if (!event.isCompleted()) return
 
-        logger.info("Detected workflow event that successfully completed on default branch")
-        val installationToken = "Bearer ${gitHubAuthenticationService.getInstallationToken(event.installation.id)}"
+            logger.info("Detected workflow event that successfully completed")
+            val installationToken = "Bearer ${gitHubAuthenticationService.getInstallationToken(event.installation.id)}"
 
-        val artifacts = getValidArtifacts(event, installationToken)
-        if (artifacts.isEmpty()) return
-        logger.info("Found ${artifacts.size} artifact(s).")
-        processArtifacts(artifacts, event, installationToken)
+            getValidArtifacts(event, installationToken)
+                .takeIf { it.isNotEmpty() }
+                ?.let { artifacts ->
+                    logger.info("Found ${artifacts.size} artifact(s).")
+                    fetchAndProcessArtifacts(artifacts, event, installationToken)
+                } ?: logger.info("No artifacts found for the event")
+        }.onFailure {
+            logger.error("Failed to consume workflow webhook", it)
+        }
     }
     private fun parseEvent(payload: String): WorkflowRunEventDto? {
         return try {
@@ -47,12 +53,12 @@ class WorkflowRunService(
         val repo = event.repository.name
         val runId = event.workflowRun.id
 
-        return gitHubClient.listRunArtifacts(owner, repo, runId, token)
+        return gitHubClient.getRunArtifacts(owner, repo, runId, token)
             .artifacts
             .filter { sbomConfig.isFileNameValid(it.name, event.workflowRun.headBranch ?: "") }
     }
 
-    private fun processArtifacts(
+    private fun fetchAndProcessArtifacts(
         artifacts: List<Artifact>,
         event: WorkflowRunEventDto,
         installationToken: String

src/test/kotlin/net/leanix/githubagent/services/WebhookEventServiceTest.kt

@@ -56,6 +56,7 @@ class WebhookEventServiceTest {
     fun setUp() {
         val installation = Installation(1, Account("testInstallation"), permissions, events)
         every { gitHubAuthenticationService.refreshTokens() } returns Unit
+        every { gitHubAuthenticationService.getInstallationToken(any()) } returns "token"
         every { webSocketService.sendMessage(any(), any()) } returns Unit
         every { cachingService.get(any()) } returns "token"
         every { gitHubGraphQLService.getManifestFileContent(any(), any(), any(), any()) } returns "content"
@@ -64,31 +65,6 @@ class WebhookEventServiceTest {
         every { workflowRunService.consumeWebhookPayload(any()) } returns Unit
     }
 
-    @Test
-    fun `should refresh tokens if expired`() {
-        val payload = """{
-            "repository": {
-                "name": "repo",
-                "full_name": "owner/repo",
-                "owner": {"name": "owner"},
-                "default_branch": "main"
-            },
-            "head_commit": {
-                "added": [],
-                "modified": [],
-                "removed": []
-            },
-            "installation": {"id": 1},
-            "ref": "refs/heads/main"
-        }"""
-
-        every { cachingService.get("installationToken:1") } returns null andThen "token"
-
-        webhookEventService.consumeWebhookEvent("PUSH", payload)
-
-        verify(exactly = 1) { gitHubAuthenticationService.refreshTokens() }
-    }
-
     @Test
     fun `should process push event`() {
         val payload = """{

src/test/kotlin/net/leanix/githubagent/services/WorkflowRunServiceTest.kt

@@ -11,7 +11,6 @@ import net.leanix.githubagent.dto.ArtifactsListResponse
 import org.junit.jupiter.api.Test
 import java.nio.file.Files
 import java.nio.file.Paths
-import java.util.*
 
 class WorkflowRunServiceTest {
 
@@ -50,7 +49,7 @@ class WorkflowRunServiceTest {
             }
         }"""
         every { gitHubAuthenticationService.getInstallationToken(any()) } returns "token"
-        every { gitHubClient.listRunArtifacts(any(), any(), any(), any()) } returns ArtifactsListResponse(
+        every { gitHubClient.getRunArtifacts(any(), any(), any(), any()) } returns ArtifactsListResponse(
             totalCount = 2,
             artifacts = listOf(
                 Artifact(