Skip to content

Conversation

@pevogam
Copy link
Contributor

@pevogam pevogam commented Feb 10, 2026

The following is more useful due to the partial order application of LE in comparison to LT.


Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc) labels Feb 10, 2026
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

PR summary ff796754dd

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ le_one_iff_num_le_denom

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions
Copy link

github-actions bot commented Feb 10, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@pevogam pevogam changed the title Add a LE version Rat.lt_one_iff_num_le_denom theorem feat: Add a LE version Rat.lt_one_iff_num_le_denom theorem Feb 10, 2026
@pevogam pevogam changed the title feat: Add a LE version Rat.lt_one_iff_num_le_denom theorem feat: add a LE version Rat.lt_one_iff_num_le_denom theorem Feb 10, 2026
The following is more useful due to the partial order application
of LE in comparison to LT.

Signed-off-by: Plamen Dimitrov <[email protected]>
@pevogam
Copy link
Contributor Author

pevogam commented Feb 12, 2026

@wwylele I hope I have addressed all of your concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants