Skip to content

Conversation

@urkud
Copy link
Member

@urkud urkud commented Feb 11, 2026


Open in Gitpod

@urkud urkud added the easy < 20s of review time. See the lifecycle page for guidelines. label Feb 11, 2026
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

PR summary a2306eca72

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 11, 2026
Copy link
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good so far; it seems you have to remove two more unused arguments.

@grunweg grunweg self-assigned this Feb 11, 2026
@grunweg grunweg added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 11, 2026
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 12, 2026
@grunweg
Copy link
Contributor

grunweg commented Feb 12, 2026

Thanks!
bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Feb 12, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 12, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 12, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Charpoly/Disc): use nontriviality to drop a Nontrivial assumption [Merged by Bors] - chore(Charpoly/Disc): use nontriviality to drop a Nontrivial assumption Feb 12, 2026
@mathlib-bors mathlib-bors bot closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants