chore: import Aesop.Frontend when declaring aesop rule sets
#35165
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 7d6b43dc78
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.Prod.Lex | 165 | 166 | +1 (+0.61%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 6745 files with changed transitive imports taking up over 297811 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
Seems reasonable, thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
This PR turns some `import Aesop` into `import Aesop.Frontend` in places where we want to tag `aesop` lemmas, but do not yet want to use the tactic itself.
Contributor
|
Build failed (retrying...): |
Contributor
Author
|
bors r- It seems there is some sort of a merge conflict with this PR |
Contributor
|
Canceled. |
JovanGerb
commented
Feb 12, 2026
| le_refl := refl_of <| Prod.Lex _ _ | ||
| le_trans _ _ _ := trans_of <| Prod.Lex _ _ | ||
| lt_iff_le_not_ge x₁ x₂ := by aesop (add simp [le_iff, lt_iff, lt_iff_le_not_ge]) | ||
| lt_iff_le_not_ge x₁ x₂ := by grind [le_iff, lt_iff, lt_iff_le_not_ge] |
Contributor
Author
There was a problem hiding this comment.
The grind proof is visibly faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns some
import Aesopintoimport Aesop.Frontendin places where we want to tagaesoplemmas, but do not yet want to use the tactic itself.