-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: split T% elaborator into its own file and move to Topology
#35178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grunweg
wants to merge
32
commits into
leanprover-community:master
Choose a base branch
from
grunweg:move-totalspacemk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+764
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not exhaustive, but probably a good start.
…ct space, return that space and its base field A future commit will use this to warn on the product of two models with corners on normed spaces (as there are two potential models on it, which are not definitionally equal).
The inner loop handles finding a model on a non-product, and the outer loop will just be responsible for products, disjoint unions and open subsets of a manifold.
And update diagnostics for slight error message tweaks (for the better).
This makes the code clearer (and also makes it easier to change which information we store): reverting to e.g. just a Boolean is easier now.
This reverts commit 959a14c.
* would prefer to not have another trace, but it really messes up formatting to interpolate an `if` for some reason.
Improves an error message, and fixes a TODO in the code.
PR summary 4aa0616ac5Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
This PR/issue depends on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked-by-other-PR
This PR depends on another PR (this label is automatically managed by a bot)
WIP
Work in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: this currently breaks the tangentspace case, need to rewrite it to avoid match_expr!