Skip to content

Conversation

@grunweg
Copy link
Contributor

@grunweg grunweg commented Feb 12, 2026

TODO: this currently breaks the tangentspace case, need to rewrite it to avoid match_expr!


Open in Gitpod

grunweg and others added 30 commits January 28, 2026 18:19
These are not exhaustive, but probably a good start.
…ct space,

return that space and its base field

A future commit will use this to warn on the product of two models with corners
on normed spaces (as there are two potential models on it, which are not
definitionally equal).
The inner loop handles finding a model on a non-product, and the
outer loop will just be responsible for products, disjoint unions
and open subsets of a manifold.
And update diagnostics for slight error message tweaks (for the better).
This makes the code clearer (and also makes it easier to change which
information we store): reverting to e.g. just a Boolean is easier now.
* would prefer to not have another trace, but it really messes up formatting to interpolate an `if` for some reason.
@grunweg grunweg added the WIP Work in progress label Feb 12, 2026
@github-actions
Copy link

PR summary 4aa0616ac5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.VectorBundle.Notation (new file) 2199

Declarations diff

+ FindModelResult
+ NormedSpaceInfo
+ findModelInner
+ findSomeLocalHyp?
+ findSomeLocalInstanceOf?
+ instance : Coe Expr FindModelResult
+ totalSpaceMk
- findModel

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 12, 2026
@mathlib-dependent-issues
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants