Skip to content

Conversation

@adomani
Copy link
Collaborator

@adomani adomani commented Jan 16, 2026

Found by the linter at #34019.


Open in Gitpod

@adomani adomani marked this pull request as ready for review January 16, 2026 00:46
@github-actions
Copy link

PR summary 986dfcf2d2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@adomani adomani mentioned this pull request Jan 16, 2026
2 tasks
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

maintainer merge

## References
<https://leanprover-community.github.io/archive/stream/113488-general/topic/tactic.20question.html>
-/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this file should be deprecated, but not here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wanted to fix enough to make the linter compliant and leave everything else for later PRs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34043 deprecates the module

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 16, 2026
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 16, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 16, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 16, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove self-cancelling pairs [Merged by Bors] - chore: remove self-cancelling pairs Jan 16, 2026
@mathlib-bors mathlib-bors bot closed this Jan 16, 2026
@adomani adomani mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants