-
Notifications
You must be signed in to change notification settings - Fork 1k
[Merged by Bors] - chore: remove self-cancelling pairs #34021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: remove self-cancelling pairs #34021
Conversation
PR summary 986dfcf2d2Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
maintainer merge
| ## References | ||
| <https://leanprover-community.github.io/archive/stream/113488-general/topic/tactic.20question.html> | ||
| -/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this file should be deprecated, but not here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I wanted to fix enough to make the linter compliant and leave everything else for later PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#34043 deprecates the module
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
jcommelin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Found by the linter at #34019.
|
Pull request successfully merged into master. Build succeeded: |
Found by the linter at #34019.