Clean up infrastructure (#375)

Also fixes the build-frontend script.

Author: Garmelon

.github/workflows/remove-old-artifacts.yml

@@ -0,0 +1 @@
+{ "recommendations": ["Vue.volar", "esbenp.prettier-vscode"] }

.vscode/extensions.json

@@ -1,5 +1,4 @@
 {
-    "githubPullRequests.ignoredPullRequestBranches": [
-        "main"
-    ]
-}
+  "[jsonc]": { "editor.defaultFormatter": "esbenp.prettier-vscode" },
+  "[vue]": { "editor.defaultFormatter": "esbenp.prettier-vscode" }
+}

.vscode/settings.json

@@ -1,45 +1,22 @@
 #!/usr/bin/env python3
 
 import argparse
+import shlex
 import subprocess
+from pathlib import Path
 
-def build():
-    subprocess.run(
-        ["mvn", "package", "site", "jacoco:report-aggregate"],
-        cwd="backend",
-        check=True,
-    )
+DIR: Path = Path("backend")
 
-def clean():
-    subprocess.run(
-        ["mvn", "clean"],
-        cwd="backend",
-        check=True,
-    )
 
-def main():
-    parser = argparse.ArgumentParser()
-    parser.add_argument(
-        "--clean", "-c",
-        action="store_true",
-        help="clean up build files instead of building"
-    )
-    args = parser.parse_args()
+def run(*cmd: str | Path) -> None:
+    print(f"$ {shlex.join(str(arg) for arg in cmd)}")
+    subprocess.run(cmd, check=True, cwd=DIR)
 
-    if args.clean:
-        clean()
-    else:
-        try:
-            build()
-        except subprocess.CalledProcessError:
-            print()
-            print("Build failed :(")
-            exit(1)
-        else:
-            print()
-            print("Build successful :)")
-            print("The backend.jar is at backend/backend/target/backend.jar")
-            print("The runner.jar is at backend/runner/target/runner.jar")
 
-if __name__ == "__main__":
-    main()
+parser = argparse.ArgumentParser()
+_args = parser.parse_args()
+
+run("mvn", "package")
+print()
+print("The backend.jar is at backend/backend/target/backend.jar")
+print("The runner.jar is at backend/runner/target/runner.jar")

scripts/build-backend

@@ -1,70 +1,36 @@
 #!/usr/bin/env python3
 
 import argparse
-import shutil
+import shlex
 import subprocess
+from pathlib import Path
 
-def build(env):
-    subprocess.run(
-        ["yarnpkg", "install"],
-        cwd="frontend",
-        check=True,
-    )
+DIR: Path = Path("frontend")
 
-    if env is None:
-        subprocess.run(
-            ["yarnpkg", "build"],
-            cwd="frontend",
-            check=True,
-        )
-    else:
-        subprocess.run(
-            ["yarnpkg", "build", "--mode", env],
-            cwd="frontend",
-            check=True,
-        )
 
-def clean(clean_all=False):
-    print("Removing frontend/dist/")
-    shutil.rmtree("frontend/dist/", ignore_errors=True)
+def run(*cmd: str | Path) -> None:
+    print(f"$ {shlex.join(str(arg) for arg in cmd)}")
+    subprocess.run(cmd, check=True, cwd=DIR)
 
-    if clean_all:
-        print("Removing frontend/node_modules/")
-        shutil.rmtree("frontend/node_modules/", ignore_errors=True)
 
-def main():
-    parser = argparse.ArgumentParser()
-    parser.add_argument(
-        "--env",
-        metavar="NAME",
-        help="name of the build environment to use. A corresponding file"
-        " '.env.NAME' must be present in the frontend/ directory"
-    )
-    parser.add_argument(
-        "--clean", "-c",
-        action="store_true",
-        help="clean up build files instead of building"
-    )
-    parser.add_argument(
-        "--clean-all",
-        action="store_true",
-        help="like --clean, but also removes node_modules"
-    )
-    args = parser.parse_args()
+parser = argparse.ArgumentParser()
+parser.add_argument(
+    "--env",
+    metavar="NAME",
+    help="name of the build environment to use. A corresponding file"
+    " '.env.NAME' must be present in the frontend/ directory",
+)
+args = parser.parse_args()
 
-    if args.clean or args.clean_all:
-        clean(args.clean_all)
-    else:
-        try:
-            build(args.env)
-        except subprocess.CalledProcessError:
-            print()
-            print("Build failed :(")
-            exit(1)
-        else:
-            print()
-            print("Build successful :)")
-            print("The frontend files are at frontend/dist/")
+run(
+    "yarnpkg",
+    "install",
+    # Yarnpkg complains about incompatible node versions, but the build seems to
+    # run fine, so we just tell it to shut up.
+    "--ignore-engines",
+)
 
-if __name__ == "__main__":
-    main()
+if args.env is None:
+    run("yarnpkg", "build")
+else:
+    run("yarnpkg", "build", "--mode", args.env)

scripts/build-frontend

@@ -0,0 +1,19 @@
+#!/usr/bin/env python3
+
+import argparse
+import shlex
+import subprocess
+from pathlib import Path
+
+DIR: Path = Path("backend")
+
+
+def run(*cmd: str | Path) -> None:
+    print(f"$ {shlex.join(str(arg) for arg in cmd)}")
+    subprocess.run(cmd, check=True, cwd=DIR)
+
+
+parser = argparse.ArgumentParser()
+_args = parser.parse_args()
+
+run("mvn", "clean")

scripts/clean-backend

@@ -0,0 +1,27 @@
+#!/usr/bin/env python3
+
+import argparse
+import shutil
+from pathlib import Path
+
+DIR: Path = Path("frontend")
+
+
+def rm(path: Path) -> None:
+    print(f"Removing {path}")
+    shutil.rmtree(path, ignore_errors=True)
+
+
+parser = argparse.ArgumentParser()
+parser.add_argument(
+    "--all",
+    "-a",
+    action="store_true",
+    help="remove node_modules as well",
+)
+args = parser.parse_args()
+
+rm(DIR / "dist")
+
+if args.all:
+    rm(DIR / "node_modules")