fix: escape URLs in TeX output rather than treating them as verbatim (#713)

This fixes issues with nesting in \emph{}

Author: david-christiansen

src/tests/integration/code-content-doc/expected/tex/main.tex

@@ -31,7 +31,7 @@
 % hyperref and also makes the link useful on paper. If already in a footnote, the URL is
 % in parentheses instead.
 \let\oldhref\href
-\RenewDocumentCommand{\href}{vm}{%
+\RenewDocumentCommand{\href}{mm}{%
   \ifinfootnote%
     #2~(\url{#1})%
   \else%

src/tests/integration/extra-files-doc/expected/tex/main.tex

@@ -31,7 +31,7 @@
 % hyperref and also makes the link useful on paper. If already in a footnote, the URL is
 % in parentheses instead.
 \let\oldhref\href
-\RenewDocumentCommand{\href}{vm}{%
+\RenewDocumentCommand{\href}{mm}{%
   \ifinfootnote%
     #2~(\url{#1})%
   \else%

src/tests/integration/inheritance-doc/expected/tex/main.tex

@@ -31,7 +31,7 @@
 % hyperref and also makes the link useful on paper. If already in a footnote, the URL is
 % in parentheses instead.
 \let\oldhref\href
-\RenewDocumentCommand{\href}{vm}{%
+\RenewDocumentCommand{\href}{mm}{%
   \ifinfootnote%
     #2~(\url{#1})%
   \else%

src/tests/integration/sample-doc/expected/tex/main.tex

@@ -31,7 +31,7 @@
 % hyperref and also makes the link useful on paper. If already in a footnote, the URL is
 % in parentheses instead.
 \let\oldhref\href
-\RenewDocumentCommand{\href}{vm}{%
+\RenewDocumentCommand{\href}{mm}{%
   \ifinfootnote%
     #2~(\url{#1})%
   \else%

src/verso-manual/VersoManual/TeX.lean

@@ -40,7 +40,7 @@ r##"
 % hyperref and also makes the link useful on paper. If already in a footnote, the URL is
 % in parentheses instead.
 \let\oldhref\href
-\RenewDocumentCommand{\href}{vm}{%
+\RenewDocumentCommand{\href}{mm}{%
   \ifinfootnote%
     #2~(\url{#1})%
   \else%

src/verso/Verso/Doc/TeX.lean

@@ -73,7 +73,7 @@ public class GenreTeX (genre : Genre) (m : Type → Type) where
   inline (inlineTeX : Inline genre → TeXT genre m TeX) (container : genre.Inline) (contents : Array (Inline genre)) : TeXT genre m TeX
 
 def escapeForTexHref (s : String) : String :=
-  s.replace "%" "\\%"
+  s |>.replace "%" r#"\%"# |>.replace "#" r##"\#"##
 
 /--
 Replaces characters with strings simultaneously.