Skip to content

Unclear type of v in signature #157

@TheReturnOfJan

Description

@TheReturnOfJan

The v in signatures assigned to inputs has 2 conflicting types.

1.) 8-bit unsigned

assert(Util.isU8(v), 'v must be a uint8.');

2.) 8-bit signed

dataBuf.writeInt8(this.v, 97);

So the only possible values one can assign of v without throwing an exception are (0, 127), which is neither a byte (0, 255) or an unsigned byte (-128, 127).

But this is not critical at all since valid v's will always be in the range (0, 127) - read

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions