Fix reflection issue and CI (#32)

* Fix reflection issue

* Add imagick to CI

* Fix code style & static analysis

* Fix imagemagick in CI

* Install imagemagick manually

* Fix changelog

Author: jmsche

.github/workflows/continuous-integration.yml

@@ -34,6 +34,9 @@ jobs:
           coverage: pcov
           php-version: ${{ matrix.php-version }}
 
+      - name: Install Imagemagick
+        run: sudo apt-get update && sudo apt-get install -y imagemagick
+
       - name: Install Symfony Flex
         run: |
           composer config --global --no-plugins allow-plugins.symfony/flex true

CHANGELOG-5.x.md

@@ -1,3 +1,10 @@
+5.1.1
+-----
+
+* Fix reflection issue
+* Fix code style & static analysis
+* Fix CI
+
 5.1.0
 -----
 

src/Command/ClearCommand.php

@@ -36,7 +36,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $age = $input->getArgument('age');
         if ($age) {
-            $output->writeln(sprintf('Clearing the IM cache older than %s days', $age));
+            $output->writeln(\sprintf('Clearing the IM cache older than %s days', $age));
 
             $finder = new Finder();
             foreach ($finder->in($cacheDir)->files()->date('until ' . $age . ' days ago') as $file) {

src/Controller/DefaultController.php

@@ -27,7 +27,7 @@ public function index(Manager $im, Request $request, string $format, string $pat
         }
 
         if (!$im->cacheExists($format, $path)) {
-            throw new RuntimeException(sprintf('Caching of image failed for %s in %s format', $path, $format));
+            throw new RuntimeException(\sprintf('Caching of image failed for %s in %s format', $path, $format));
         }
 
         $extension = pathinfo($path, \PATHINFO_EXTENSION);

src/Listener/MogrifySubscriber.php

@@ -67,8 +67,8 @@ private function checkClassConfig(object $entity, EntityManagerInterface $entity
             foreach ($meta->getReflectionProperties() as $property) {
                 if (null !== $property) {
                     if ($meta->isMappedSuperclass && !$property->isPrivate()
-                        || $meta->isInheritedField($property->name)
-                        || isset($meta->associationMappings[$property->name]['inherited'])
+                        || $meta->isInheritedField($property->getName())
+                        || isset($meta->associationMappings[$property->getName()]['inherited'])
                     ) {
                         continue;
                     }

src/Manager.php

@@ -167,7 +167,7 @@ private function convertFormat(mixed $format): array
             return ['thumbnail' => $format];
         }
 
-        throw new InvalidArgumentException(sprintf('Unknown IM format: %s', $format));
+        throw new InvalidArgumentException(\sprintf('Unknown IM format: %s', $format));
     }
 
     /**
@@ -176,11 +176,11 @@ private function convertFormat(mixed $format): array
     private function checkImage(string $path): void
     {
         if (!file_exists($this->getPublicDirectory() . '/' . $path) && !file_exists($path)) {
-            throw new NotFoundException(sprintf('Unable to find the image "%s" to cache', $path));
+            throw new NotFoundException(\sprintf('Unable to find the image "%s" to cache', $path));
         }
 
         if (!is_file($this->getPublicDirectory() . '/' . $path) && !is_file($path)) {
-            throw new HttpException(400, sprintf('[ImBundle] "%s" is no file', $path));
+            throw new HttpException(400, \sprintf('[ImBundle] "%s" is no file', $path));
         }
     }
 

src/Twig/Extension/ImExtension.php

@@ -58,6 +58,7 @@ public function convert(string $html): string
             if (!empty($width) || !empty($height)) {
                 $format = $width . 'x' . $height;
                 $updatedTagString = preg_replace("| src=[\"']" . $src . "[\"']|", ' src="' . $this->imResize($src, $format) . '"', $img);
+                \assert(null !== $updatedTagString);
                 $html = str_replace($img, $updatedTagString, $html);
             }
         }

src/Wrapper.php

@@ -66,7 +66,7 @@ public function checkDirectory(string $path): void
     {
         $dir = \dirname($path);
         if (!is_dir($dir) && !mkdir($dir, 0777, true) && !is_dir($dir)) {
-            throw new RuntimeException(sprintf('Unable to create the "%s" directory', $dir));
+            throw new RuntimeException(\sprintf('Unable to create the "%s" directory', $dir));
         }
     }