Skip to content

Commit 05778ec

Browse files
committed
Readded TODOs 😡
1 parent b4d268e commit 05778ec

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

layersbox

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -422,9 +422,12 @@ def box_install(args):
422422

423423
# get internal IP of new container
424424
# (linking only those container names that appear there)
425+
#TODO: AFTER SOLVING A TODO ONLY REMOVE THE "TODO:" FROM THE LINE!!!
426+
#TODO: find out the containers to link, e.g. by reading out nginx.conf
427+
#TODO: currently, this only gets the IP if there is a container that by coincidence has the same name as the installer
425428
container_ip = subprocess.check_output(["docker", "inspect",
426429
"-f", "'{{ .NetworkSettings.IPAddress }}'", service_name]).replace("'", "").strip()
427-
430+
428431
entries_list=[]
429432
#separator_location="location"
430433
separator_http="http"
@@ -433,8 +436,8 @@ def box_install(args):
433436
with open(join(servicedir, service_name, "nginx.conf")) as infile, open(join(servicedir, service_name, "nginx." + service_name + ".conf"), 'w') as outfile:
434437
for line in infile:
435438
if separator_http in line:
436-
# for line in infile:
437-
# print("Read the following line:{}".format(line))
439+
# for line in infile:
440+
# print("Read the following line:{}".format(line))
438441
entry_name=re.search(r'\//(.*)\:', line.split()[1]).group(0)[2:-1]
439442
entries_list.extend(entry_name)
440443
print("The following location will be added to the Adapter: {}".format(entry_name))
@@ -445,8 +448,10 @@ def box_install(args):
445448
outfile.write(line)
446449

447450
# copy nginx.conf into container
451+
#TODO: run the script directly from python
448452
subprocess.check_output(["./add_nginx_conf.sh", service_name])
449453

454+
#TODO: send signal HUP to adapter container (currently done from shell)
450455

451456
return 0
452457

0 commit comments

Comments
 (0)