diff --git a/.clang-tidy b/.clang-tidy index 09a28a467..e8251bfcc 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -20,6 +20,7 @@ Checks: > -misc-unused-parameters, -misc-use-anonymous-namespace, -modernize-avoid-c-arrays, + -modernize-loop-convert, -modernize-use-nodiscard, -modernize-use-trailing-return-type, -readability-function-cognitive-complexity, diff --git a/modules/core/perf/include/perf.hpp b/modules/core/perf/include/perf.hpp index e8aca62dd..34c23572a 100644 --- a/modules/core/perf/include/perf.hpp +++ b/modules/core/perf/include/perf.hpp @@ -27,10 +27,10 @@ struct PerfResults { class Perf { public: // Init performance analysis with initialized task and initialized data - explicit Perf(const std::shared_ptr& task); + explicit Perf(const std::shared_ptr& task_ptr); // Set task with initialized task and initialized data for performance // analysis c - void SetTask(const std::shared_ptr& task); + void SetTask(const std::shared_ptr& task_ptr); // Check performance of full task's pipeline: pre_processing() -> // validation() -> run() -> post_processing() void PipelineRun(const std::shared_ptr& perf_attr, diff --git a/modules/core/perf/src/perf.cpp b/modules/core/perf/src/perf.cpp index 7ef264d16..7d68329bd 100644 --- a/modules/core/perf/src/perf.cpp +++ b/modules/core/perf/src/perf.cpp @@ -7,11 +7,11 @@ #include #include -ppc::core::Perf::Perf(const std::shared_ptr& task) { SetTask(task); } +ppc::core::Perf::Perf(const std::shared_ptr& task_ptr) { SetTask(task_ptr); } -void ppc::core::Perf::SetTask(const std::shared_ptr& task) { - task->get_data()->state_of_testing = TaskData::StateOfTesting::PERF; - this->task = task; +void ppc::core::Perf::SetTask(const std::shared_ptr& task_ptr) { + task_ptr->get_data()->state_of_testing = TaskData::StateOfTesting::PERF; + this->task = task_ptr; } void ppc::core::Perf::PipelineRun(const std::shared_ptr& perf_attr, diff --git a/tasks/omp/example/src/ops_omp.cpp b/tasks/omp/example/src/ops_omp.cpp index 1da6000e5..0666e6bbe 100644 --- a/tasks/omp/example/src/ops_omp.cpp +++ b/tasks/omp/example/src/ops_omp.cpp @@ -63,18 +63,18 @@ bool nesterov_a_test_task_omp::TestOMPTaskParallel::run_impl() { auto temp_res = res; if (ops == "+") { #pragma omp parallel for reduction(+ : temp_res) - for (int i : input_) { - temp_res += i; + for (int i = 0; i < static_cast(input_.size()); i++) { + temp_res += input_[i]; } } else if (ops == "-") { #pragma omp parallel for reduction(- : temp_res) - for (int i : input_) { - temp_res -= i; + for (int i = 0; i < static_cast(input_.size()); i++) { + temp_res -= input_[i]; } } else if (ops == "*") { #pragma omp parallel for reduction(* : temp_res) - for (int i : input_) { - temp_res *= i; + for (int i = 0; i < static_cast(input_.size()); i++) { + temp_res *= input_[i]; } } res = temp_res;