Clean up language switcher and core-base styling.

Author: rtibbles

kolibri/core/assets/src/styles/main.styl

@@ -29,7 +29,6 @@ html
   font-size: 100%
   text-size-adjust: 100%
   box-sizing: border-box
-  overflow-y: scroll
   // from normalize v5
   line-height: 1.15
 

kolibri/core/assets/src/views/core-base.vue

@@ -157,7 +157,6 @@
 
   .content-container
     position: absolute
-    overflow-y: scroll
     overflow-x: hidden
     right: 0
     bottom: 0

kolibri/core/assets/src/views/language-switcher/index.vue

@@ -2,13 +2,11 @@
 
   <div>
     <div v-if="footer" class="page-footer">
-      <div>
-        <ul class="language-list">
-          <li v-for="language in languageOptions" :class="selectedLanguage===language.code ? 'selected item' : 'choice item'" @click="setAndSwitchLanguage(language.code)">
-            {{ language.name }}
-          </li>
-        </ul>
-      </div>
+      <ul class="language-list">
+        <li v-for="language in languageOptions" :class="selectedLanguage===language.code ? 'selected item' : 'choice item'" @click="setAndSwitchLanguage(language.code)">
+          {{ language.name }}
+        </li>
+      </ul>
     </div>
     <core-modal
       v-if="showModal"
@@ -107,8 +105,10 @@
         });
       },
       setAndSwitchLanguage(languageCode) {
-        this.selectedLanguage = languageCode;
-        this.switchLanguage();
+        if (languageCode != this.selectedLanguage) {
+          this.selectedLanguage = languageCode;
+          this.switchLanguage();
+        }
       },
       closeModal() {
         this.internalModalOpen = false;
@@ -141,6 +141,7 @@
     padding-left: 32px
     padding-top: 16px
     padding-bottom: 16px
+    text-align: center
     button
       float: right
       position: absolute
@@ -152,10 +153,14 @@
     list-style: none
     margin: 0
     padding: 0
+    text-align: initial
+    display: inline-block
 
   .item
     display: inline-block
     padding-top: 6px
     padding-right: 20px
+    &.choice
+      cursor: pointer
 
 </style>

kolibri/plugins/user/assets/src/views/index.vue

@@ -4,8 +4,10 @@
     <core-base :navBarNeeded="navBarNeeded" :topLevelPageName="topLevelPageName" :appBarTitle="appBarTitle">
       <component v-if="navBarNeeded" :is="currentPage"/>
     </core-base>
-    <component v-if="!navBarNeeded" :is="currentPage"/>
-    <language-switcher v-if="!navBarNeeded" :footer="true"/>
+    <div v-if="!navBarNeeded" class="full-page">
+      <component :is="currentPage"/>
+      <language-switcher :footer="true"/>
+    </div>
   </div>
 
 </template>
@@ -72,4 +74,10 @@
 
   @require '~kolibri.styles.definitions'
 
+  .full-page
+    position: absolute
+    top: 0
+    height: 100%
+    width: 100%
+
 </style>

kolibri/plugins/user/assets/src/views/sign-in-page/index.vue

@@ -257,8 +257,7 @@
     background: $core-bg-canvas
     background: linear-gradient(rgba(0, 0, 0, 0.7), rgba(0, 0, 0, 0.7)), url(./background.png) no-repeat center center fixed
     background-size: cover
-    overflow-y: auto
-    overflow-x: hidden
+    overflow: hidden
 
   #login-container
     display: block