Merge pull request #1967 from jonboiser/remove-scratchpad

Remove scratchpad code from manage, learn, user plugins

Author: rtibbles

.eslintrc

@@ -23,4 +23,4 @@ rules:
   vue/html-quotes: [2, 'double']
   vue/order-in-components: 2
   # ignores the 'kolibri.*' imports
-  import/no-unresolved: [2, { ignore: ['kolibri\.'] }]
+  import/no-unresolved: [2, { ignore: ['kolibri[_.]'] }]

kolibri/plugins/learn/assets/src/app.js

@@ -38,13 +38,6 @@ class LearnModule extends KolibriModule {
             actions.redirectToChannelSearch(store);
           },
         },
-        {
-          name: PageNames.SCRATCHPAD,
-          path: '/scratchpad',
-          handler: (toRoute, fromRoute) => {
-            actions.showScratchpad(store);
-          },
-        },
         {
           name: PageNames.CONTENT_UNAVAILABLE,
           path: '/content-unavailable',

kolibri/plugins/learn/assets/src/constants.js

@@ -7,7 +7,6 @@ const PageNames = {
   LEARN_ROOT: 'LEARN_ROOT',
   LEARN_CHANNEL: 'LEARN_CHANNEL',
   LEARN_CONTENT: 'LEARN_CONTENT',
-  SCRATCHPAD: 'SCRATCHPAD',
   CONTENT_UNAVAILABLE: 'CONTENT_UNAVAILABLE',
   SEARCH_ROOT: 'SEARCH_ROOT',
   SEARCH: 'SEARCH',

kolibri/plugins/learn/assets/src/state/actions.js

@@ -463,14 +463,6 @@ function clearSearch(store) {
   });
 }
 
-function showScratchpad(store) {
-  store.dispatch('SET_PAGE_NAME', PageNames.SCRATCHPAD);
-  store.dispatch('SET_PAGE_STATE', {});
-  store.dispatch('CORE_SET_PAGE_LOADING', false);
-  store.dispatch('CORE_SET_ERROR', null);
-  store.dispatch('CORE_SET_TITLE', 'Scratchpad');
-}
-
 function showContentUnavailable(store) {
   store.dispatch('SET_PAGE_NAME', PageNames.CONTENT_UNAVAILABLE);
   store.dispatch('SET_PAGE_STATE', {});
@@ -807,7 +799,6 @@ export {
   showExploreContent,
   showLearnChannel,
   showLearnContent,
-  showScratchpad,
   showContentUnavailable,
   triggerSearch,
   clearSearch,

kolibri/plugins/learn/assets/src/views/index.vue

@@ -56,7 +56,6 @@
   import explorePage from './explore-page';
   import contentPage from './content-page';
   import learnPage from './learn-page';
-  import scratchpadPage from './scratchpad-page';
   import contentUnavailablePage from './content-unavailable-page';
   import coreBase from 'kolibri.coreVue.components.coreBase';
   import channelSwitcher from './channel-switcher';
@@ -81,7 +80,6 @@
       explorePage,
       contentPage,
       learnPage,
-      scratchpadPage,
       contentUnavailablePage,
       coreBase,
       channelSwitcher,
@@ -147,9 +145,6 @@
         if (this.pageName === PageNames.LEARN_CHANNEL) {
           return 'learn-page';
         }
-        if (this.pageName === PageNames.SCRATCHPAD) {
-          return 'scratchpad-page';
-        }
         if (this.pageName === PageNames.CONTENT_UNAVAILABLE) {
           return 'content-unavailable-page';
         }

kolibri/plugins/learn/assets/src/views/scratchpad-page/index.vue

@@ -62,13 +62,6 @@ class ManagementModule extends KolibriModule {
             actions.showFacilityConfigPage(store);
           },
         },
-        {
-          name: PageNames.SCRATCHPAD,
-          path: '/scratchpad',
-          handler: (toRoute, fromRoute) => {
-            actions.showScratchpad(store);
-          },
-        },
         {
           path: '/',
           redirect: '/classes',

kolibri/plugins/management/assets/src/app.js

@@ -6,7 +6,6 @@ const PageNames = {
   USER_MGMT_PAGE: 'USER_MGMT_PAGE',
   CONTENT_MGMT_PAGE: 'CONTENT_MGMT_PAGE',
   DATA_EXPORT_PAGE: 'DATA_EXPORT_PAGE',
-  SCRATCHPAD: 'SCRATCHPAD',
   FACILITY_CONFIG_PAGE: 'FACILITY_CONFIG_PAGE',
 };
 
@@ -17,7 +16,6 @@ const Modals = {
   EDIT_CLASS_NAME: 'EDIT_CLASS_NAME',
   REMOVE_USER: 'REMOVE_USER',
   CONFIRM_ENROLLMENT: 'CONFIRM_ENROLLMENT',
-
   CREATE_USER: 'CREATE_USER',
   EDIT_USER: 'EDIT_USER',
 };

kolibri/plugins/management/assets/src/constants.js

@@ -678,15 +678,6 @@ function showDataPage(store) {
   store.dispatch('SET_PAGE_STATE', {});
 }
 
-function showScratchpad(store) {
-  preparePage(store.dispatch, {
-    name: PageNames.DATA_EXPORT_PAGE,
-    title: _managePageTitle('Scratchpad'),
-    isAsync: false,
-  });
-  store.dispatch('SET_PAGE_STATE', {});
-}
-
 export {
   displayModal,
   createClass,
@@ -718,5 +709,4 @@ export {
   triggerRemoteContentImportTask,
   updateWizardLocalDriveList,
   showDataPage,
-  showScratchpad,
 };

kolibri/plugins/management/assets/src/state/actions.js

@@ -29,7 +29,6 @@
     [PageNames.CONTENT_MGMT_PAGE]: 'manage-content-page',
     [PageNames.DATA_EXPORT_PAGE]: 'data-page',
     [PageNames.FACILITY_CONFIG_PAGE]: 'facilities-config-page',
-    [PageNames.SCRATCHPAD]: 'scratchpad-page',
     [PageNames.USER_MGMT_PAGE]: 'user-page',
   };
   import authMessage from 'kolibri.coreVue.components.authMessage';
@@ -40,7 +39,6 @@
   import facilitiesConfigPage from './facilities-config-page';
   import manageClassPage from './manage-class-page';
   import manageContentPage from './manage-content-page';
-  import scratchpadPage from './scratchpad-page';
   import topNav from './top-nav';
   import userPage from './user-page';
   export default {
@@ -55,7 +53,6 @@
       facilitiesConfigPage,
       manageClassPage,
       manageContentPage,
-      scratchpadPage,
       topNav,
       userPage,
     },