Skip to content

Commit 84166cb

Browse files
Update checkbox and radio guidelines
1 parent cdbc096 commit 84166cb

File tree

4 files changed

+20
-60
lines changed

4 files changed

+20
-60
lines changed

kolibri/core/assets/src/views/k-checkbox/index.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
<script>
6161
6262
/**
63-
* A checkbox
63+
* Used for selection
6464
*/
6565
export default {
6666
name: 'k-checkbox',

kolibri/core/assets/src/views/k-radio/index.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
<script>
4848
4949
/**
50-
* A radio button
50+
* Used to display all options
5151
*/
5252
export default {
5353
name: 'k-radio',

kolibri/plugins/style_guide/assets/src/views/content/checkboxes/index.vue

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,16 @@
1111
<h2>Guidelines</h2>
1212
<h3>Usage</h3>
1313
<ul>
14-
<li>Should only be used in tables and lists</li>
15-
<li>Selected state of checkboxes should denote positives (yes/select/)</li>
16-
<li>Should not be used as filters in tables or lists</li>
14+
<li>Should only be used in tables, lists, and forms.</li>
15+
<li>Selected state of checkboxes should denote positives (yes/select)</li>
16+
<li>Should not be used to filter tables or lists</li>
1717
<li>Should not be nested</li>
18-
1918
</ul>
2019

2120
<h3>Style</h3>
2221
<ul>
23-
<li>Selected state is the action color</li>
24-
<li>Indeterminate state is medium grey</li>
25-
<li>Unselected state are dark grey</li>
26-
<li>Disabled state is </li>
2722
<li>Always left-aligned</li>
28-
<li>vertically stacked</li>
23+
<li>Vertically stacked</li>
2924
</ul>
3025

3126
<h3>Language</h3>

kolibri/plugins/style_guide/assets/src/views/content/radios/index.vue

Lines changed: 14 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -9,59 +9,24 @@
99
<vue-example :code="example" />
1010

1111
<h2>Guidelines</h2>
12-
<p>
13-
In particular, radio buttons aid the user when they need to see all
14-
available options side-by-side
15-
</p>
16-
<p>
17-
If it is not necessary to see all available options, a dropdown may be
18-
used
19-
</p>
20-
<p>
21-
Selected state of controls generally denote "positives"
22-
(yes/selected/etc.)
23-
</p>
24-
25-
<h3>Do not</h3>
12+
<h3>Usage</h3>
2613
<ul>
27-
<li>
28-
Use radio buttons as a filter in a table or a list
29-
</li>
30-
<li>
31-
Nest radio buttons
32-
</li>
14+
<li>Should be used when all options must be visible. If not, use a select.</li>
15+
<li>Selected state of radios should denote positives (yes/selected)</li>
16+
<li>Should not be used to filter tables or lists</li>
17+
<li>Should not be nested</li>
3318
</ul>
3419

3520
<h3>Style</h3>
36-
<p>
37-
Kolibri utilizes the default styles + padding from Keen UI
38-
</p>
39-
<p>
40-
Selected option is the action color, other available options are dark
41-
grey
42-
</p>
43-
<p>
44-
Where possible, avoid using icons with radio buttons. If necessary, the
45-
icon should sit within the label area, pushing the label to the right.
46-
</p>
47-
48-
<h3>Labels & option text:</h3>
49-
<p>
50-
Keep these short, concise, and easy for the user to understand. Should
51-
not be structured as a sentence.
52-
</p>
53-
54-
<h3>Layout</h3>
55-
<p>
56-
Radio buttons are always left-aligned
57-
</p>
58-
<p>
59-
No inset padding, radio buttons left-align with the content of their
60-
container
61-
</p>
62-
<p>
63-
Radio buttons are vertically stacked
64-
</p>ls should be short and concise. Should not be sentences.
21+
<ul>
22+
<li>Always left-aligned</li>
23+
<li>Vertically stacked</li>
24+
</ul>
25+
26+
<h3>Language</h3>
27+
<ul>
28+
<li>Labels should be short and concise. Should not be sentences.</li>
29+
</ul>
6530

6631
</page-template>
6732

0 commit comments

Comments
 (0)