Merge pull request #14359 from marcellamaki/0.19.2-into-develop

0.19.2 into develop

Author: rtibbles

.github/githubUtils.js

@@ -109,6 +109,15 @@ async function generateAssetComment(github, context) {
       text += `\n| ${readableName} | [${artifact.name}](${repoHtmlUrl}/suites/${checkSuiteNumber}/artifacts/${artifact.id.toString()}) |`
     }
   }
+
+  const screenshotArtifact = artifacts.find(
+    (artifact) => artifact.name === 'smoke_test_screenshot' && !artifact.expired
+  )
+  if (screenshotArtifact) {
+    const screenshotUrl = `${repoHtmlUrl}/suites/${checkSuiteNumber}/artifacts/${screenshotArtifact.id.toString()}`
+    text += `\n\n<details>\n<summary>Smoke test screenshot</summary>\n\n[Download screenshot](${screenshotUrl})\n\n</details>`
+  }
+
   return text
 }
 

.github/workflows/i18n-upload.yml

@@ -38,7 +38,7 @@ jobs:
         run: sudo apt-get update && sudo apt-get install -y gettext
 
       - name: Install Python dependencies
-        run: pip install -r requirements/base.txt
+        run: pip install . -r requirements/base.txt
 
       - name: Install JavaScript dependencies
         run: pnpm install --frozen-lockfile

.github/workflows/pr_build_kolibri.yml

@@ -55,17 +55,51 @@ jobs:
   apk:
     name: Build APK file
     needs: whl
-    uses: learningequality/kolibri-installer-android/.github/workflows/build_apk.yml@v0.1.6
+    uses: learningequality/kolibri-installer-android/.github/workflows/build_apk.yml@v0.1.7
     with:
       tar-file-name: ${{ needs.whl.outputs.tar-file-name }}
-      ref: v0.1.6
+      ref: v0.1.7
   zip:
     name: Build Raspberry Pi Image
     needs: deb
     uses: learningequality/kolibri-image-pi/.github/workflows/build_img.yml@v1.0.0
     with:
       deb-file-name: ${{ needs.deb.outputs.deb-file-name }}
       ref: v1.0.0
+  browser_smoke_test:
+    name: Browser smoke test
+    needs: whl
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - uses: actions/checkout@v6
+      - name: Install Python
+        uses: actions/setup-python@v6
+        with:
+          python-version: '3.12'
+      - uses: actions/download-artifact@v7
+        with:
+          name: ${{ needs.whl.outputs.whl-file-name }}
+          path: dist
+      - name: Install WHL file
+        run: pip install dist/${{ needs.whl.outputs.whl-file-name }}
+      - name: Install Playwright
+        run: |
+          pip install "playwright<2"
+          playwright install --with-deps chromium
+      - name: Run browser smoke test
+        env:
+          KOLIBRI_HOME: ${{ runner.temp }}/kolibri_home
+          SCREENSHOT_PATH: ${{ runner.temp }}/smoke_test_screenshot.png
+        working-directory: ${{ runner.temp }}
+        run: python ${{ github.workspace }}/integration_testing/smoke_test.py
+      - name: Upload screenshot
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: smoke_test_screenshot
+          path: ${{ runner.temp }}/smoke_test_screenshot.png
+          if-no-files-found: ignore
   test_whl_file:
     name: Test WHL file
     needs: whl

.github/workflows/release_kolibri.yml

@@ -119,11 +119,11 @@ jobs:
   apk:
     name: Build Android APK
     needs: whl
-    uses: learningequality/kolibri-installer-android/.github/workflows/build_apk.yml@v0.1.6
+    uses: learningequality/kolibri-installer-android/.github/workflows/build_apk.yml@v0.1.7
     with:
       tar-file-name: ${{ needs.whl.outputs.tar-file-name }}
       release: true
-      ref: v0.1.6
+      ref: v0.1.7
     secrets:
       KOLIBRI_ANDROID_APP_PRODUCTION_KEYSTORE: ${{ secrets.KOLIBRI_ANDROID_APP_PRODUCTION_KEYSTORE }}
       KOLIBRI_ANDROID_APP_PRODUCTION_KEYSTORE_PASSWORD: ${{ secrets.KOLIBRI_ANDROID_APP_PRODUCTION_KEYSTORE_PASSWORD }}
@@ -248,9 +248,9 @@ jobs:
     name: Release Android App
     if: ${{ !github.event.release.prerelease }}
     needs: [apk, block_release_step]
-    uses: learningequality/kolibri-installer-android/.github/workflows/release_apk.yml@v0.1.6
+    uses: learningequality/kolibri-installer-android/.github/workflows/release_apk.yml@v0.1.7
     with:
       version-code: ${{ needs.apk.outputs.version-code }}
-      ref: v0.1.6
+      ref: v0.1.7
     secrets:
       KOLIBRI_ANDROID_PLAY_STORE_API_SERVICE_ACCOUNT_JSON: ${{ secrets.KOLIBRI_ANDROID_PLAY_STORE_API_SERVICE_ACCOUNT_JSON }}

AGENTS.md

@@ -136,9 +136,12 @@ pytest kolibri/path/to/test/                          # Python (directory)
 pytest kolibri/core/auth/test/ -k test_login          # Python (filter by name)
 pnpm run test-jest -- path/to/file.spec.js            # Frontend (single file)
 pnpm run test-jest -- --testPathPattern learn          # Frontend (filter by pattern)
-pre-commit run --all-files                            # Lint
+pre-commit run --all-files                            # Lint (all files)
+pre-commit run --files path/to/File.vue               # Lint (specific file)
 ```
 
+Always use `pre-commit` as the single entry point for linting — do not invoke ESLint or other linters directly.
+
 ## Docs Reference
 
 Testing: `docs/testing.rst`, `docs/frontend_architecture/unit_testing.rst`, `docs/backend_architecture/testing.rst` | Frontend arch: `docs/frontend_architecture/` | Backend arch: `docs/backend_architecture/` | i18n: `docs/i18n.rst` | Code quality: `docs/code_quality.rst` | How-tos: `docs/howtos/` | Workflow: `docs/development_workflow.rst` | Multi-agent setup: `docs/howtos/multi_agent_setup.md` | User docs: https://kolibri.readthedocs.io/

CHANGELOG.md

@@ -3,6 +3,88 @@
 List of the most important changes for each release.
 
 
+## 0.19.2
+
+### High level overview
+
+This release makes some upgrades to the developer experience, fixes various bugs, and includes foundational work for the upcoming courses feature, including API endpoints and frontend architecture for course listing and course session management. We also continued to make progress on cleaning up Python 2.7 compatibility code.
+
+### Added
+
+####  Courses Features (Foundational)
+  - Courses frontend setup by @AlexVelezLl in https://github.com/learningequality/kolibri/pull/14077
+  - Create courses models and viewset by @AlexVelezLl in https://github.com/learningequality/kolibri/pull/14091
+  - Add select courses and recipients subpages by @AlexVelezLl in https://github.com/learningequality/kolibri/pull/14103
+  - Add Course Session Context to Progress Tracking by @LianaHarris360 in https://github.com/learningequality/kolibri/pull/14116
+  - Learn Course Assignments API Endpoints by @LianaHarris360 in https://github.com/learningequality/kolibri/pull/14113
+  - Add UnitTestAssignment model for managing pre/post tests in course units by @AllanOXDi in https://github.com/learningequality/kolibri/pull/14115
+  - Implement Course list data loading and display by @AllanOXDi in https://github.com/learningequality/kolibri/pull/14114
+  - ResourceLayout component architecture for course content display by @rtibbles in https://github.com/learningequality/kolibri/pull/14109
+  - Add API endpoints for activating/closing quizzes & returning active quiz by @AllanOXDi in https://github.com/learningequality/kolibri/pull/14121
+  - Course Preview by @nucleogenesis in https://github.com/learningequality/kolibri/pull/14117
+  - Add course unit view by @AlexVelezLl in https://github.com/learningequality/kolibri/pull/14128
+  - Course unit view 2 by @AlexVelezLl in https://github.com/learningequality/kolibri/pull/14145
+  - Course welcome view by @LianaHarris360 in https://github.com/learningequality/kolibri/pull/14146
+  - Course cards homepage by @marcellamaki in https://github.com/learningequality/kolibri/pull/14122
+  - Pre/Post-Tests Activation UI by @nucleogenesis in https://github.com/learningequality/kolibri/pull/14147
+  - Add confirmation modal to prevent accidental closure of Course Assignment Side Panel by @LianaHarris360 in https://github.com/learningequality/kolibri/pull/14150
+
+####  Sync & Backend
+  - Add sync operations and filter utilities for classroom partitioning by @bjester in https://github.com/learningequality/kolibri/pull/14070
+  - Implement new deserialization logic according to sync_filter by @ozer550 in https://github.com/learningequality/kolibri/pull/14148
+
+####  Developer Tooling
+  - Add AI agent documentation and multi-agent isolation support by @rtibbles in https://github.com/learningequality/kolibri/pull/14144
+  - Add documentation indicating that APIs are internal by @rtibbles in https://github.com/learningequality/kolibri/pull/14090
+  - Add ESLint rule to prevent RTL-breaking inline styles by @rtibbles in https://github.com/learningequality/kolibri/pull/14093
+  - Add linting to prevent non-scoped lodash/dateFn imports by @rtibbles in https://github.com/learningequality/kolibri/pull/14125
+  - Add browser smoke test to PR build workflow by @rtibbles in https://github.com/learningequality/kolibri/pull/14153
+  - Add hashing to font CSS and WOFF generation by @rtibbles in https://github.com/learningequality/kolibri/pull/14088
+
+###  Developer-facing improvements
+
+####  Build & Infrastructure
+  - Migrate from yarn to pnpm by @rtibbles in https://github.com/learningequality/kolibri/pull/14086
+  - Restore frontend linting and fix issues that happened in the interim by @rtibbles in https://github.com/learningequality/kolibri/pull/14126
+  - Prevent traversal of symlinks in node_modules during egg info generation by @rtibbles in https://github.com/learningequality/kolibri/pull/14127
+  - Migrate from tibdex/github-app-token to actions/create-github-app-token by @rtibblesbot in https://github.com/learningequality/kolibri/pull/14206
+  - Update ignores for worktrees and JetBrains features by @bjester in https://github.com/learningequality/kolibri/pull/14162
+  - Slim down agents.md with progressive disclosure and moving more into Claude.md by @rtibbles in https://github.com/learningequality/kolibri/pull/14164
+  - Install kolibri in i18n-upload workflow by @rtibbles in https://github.com/learningequality/kolibri/pull/14239
+  - Fix invocations of i18n commands and ignores by @rtibbles in https://github.com/learningequality/kolibri/pull/14247
+
+####  Tech debt / refactors
+  - Replace CSS Variables in favor of theme variable for css styling by @AllanOXDi in https://github.com/learningequality/kolibri/pull/14089
+  - Removes residue style overrides prop code by @akolson in https://github.com/learningequality/kolibri/pull/14112
+  - Remove no longer needed overflow: unset by @AlexVelezLl in https://github.com/learningequality/kolibri/pull/14202
+  - Clean up localeCompare usage for proper internationalization (fixes #3888) by @rtibbles in https://github.com/learningequality/kolibri/pull/14087
+  - Update kolibri-zip with support for css import statements, fix browser compatibility by @rtibbles in https://github.com/learningequality/kolibri/pull/14085
+
+####  Python 2.7 Cleanup
+  - Remove unnecessary UTF-8 coding declarations from Python files by @manocormen in https://github.com/learningequality/kolibri/pull/14215
+  - Remove explicit object base class from Python classes by @manocormen in https://github.com/learningequality/kolibri/pull/14224
+  - Clean up outdated Python 2.7 comments and unicode string literals by @curiouscoder-cmd in https://github.com/learningequality/kolibri/pull/14227
+  - Remove Python 2 compatibility shims by @sharma-anushka in https://github.com/learningequality/kolibri/pull/14226
+
+####  Translations
+  - Update translations from Crowdin for release-v0.19.x by @learning-equality-bot[bot] in https://github.com/learningequality/kolibri/pull/14249
+
+### Fixed
+  - Better handle unclean server shutdown by @rtibbles in https://github.com/learningequality/kolibri/pull/14123
+  - Fix missing dep in Coach by @nucleogenesis in https://github.com/learningequality/kolibri/pull/14098
+  - Fix flaky Python tests: ordering, network mocking, and missing request mocks by @rtibblesbot in https://github.com/learningequality/kolibri/pull/14177
+  - Fixes notification for no resources on the device being shown when no exercises exist by @akolson in https://github.com/learningequality/kolibri/pull/14288
+  - "Resume" card display and progress fixes by @marcellamaki in https://github.com/learningequality/kolibri/pull/14289
+  - Resume pagination fixes by @rtibbles in https://github.com/learningequality/kolibri/pull/14313
+  - Better missing resources handling by @akolson in https://github.com/learningequality/kolibri/pull/14201
+  - Unprovisioned URL Redirect (+ remove dead code) by @nucleogenesis in https://github.com/learningequality/kolibri/pull/14200
+  - Prevent double scrollbar in side panel modal by @AllanOXDi in https://github.com/learningequality/kolibri/pull/14228
+  - Reset selection after applying filter by @AllanOXDi in https://github.com/learningequality/kolibri/pull/13880
+  - Retry peeruserimport task on Database or connection errors by @AlexVelezLl in https://github.com/learningequality/kolibri/pull/13821
+  - Fix The 'Recipients' drop-down to show groups list by @AllanOXDi in https://github.com/learningequality/kolibri/pull/14156
+  - Fixes TypeError on clicking 'Select recipients' from the course details page by @AllanOXDi in https://github.com/learningequality/kolibri/pull/14160
+
+
 ## 0.19.1
 
 ### High level overview

Makefile

@@ -225,17 +225,17 @@ i18n-django-compilemessages:
 	cd kolibri && PYTHONPATH="..:$$PYTHONPATH" python -m kolibri manage compilemessages --skip-update
 
 i18n-upload: i18n-extract
-	pnpm exec crowdin upload sources -- --branch ${CROWDIN_BRANCH}
+	pnpm exec crowdin upload sources --branch ${CROWDIN_BRANCH}
 
 i18n-pretranslate:
-	pnpm exec crowdin pre-translate -- --branch ${CROWDIN_BRANCH} --translate-untranslated-only --method=tm
+	pnpm exec crowdin pre-translate --branch ${CROWDIN_BRANCH} --translate-untranslated-only --method=tm
 
 i18n-pretranslate-approve-all:
-	pnpm exec crowdin pre-translate -- --branch ${CROWDIN_BRANCH} --translate-untranslated-only --method=tm --auto-approve-option=all
+	pnpm exec crowdin pre-translate --branch ${CROWDIN_BRANCH} --translate-untranslated-only --method=tm --auto-approve-option=all
 
 i18n-download-translations: i18n-extract-frontend
 	touch kolibri/locale/.crowdin-download-marker
-	pnpm exec crowdin download -- --branch ${CROWDIN_BRANCH}
+	pnpm exec crowdin download --branch ${CROWDIN_BRANCH}
 	@if [ -z "$$(find kolibri/locale/*/LC_MESSAGES -type f \( -name '*.po' -o -name '*.csv' \) -newer kolibri/locale/.crowdin-download-marker 2>/dev/null)" ]; then \
 		echo "❌ ERROR: No translation files were downloaded - Crowdin download may have failed silently"; \
 		echo "Check the output above for errors during the download process"; \
@@ -245,16 +245,15 @@ i18n-download-translations: i18n-extract-frontend
 	@echo "✅ Translation files downloaded successfully"
 	rm -f kolibri/locale/.crowdin-download-marker
 	python build_tools/i18n/cleanup_unsupported_languages.py
-	pnpm exec kolibri-tools i18n-code-gen -- --output-dir ./packages/kolibri/utils/internal
+	pnpm exec kolibri-i18n code-gen --output-dir ./packages/kolibri/utils/internal
 	$(MAKE) i18n-django-compilemessages
-	pnpm exec kolibri-tools i18n-create-message-files -- --pluginFile ./build_tools/build_plugins.txt
+	pnpm exec kolibri-i18n create-message-files --pluginFile ./build_tools/build_plugins.txt --ignore '**/node_modules/!(kolibri-common)/**','**/static/**'
 
 i18n-download-source-fonts:
 	python build_tools/i18n/fonts.py download-source-fonts
 
 i18n-regenerate-fonts:
-	python build_tools/i18n/fonts.py generate-full-fonts
-	python build_tools/i18n/fonts.py generate-subset-fonts
+	python build_tools/i18n/fonts.py generate-fonts
 
 i18n-download: i18n-download-translations i18n-regenerate-fonts
 

build_tools/i18n/cleanup_unsupported_languages.py

@@ -1,5 +1,4 @@
 #!/usr/bin/env python
-# -*- coding: utf-8 -*-
 """
 Remove locale directories for languages not in language_info.json.