-
Notifications
You must be signed in to change notification settings - Fork 921
Labels
APP: FacilityRe: Facility App (user/class management, facility settings, csv import/export, etc.)Re: Facility App (user/class management, facility settings, csv import/export, etc.)DEV: frontendP3 - lowPriority: Stretch goalPriority: Stretch goalTAG: tech update / debtChange not visible to userChange not visible to usercommunity-contribution-in-progressgood first issueSelf-contained, straightforward, low-complexitySelf-contained, straightforward, low-complexityhelp wantedOpen source contributors welcomeOpen source contributors welcome
Description
🙂 Looking for an issue? Welcome! This issue is open for contribution. If this is the first time you’re requesting an issue, please:
- Read Contributing guidelines carefully. Pay extra attention to Using generative AI. Pull requests and comments that don’t follow the guidelines won’t be answered.
- Confirm that you’ve read the guidelines in your comment.
Overview
Complexity: Low
Context
The test suites for facility management components (facility-app-bar-page.spec.js, facility-config-page.spec.js, UsersRootPage.spec.js) currently use @vue/test-utils, which couples tests to component internals.
Related pages:
The Change
Refactor these test files to use Vue Testing Library (VTL) and write tests that reflect how a user interacts with facility management:
kolibri/plugins/facility/frontend/views/__tests__/facility-app-bar-page.spec.jskolibri/plugins/facility/frontend/views/__tests__/facility-config-page.spec.jskolibri/plugins/facility/frontend/views/users/UsersRootPage/__tests__/UsersRootPage.spec.js
Do not refactor any other test files or areas of the codebase.
How to Get There
- Sign in to Kolibri as an admin
- Go to Facility — the app bar with tab navigation (Classes, Users, Settings, Data) is rendered by the app bar page component
- Go to Facility > Settings to see the facility config page with facility settings checkboxes
- Go to Facility > Users to see UsersRootPage with user list, search, and filter
Acceptance Criteria
-
facility-app-bar-page.spec.js,facility-config-page.spec.js, andUsersRootPage.spec.jsmigrated to use@testing-library/vue - No residual
@vue/test-utilsimports in migrated files - Cover all major workflows while avoiding excessive testing of details
- Concise but explicit test descriptions that describe what's tested from a user point of view
- Follow Testing Library principles and Testing Library query priority recommendation
- Use patterns consistent with existing VTL test suites (search for
from '@testing-library/vue') - All migrated tests pass:
pnpm run test-jest -- --testPathPattern facility
References
- Reference VTL test:
packages/kolibri-common/components/userAccounts/__tests__/GenderSelect.spec.js - Testing Library query priority
🤖 This issue was written with AI assistance, under supervision, review and final edits by @rtibbles 🤖
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
APP: FacilityRe: Facility App (user/class management, facility settings, csv import/export, etc.)Re: Facility App (user/class management, facility settings, csv import/export, etc.)DEV: frontendP3 - lowPriority: Stretch goalPriority: Stretch goalTAG: tech update / debtChange not visible to userChange not visible to usercommunity-contribution-in-progressgood first issueSelf-contained, straightforward, low-complexitySelf-contained, straightforward, low-complexityhelp wantedOpen source contributors welcomeOpen source contributors welcome


