Prevent inconsistent states beteween public channels and community ch… (#5500)

* Prevent inconsistent states beteween public channels and community channels

* [pre-commit.ci lite] apply automatic fixes

* fix linting

* fix linting

* fixing code according to comments

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Author: taoerman

contentcuration/contentcuration/frontend/administration/components/ConfirmationDialog.vue

@@ -5,6 +5,12 @@
     :header="title"
     :text="text"
   >
+    <div
+      v-if="errorText"
+      class="error-text lighten-4 ma-3 pa-2 red red--text"
+    >
+      {{ errorText }}
+    </div>
     <template #buttons="{ close }">
       <VBtn
         flat
@@ -17,6 +23,7 @@
         color="primary"
         dark
         data-test="confirm"
+        :disabled="disableSubmit"
         @click="$emit('confirm')"
       >
         {{ confirmButtonText }}
@@ -55,6 +62,14 @@
         type: String,
         default: 'Cancel',
       },
+      errorText: {
+        type: String,
+        default: '',
+      },
+      disableSubmit: {
+        type: Boolean,
+        default: false,
+      },
     },
     computed: {
       show: {

contentcuration/contentcuration/frontend/administration/pages/Channels/ChannelActionsDropdown.vue

@@ -14,6 +14,8 @@
       v-model="makePublicDialog"
       title="Make channel public"
       :text="`All users will be able to view and import content from ${name}.`"
+      :error-text="communityChannelErrorMessage"
+      :disable-submit="isCommunityChannel"
       data-test="confirm-public"
       confirmButtonText="Make public"
       @confirm="makePublicHandler"
@@ -124,6 +126,7 @@
   import ConfirmationDialog from '../../components/ConfirmationDialog';
   import { RouteNames } from '../../constants';
   import { channelExportMixin } from 'shared/views/channel/mixins';
+  import { CommunityLibraryStatus } from 'shared/constants';
 
   export default {
     name: 'ChannelActionsDropdown',
@@ -160,6 +163,16 @@
           },
         };
       },
+      isCommunityChannel() {
+        const status = this.channel.latest_community_library_submission_status;
+        return status === CommunityLibraryStatus.APPROVED || status === CommunityLibraryStatus.LIVE;
+      },
+      communityChannelErrorMessage() {
+        if (this.isCommunityChannel) {
+          return 'This channel has been added to the Community Library and cannot be marked public.';
+        }
+        return '';
+      },
     },
     methods: {
       ...mapActions('channelAdmin', [

contentcuration/contentcuration/models.py

@@ -1268,6 +1268,22 @@ def make_public(self, bypass_signals=False):
 
         return self
 
+    def is_community_channel(self):
+        return self.community_library_submissions.filter(
+            status__in=[
+                community_library_submission.STATUS_APPROVED,
+                community_library_submission.STATUS_LIVE,
+            ]
+        ).exists()
+
+    def clean(self):
+        super().clean()
+        if self.public and self.is_community_channel():
+            raise ValidationError(
+                "This channel has been added to the Community Library and cannot be marked public.",
+                code="public_community_conflict",
+            )
+
     def mark_publishing(self, user):
         self.history.create(actor_id=to_pk(user), action=channel_history.PUBLICATION)
         self.main_tree.publishing = True
@@ -2626,6 +2642,12 @@ def save(self, *args, **kwargs):
                 code="impossibly_high_channel_version",
             )
 
+        if self.channel.public:
+            raise ValidationError(
+                "Cannot create a community library submission for a public channel.",
+                code="public_channel_submission",
+            )
+
         if self.pk is None:
             # When creating a new submission, ensure the channel has a versioned database
             # (it might not have if the channel was published before versioned databases

contentcuration/contentcuration/viewsets/channel.py

@@ -1111,6 +1111,15 @@ class Meta:
         list_serializer_class = BulkListSerializer
         nested_writes = True
 
+    def validate_public(self, value):
+        if value and hasattr(self, "instance") and self.instance:
+            if self.instance.is_community_channel():
+                raise ValidationError(
+                    "This channel has been added to the Community Library and cannot be marked public.",
+                    code="public_community_conflict",
+                )
+        return value
+
 
 class AdminChannelViewSet(ChannelViewSet, RESTUpdateModelMixin, RESTDestroyModelMixin):
     pagination_class = CatalogListPagination

contentcuration/contentcuration/viewsets/community_library_submission.py

@@ -121,6 +121,16 @@ def update(self, instance, validated_data):
                 "Cannot resolve a community library submission that is not pending."
             )
 
+        if (
+            "status" in validated_data
+            and validated_data["status"]
+            == community_library_submission_constants.STATUS_APPROVED
+            and instance.channel.public
+        ):
+            raise ValidationError(
+                "Cannot approve a community library submission for a channel that has been marked public."
+            )
+
         if "status" not in validated_data or validated_data["status"] not in [
             community_library_submission_constants.STATUS_APPROVED,
             community_library_submission_constants.STATUS_REJECTED,