Run phpcbf on whole codebase

Author: dlmsr

cal_lib.php

@@ -16,6 +16,7 @@
 
 /**
  * Functions for creating hislsf calendar instances
+ * @package local_lsf_unification
  */
 if (!defined('MOODLE_INTERNAL')) {
     die('Direct access to this script is forbidden.');    // It must be included from a Moodle page
@@ -29,6 +30,7 @@
 /**
  * Returns the CURRENT (because of the event ids instead of the user id being appended this URL changes when users subscribe to new events) userspecific ICal-URL
  * @param unknown_type $userid
+ * @package local_lsf_unification
  */
 function his_get_ical_url($userid) {
     global $DB, $CFG;
@@ -41,6 +43,7 @@ function his_get_ical_url($userid) {
 /**
  * returns a default hislsf calendar instance
  * @return stdClass
+ * @package local_lsf_unification
  */
 function create_default_his_subscription() {
     global $CFG;
@@ -54,6 +57,7 @@ function create_default_his_subscription() {
 
 /**
  * Checks if a hislsf calendar instance already exists for the current user. If it doesn't find one, then it tries to create a new one.
+ * @package local_lsf_unification
  */
 function his_add_cal() {
     global $PAGE;
@@ -74,6 +78,7 @@ function his_add_cal() {
 /**
  * Returns if a hislsf calendar instance already exists for the current user
  * @return boolean
+ * @package local_lsf_unification
  */
 function his_already_imported_cal() {
     global $USER, $DB;
@@ -83,6 +88,7 @@ function his_already_imported_cal() {
 /**
  * Adds a link to "cal_import.php" to the form
  * @param $mform
+ * @package local_lsf_unification
  */
 function his_print_cal_import_form($mform) {
     global $PAGE, $CFG;

duplicate_course.php

@@ -46,8 +46,8 @@
 
 $courseid   = required_param('courseid', PARAM_INT);
 $acceptorid = get_course_acceptor($courseid);
-$files_backups = get_backup_files($acceptorid);
-$files_templates = get_template_files();
+$filesbackups = get_backup_files($acceptorid);
+$filestemplates = get_template_files();
 $filetype   = optional_param('filetype', null, PARAM_RAW);
 $fileid     = optional_param('fileid', null, PARAM_RAW);
 $fileinfo   = null;
@@ -67,15 +67,15 @@
         }
         // restore backup
         if ($filetype == "t" && get_config('local_lsf_unification', 'restore_templates')) {
-            if (empty($files_templates[$fileid])) {
+            if (empty($filestemplates[$fileid])) {
                 die("error #0");
             }
-            $fileinfo = $files_templates[$fileid];
+            $fileinfo = $filestemplates[$fileid];
         } else if ($filetype == "b" && get_config('local_lsf_unification', 'restore_old_courses')) {
-            if (empty($files_backups[$fileid])) {
+            if (empty($filesbackups[$fileid])) {
                 die("error #0");
             }
-            $fileinfo = $files_backups[$fileid];
+            $fileinfo = $filesbackups[$fileid];
         } else {
             die("error #x");
         }

hup_stats.php

@@ -24,15 +24,15 @@
     die("no access");
 }
 
-$reqSem         = optional_param('semester', null, PARAM_INT);       // his category origin id
+$reqsem         = optional_param('semester', null, PARAM_INT);       // his category origin id
 
 set_time_limit(30 * 60);
 
 
 function create_aggregate() {
-    global $pgDB;
-    pg_query($pgDB->connection, "DROP AGGREGATE IF EXISTS textcat_all(text);");
-    pg_query($pgDB->connection, "CREATE AGGREGATE textcat_all(
+    global $pgdb;
+    pg_query($pgdb->connection, "DROP AGGREGATE IF EXISTS textcat_all(text);");
+    pg_query($pgdb->connection, "CREATE AGGREGATE textcat_all(
             basetype    = text,
             sfunc       = textcat,
             stype       = text,
@@ -41,69 +41,69 @@ function create_aggregate() {
 }
 
 function get_cat_sem($ueid) {
-    global $pgDB, $hup_stats_sem_table;
+    global $pgdb, $hupstatssemtable;
     // read or (if not existing) create array
-    if (!isset($hup_stats_sem_table)) {
-        $hup_stats_sem_table = [];
-        $q_main = pg_query($pgDB->connection, "SELECT ueid, semester FROM " . HIS_UEBERSCHRIFT);
-        while ($hislsf_title = pg_fetch_object($q_main)) {
-            $hup_stats_sem_table[$hislsf_title->ueid] = $hislsf_title->semester;
+    if (!isset($hupstatssemtable)) {
+        $hupstatssemtable = [];
+        $qmain = pg_query($pgdb->connection, "SELECT ueid, semester FROM " . HIS_UEBERSCHRIFT);
+        while ($hislsftitle = pg_fetch_object($qmain)) {
+            $hupstatssemtable[$hislsftitle->ueid] = $hislsftitle->semester;
         }
     }
-    return isset($hup_stats_sem_table[$ueid]) ? $hup_stats_sem_table[$ueid] : null;
+    return isset($hupstatssemtable[$ueid]) ? $hupstatssemtable[$ueid] : null;
 }
 
 function get_cat_veranstids_and_count($ueids) {
-    global $pgDB;
-    $hup_stats_veranstcount_table = [];
+    global $pgdb;
+    $hupstatsveranstcounttable = [];
     if (!empty($ueids)) {
-        $q_main = pg_query($pgDB->connection, "SELECT veranstaltungsart, textcat_all(DISTINCT " . HIS_UEBERSCHRIFT . ".veranstid || ',') as veranstids, COUNT(DISTINCT " . HIS_UEBERSCHRIFT . ".veranstid) as c FROM " . HIS_UEBERSCHRIFT . " JOIN " . HIS_VERANSTALTUNG . " on " . HIS_UEBERSCHRIFT . ".veranstid = " . HIS_VERANSTALTUNG . ".veranstid WHERE ueid IN (" . $ueids . ") GROUP BY veranstaltungsart");
-        while ($hislsf_title = pg_fetch_object($q_main)) {
-            $hup_stats_veranstcount_table[$hislsf_title->veranstaltungsart] = ["veranstids" => explode(",", $hislsf_title->veranstids), "count" => $hislsf_title->c];
+        $qmain = pg_query($pgdb->connection, "SELECT veranstaltungsart, textcat_all(DISTINCT " . HIS_UEBERSCHRIFT . ".veranstid || ',') as veranstids, COUNT(DISTINCT " . HIS_UEBERSCHRIFT . ".veranstid) as c FROM " . HIS_UEBERSCHRIFT . " JOIN " . HIS_VERANSTALTUNG . " on " . HIS_UEBERSCHRIFT . ".veranstid = " . HIS_VERANSTALTUNG . ".veranstid WHERE ueid IN (" . $ueids . ") GROUP BY veranstaltungsart");
+        while ($hislsftitle = pg_fetch_object($qmain)) {
+            $hupstatsveranstcounttable[$hislsftitle->veranstaltungsart] = ["veranstids" => explode(",", $hislsftitle->veranstids), "count" => $hislsftitle->c];
         }
     }
-    return $hup_stats_veranstcount_table;
+    return $hupstatsveranstcounttable;
 }
 
 
-$pgDB = new pg_lite();
-echo "<p>Verbindung: " . ($pgDB->connect() ? "ja" : "nein") . " (" . $pgDB->connection . ")</p>";
+$pgdb = new pg_lite();
+echo "<p>Verbindung: " . ($pgdb->connect() ? "ja" : "nein") . " (" . $pgdb->connection . ")</p>";
 create_aggregate();
 
 echo "<p><pre>";
 // Root-Knoten herausfinden
-$toplevel_origins = get_his_toplevel_originids();
+$toplevelorigins = get_his_toplevel_originids();
 // echo "TOPLEVEL_IDs = ".print_r($toplevel_origins,true)."\n\n";
 // Kategorien herausfinden
-$secondlevel_orinins = get_newest_sublevels(implode(", ", $toplevel_origins));
-foreach ($secondlevel_orinins as $secondndlevel) {
+$secondlevelorinins = get_newest_sublevels(implode(", ", $toplevelorigins));
+foreach ($secondlevelorinins as $secondndlevel) {
     // Kategoriekopien herausfinden
     $secondndlevel->txt = mb_convert_encoding($secondndlevel->txt, 'UTF-8', 'ISO-8859-1');
     $secondndlevel->copies = $DB->get_records("local_lsf_category", ["origin" => $secondndlevel->origin], null, "ueid");
-    foreach ($secondndlevel->copies as $secondlevel_copy) {
+    foreach ($secondndlevel->copies as $secondlevelcopy) {
         // Semester bestimmen
-        $secondlevel_copy->semester = get_cat_sem($secondlevel_copy->ueid);
-        if (empty($reqSem) || ($reqSem == $secondlevel_copy->semester)) {
+        $secondlevelcopy->semester = get_cat_sem($secondlevelcopy->ueid);
+        if (empty($reqsem) || ($reqsem == $secondlevelcopy->semester)) {
             // Alle Unterkategorien der jeweiligen Kategoriekopien sammeln
-            $secondlevel_copy->subs = array_keys($DB->get_records("local_lsf_categoryparenthood", ["parent" => $secondlevel_copy->ueid], null, "child"));
+            $secondlevelcopy->subs = array_keys($DB->get_records("local_lsf_categoryparenthood", ["parent" => $secondlevelcopy->ueid], null, "child"));
             // Bestimme die Veranstatlungstypen und Anazahlen der jeweiligen Kategoriekopien
-            $secondlevel_copy->veranstcount = get_cat_veranstids_and_count(implode(",", $secondlevel_copy->subs));
+            $secondlevelcopy->veranstcount = get_cat_veranstids_and_count(implode(",", $secondlevelcopy->subs));
             // Semesterarray erstellen (daten umformatieren)
-            if (!isset($sem_stats[$secondlevel_copy->semester])) {
-                $sem_stats[$secondlevel_copy->semester] = [];
+            if (!isset($semstats[$secondlevelcopy->semester])) {
+                $semstats[$secondlevelcopy->semester] = [];
             }
-            if (!isset($sem_stats[$secondlevel_copy->semester][$secondndlevel->txt])) {
-                $sem_stats[$secondlevel_copy->semester][$secondndlevel->txt] = [];
+            if (!isset($semstats[$secondlevelcopy->semester][$secondndlevel->txt])) {
+                $semstats[$secondlevelcopy->semester][$secondndlevel->txt] = [];
             }
-            foreach ($secondlevel_copy->veranstcount as $typ => $veranstids_and_count) {
-                if (!isset($sem_stats[$secondlevel_copy->semester][$secondndlevel->txt][$typ])) {
-                    $sem_stats[$secondlevel_copy->semester][$secondndlevel->txt][$typ] = ["imported" => 0, "existing" => 0, "veranstids" => []];
+            foreach ($secondlevelcopy->veranstcount as $typ => $veranstidsandcount) {
+                if (!isset($semstats[$secondlevelcopy->semester][$secondndlevel->txt][$typ])) {
+                    $semstats[$secondlevelcopy->semester][$secondndlevel->txt][$typ] = ["imported" => 0, "existing" => 0, "veranstids" => []];
                 }
-                $sem_stats[$secondlevel_copy->semester][$secondndlevel->txt][$typ]["veranstids"] = array_filter(array_merge($sem_stats[$secondlevel_copy->semester][$secondndlevel->txt][$typ]["veranstids"], $veranstids_and_count["veranstids"]));
-                $sem_stats[$secondlevel_copy->semester][$secondndlevel->txt][$typ]["existing"] += $veranstids_and_count["count"];
+                $semstats[$secondlevelcopy->semester][$secondndlevel->txt][$typ]["veranstids"] = array_filter(array_merge($semstats[$secondlevelcopy->semester][$secondndlevel->txt][$typ]["veranstids"], $veranstidsandcount["veranstids"]));
+                $semstats[$secondlevelcopy->semester][$secondndlevel->txt][$typ]["existing"] += $veranstidsandcount["count"];
                 // zaehle bestehende kurse
-                foreach ($sem_stats[$secondlevel_copy->semester][$secondndlevel->txt][$typ]["veranstids"] as $veranstid) {
-                    $sem_stats[$secondlevel_copy->semester][$secondndlevel->txt][$typ]["imported"] += $DB->record_exists("course", ["idnumber" => $veranstid]) ? 1 : 0;
+                foreach ($semstats[$secondlevelcopy->semester][$secondndlevel->txt][$typ]["veranstids"] as $veranstid) {
+                    $semstats[$secondlevelcopy->semester][$secondndlevel->txt][$typ]["imported"] += $DB->record_exists("course", ["idnumber" => $veranstid]) ? 1 : 0;
                 }
             }
         }
@@ -114,7 +114,7 @@ function get_cat_veranstids_and_count($ueids) {
 
 // write CSV
 echo "Semester;Kategorie;Typ;AnzahlGesamt;AnzahlImportiert\n";
-foreach ($sem_stats as $sem => $stats) {
+foreach ($semstats as $sem => $stats) {
     foreach ($stats as $cat => $catstats) {
         if (!empty($catstats)) {
             foreach ($catstats as $typ => $count) {
@@ -127,5 +127,5 @@ function get_cat_veranstids_and_count($ueids) {
 
 echo "</pre></p>";
 
-$pgDB->dispose();
-echo "<p>Verbindung geschlossen: " . (($pgDB->connection == null) ? "ja" : "nein") . "</p>";
+$pgdb->dispose();
+echo "<p>Verbindung geschlossen: " . (($pgdb->connection == null) ? "ja" : "nein") . "</p>";

lib.php

@@ -16,6 +16,7 @@
 
 /**
  * Functions that aid core functionality
+ * @package local_lsf_unification
  */
 defined('MOODLE_INTERNAL') || die();
 
@@ -28,6 +29,7 @@
  *
  * @param $courseid
  * @return $externid | -1
+ * @package local_lsf_unification
  */
 function get_course_by_idnumber($courseid, $silent = false) {
     global $DB;
@@ -45,16 +47,17 @@ function get_course_by_idnumber($courseid, $silent = false) {
  *
  * @param $title
  * @return $parent_title | null
+ * @package local_lsf_unification
  */
-function find_or_create_category($title, $parent_title) {
+function find_or_create_category($title, $parenttitle) {
     global $DB;
     if (
         $category = $DB->get_record("course_categories", ["name" => $title,
         ])
     ) {
         return $category;
     }
-    $parent = empty($parent_title) ? 0 : (find_or_create_category($parent_title, null)->id);
+    $parent = empty($parenttitle) ? 0 : (find_or_create_category($parenttitle, null)->id);
     $parent = empty($parent) ? 0 : $parent;
     $newcategory = new stdClass();
     $newcategory->name = $title;
@@ -134,6 +137,7 @@ function get_course_acceptor($mdlid) {
  *
  * @param $id
  * @return null
+ * @package local_lsf_unification
  */
 function enable_manual_enrolment($course) {
     global $DB;
@@ -156,8 +160,9 @@ function enable_manual_enrolment($course) {
  *
  * @param $id
  * @return null
+ * @package local_lsf_unification
  */
-function enable_lsf_enrolment($id, $enrolment_start, $enrolment_end) {
+function enable_lsf_enrolment($id, $enrolmentstart, $enrolmentend) {
     global $DB;
 
     $course = $DB->get_record('course', ['id' => $id,
@@ -167,8 +172,8 @@ function enable_lsf_enrolment($id, $enrolment_start, $enrolment_end) {
         'status' => ENROL_INSTANCE_ENABLED,
         'enrolperiod' => null,
         'roleid' => get_config('local_lsf_webservices', 'role_student'),
-        'customint1' => $enrolment_start,
-        'customint2' => $enrolment_end,
+        'customint1' => $enrolmentstart,
+        'customint2' => $enrolmentend,
     ];
     $plugin->add_instance($course, $fields);
 }
@@ -179,6 +184,7 @@ function enable_lsf_enrolment($id, $enrolment_start, $enrolment_end) {
  * @param $course
  * @param $password
  * @return null
+ * @package local_lsf_unification
  */
 function enable_self_enrolment($course, $password) {
     global $DB;
@@ -204,6 +210,7 @@ function enable_self_enrolment($course, $password) {
  *
  * @param $course
  * @return null
+ * @package local_lsf_unification
  */
 function enable_database_enrolment($course) {
     global $DB;
@@ -236,6 +243,7 @@ function create_guest_enrolment($course, $password = "", $enable = false) {
  *
  * @param $courseid
  * @return $password | ""
+ * @package local_lsf_unification
  */
 function self_enrolment_status($courseid) {
     global $DB;
@@ -252,6 +260,7 @@ function self_enrolment_status($courseid) {
  * @param $shortname
  * @param $startdate
  * @return $course
+ * @package local_lsf_unification
  */
 function get_default_course($fullname, $idnumber, $summary, $shortname) {
     // check&format content
@@ -301,6 +310,7 @@ function get_default_course($fullname, $idnumber, $summary, $shortname) {
  * @param $shortname
  * @param $startdate
  * @return $course
+ * @package local_lsf_unification
  */
 function get_or_create_support_user() {
     global $DB, $CFG;
@@ -336,6 +346,7 @@ function get_or_create_user($username, $email) {
  *
  * @param array that maps id to name
  * @return array that maps id to path
+ * @package local_lsf_unification
  */
 function add_path_description($choices) {
     global $DB;
@@ -370,15 +381,16 @@ function add_path_description($choices) {
  *
  * NOTE: Since 2.7.2 this function is run by scheduled task rather
  * than standard cron.
+ * @package local_lsf_unification
  */
 function local_lsf_unification_cron() {
-    global $CFG, $pgDB;
+    global $CFG, $pgdb;
     include_once(dirname(__FILE__) . '/class_pg_lite.php');
     include_once(dirname(__FILE__) . '/lib_features.php');
 
-    $pgDB = new pg_lite();
-    $connected = $pgDB->connect();
-    $recourceid = $pgDB->connection;
+    $pgdb = new pg_lite();
+    $connected = $pgdb->connect();
+    $recourceid = $pgdb->connection;
 
     mtrace(
         '! = unknown category found, ? = unknown linkage found;' . 'Verbindung: ' .
@@ -387,5 +399,5 @@ function local_lsf_unification_cron() {
 
     insert_missing_helptable_entries(true, false);
 
-    $pgDB->dispose();
+    $pgdb->dispose();
 }