Fix remaining PHPCS warnings

Author: dlmsr

classes/view_controller.php

@@ -300,7 +300,6 @@ public static function handle_folder_form_submitted(
     ) {
         foreach ($userfolders as $groupid => $form) {
             // Iterate over forms to find the submitted one (is_submitted() is implicit in get_data()).
-            /* @var name_form $form */
             if ($fromform = $form->get_data()) {
                 // TODO handle exception cases properly!
                 self::share_folder_with_user(

lib.php

@@ -87,7 +87,10 @@ function collaborativefolders_add_instance(stdClass $collaborativefolders, mod_c
  * @param mod_collaborativefolders_mod_form|null $mform The form instance itself (if needed)
  * @return boolean Success/Fail
  */
-function collaborativefolders_update_instance(stdClass $collaborativefolders, mod_collaborativefolders_mod_form|null $mform = null) {
+function collaborativefolders_update_instance(
+    stdClass $collaborativefolders,
+    mod_collaborativefolders_mod_form|null $mform = null
+) {
     global $DB;
 
     $collaborativefolders->timemodified = time();

tests/events_test.php

@@ -24,6 +24,9 @@
  * @group      mod_collaborativefolders
  * @copyright  2017 Project seminar (Learnweb, University of Münster)
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ * @covers \mod_collaborativefolders\event\course_module_viewed
+ * @covers \mod_collaborativefolders\event\course_module_instance_list_viewed
+ * @covers \mod_collaborativefolders\event\link_generated
  */
 final class events_test extends \advanced_testcase {
     /** @var null|array data array containing groupings, course and instance information. */

tests/issuer_management_test.php

@@ -30,6 +30,7 @@
 
 /**
  * Test cases for issuer_management.
+ * @covers \mod_collaborativefolders\issuer_management
  */
 final class issuer_management_test extends \advanced_testcase {
     public function setUp(): void {
@@ -66,7 +67,6 @@ public function test_create_issuer(): void {
      */
     public function test_validate_issuer(): void {
         static::setAdminUser();
-        /* @var \mod_collaborativefolders_generator $generator */
         $generator = $this->getDataGenerator()->get_plugin_generator('mod_collaborativefolders');
 
         // Validate a correct issuer first.

tests/privacy_provider_test.php

@@ -29,6 +29,7 @@
 
 /**
  * Test cases for the privacy provider.
+ * @covers \mod_collaborativefolders\privacy\provider
  */
 final class privacy_provider_test extends \core_privacy\tests\provider_testcase {
     /** @var \stdClass The student objects. */

tests/systemfolderaccess_test.php

@@ -31,6 +31,7 @@
 
 /**
  * Tests cases for system_folder_access.
+ * @covers \mod_collaborativefolders\local\clients\system_folder_access
  */
 final class systemfolderaccess_test extends \advanced_testcase {
     /**

tests/toolbox_test.php

@@ -36,6 +36,7 @@ public function setUp(): void {
 
     /**
      * Test fake course group creation
+     * @covers \mod_collaborativefolders\toolbox::fake_course_group
      */
     public function test_fake_course_group(): void {
         $fakegroup = \mod_collaborativefolders\toolbox::fake_course_group('fakename');

tests/userfolderaccess_test.php

@@ -27,6 +27,7 @@
 
 /**
  * Test cases for user_folder_access.
+ * @covers \mod_collaborativefolders\local\clients\user_folder_access
  */
 final class userfolderaccess_test extends \advanced_testcase {
     /**