Merge pull request #243 from learnweb/tests/behat_cleaning

Simplify behat tests

Author: TamaroWalter

tests/behat/add_moodleoverflow.feature

@@ -5,24 +5,15 @@ Feature: Add moodleoverflow activities and discussions
   I need to add forum activities to moodle courses
 
   Scenario: Add a moodleoverflow and a discussion
-    Given the following "users" exist:
-      | username | firstname | lastname | email |
-      | teacher1 | Teacher | 1 | teacher1@example.com |
-      | student1 | Student | 1 | student1@example.com |
-    And the following "courses" exist:
-      | fullname | shortname | category |
-      | Course 1 | C1 | 0 |
-    And the following "course enrolments" exist:
-      | user | course | role |
-      | teacher1 | C1 | editingteacher |
-      | student1 | C1 | student |
+    Given I prepare a moodleoverflow feature background with users:
+      | username | firstname | lastname | email             | idnumber | role           |
+      | student1 | Student   | 1        | student1@mail.com | 10       | student        |
+      | teacher1 | Teacher   | 1        | teacher1@mail.com | 11       | editingteacher |
     And I log in as "teacher1"
-    And I am on "Course 1" course homepage
-    And I turn editing mode on
+    And I am on "Course 1" course homepage with editing mode "on"
     And I add a moodleoverflow to course "C1" section "1" and I fill the form with:
       | Moodleoverflow name | Test moodleoverflow name |
       | Description | Test forum description |
     And I add a new discussion to "Test moodleoverflow name" moodleoverflow with:
       | Subject | Forum post 1 |
       | Message | This is the body |
-    And I log out

tests/behat/anonymous.feature

@@ -2,37 +2,30 @@
 Feature: Use moodleoverflow anonymously
 
   Background:
-    Given the following "users" exist:
-      | username | firstname | lastname | email                |
-      | teacher1 | Teacher   | 1        | teacher1@example.com |
-      | student1 | Student   | 1        | student1@example.com |
-    And the following "courses" exist:
-      | fullname | shortname | category |
-      | Course 1 | C1        | 0        |
-    And the following "course enrolments" exist:
-      | user     | course | role           |
-      | teacher1 | C1     | editingteacher |
-      | student1 | C1     | student        |
+    Given I prepare a moodleoverflow feature background with users:
+      | username | firstname | lastname | email             | idnumber | role           |
+      | student1 | Student   | 1        | student1@mail.com | 10       | student        |
+      | teacher1 | Teacher   | 1        | teacher1@mail.com | 11       | editingteacher |
     And the following "activity" exists:
-      | activity  | moodleoverflow           |
-      | course    | C1                       |
-      | name      | Test moodleoverflow name |
-      | anonymous | 2                        |
+      | activity  | moodleoverflow      |
+      | course    | C1                  |
+      | name      | Test moodleoverflow |
+      | anonymous | 2                   |
 
   @_file_upload
   Scenario: Other people should not see the questioners name in anonymous mode, not even as file author.
-    Given I am on the "Test moodleoverflow name" "Activity" page logged in as "student1"
+    Given I navigate as "student1" to "Course 1" "Test moodleoverflow" ""
     And I press "Add a new discussion topic"
     And I set the following fields to these values:
       | Subject | This is Nina |
       | Message | She is nice. |
     And I upload "mod/moodleoverflow/tests/fixtures/NH.jpg" file to "Attachment" filemanager
     And I press "Post to forum"
     Then I should see "Anonymous (You)"
-    When I am on the "Test moodleoverflow name" "Activity" page logged in as "teacher1"
+    When I navigate as "teacher1" to "Course 1" "Test moodleoverflow" ""
     And I follow "This is Nina"
     Then I should not see "Student 1"
     And I should see "Questioner"
-    Given I follow "Edit"
-    And I click on "NH.jpg" "link"
+    When I click in moodleoverflow on "link" type:
+      | Edit | NH.jpg |
     Then the field "Author" matches value "Anonymous"