upgrade: remove subplugin folders if subplugins already uninstalled

Author: bluetom

classes/plugininfo/lifecycletrigger.php

@@ -41,17 +41,18 @@ class lifecycletrigger extends base {
     /**
      * Should there be a way to uninstall the plugin via the administration UI.
      *
-     * By default uninstallation is not allowed, plugin developers must enable it explicitly!
+     * By default, uninstallation is not allowed. Plugin developers must enable it explicitly!
      *
      * @return bool
+     * @throws \dml_exception
      */
     public function is_uninstall_allowed() {
         if ($this->is_standard()) {
             return false;
         }
         $lib = lib_manager::get_trigger_lib($this->name);
         if ($lib->has_multiple_instances()) {
-            // Only allow uninstall, if no active workflow for the trigger is present.
+            // Only allow to uninstall if no active workflow for the trigger is present.
             $triggers = trigger_manager::get_instances($this->name);
             foreach ($triggers as $trigger) {
                 if (workflow_manager::is_active($trigger->workflowid)) {

db/upgrade.php

@@ -22,6 +22,10 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
+use tool_lifecycle\local\manager\lib_manager;
+use tool_lifecycle\local\manager\trigger_manager;
+use tool_lifecycle\local\manager\workflow_manager;
+
 /**
  * Fix any gaps in the workflows sortindex.
  */
@@ -36,6 +40,24 @@ function tool_lifecycle_fix_workflow_sortindex() {
     }
 }
 
+/**
+ * Removes a directory from filesystem
+ * @param string $dir
+ * @return void
+ */
+function tool_lifecycle_upgrade_removeDir(string $dir): void {
+    $it = new RecursiveDirectoryIterator($dir, RecursiveDirectoryIterator::SKIP_DOTS);
+    $files = new RecursiveIteratorIterator($it, RecursiveIteratorIterator::CHILD_FIRST);
+    foreach($files as $file) {
+        if ($file->isDir()){
+            rmdir($file->getPathname());
+        } else {
+            unlink($file->getPathname());
+        }
+    }
+    rmdir($dir);
+}
+
 /**
  * Update script for tool_lifecycle.
  * @param int $oldversion Version id of the previously installed version.
@@ -259,13 +281,13 @@ function xmldb_tool_lifecycle_upgrade($oldversion) {
     }
 
     if ($oldversion < 2018022005) {
-        $workflows = \tool_lifecycle\local\manager\workflow_manager::get_active_workflows();
+        $workflows = workflow_manager::get_active_workflows();
         foreach ($workflows as $workflow) {
             if ($workflow->manual === null) {
-                $trigger = \tool_lifecycle\local\manager\trigger_manager::get_triggers_for_workflow($workflow->id)[0];
-                $lib = \tool_lifecycle\local\manager\lib_manager::get_trigger_lib($trigger->subpluginname);
+                $trigger = trigger_manager::get_triggers_for_workflow($workflow->id)[0];
+                $lib = lib_manager::get_trigger_lib($trigger->subpluginname);
                 $workflow->manual = $lib->is_manual_trigger();
-                \tool_lifecycle\local\manager\workflow_manager::insert_or_update($workflow);
+                workflow_manager::insert_or_update($workflow);
             }
         }
         // Lifecycle savepoint reached.
@@ -571,6 +593,14 @@ function xmldb_tool_lifecycle_upgrade($oldversion) {
             $dbman->add_field($table, $field);
         }
 
+        if ($dir = core_component::get_plugin_directory('lifecycletrigger', 'sitecourse')) {
+            tool_lifecycle_upgrade_removeDir($dir);
+        }
+
+        if ($dir = core_component::get_plugin_directory('lifecycletrigger', 'delayedcourses')) {
+            tool_lifecycle_upgrade_removeDir($dir);
+        }
+
         upgrade_plugin_savepoint(true, 2025041600, 'tool', 'lifecycle');
 
     }