process_courses: no processing if there is no process workflowid

Author: bluetom

classes/local/manager/process_manager.php

@@ -65,7 +65,7 @@ public static function create_process($courseid, $workflowid) {
 
     /**
      * Creates a process based on a manual trigger.
-     * @param int $courseid Id of the course to be triggerd.
+     * @param int $courseid Id of the course to be triggered.
      * @param int $triggerid Id of the triggering trigger.
      * @return process the triggered process instance.
      * @throws \moodle_exception for invalid workflow definition or missing trigger.

classes/local/manager/workflow_manager.php

@@ -132,7 +132,7 @@ public static function abortprocesses($workflowid) {
     }
 
     /**
-     * Returns a workflow instance if one with the is is available.
+     * Returns a workflow instance if one with the id is available.
      *
      * @param int $workflowid id of the workflow
      * @return workflow|null

classes/processor.php

@@ -89,8 +89,8 @@ public function call_trigger() {
     public function process_courses() {
         // For each process in process table.
         foreach (process_manager::get_processes() as $process) {
-            // Process only if the process has workflow id.
-            while ($process->workflowid) {
+            // Process only if the process has a valid workflow id.
+            if (is_int($process->workflowid)) {
                 // New workflows with lifecycle version 4.4 and beneath did not have to have a step.
                 if ($process->stepindex == 0) {
                     if (!process_manager::proceed_process($process)) {