fix upgrade job to remove sitecourse and delayedcourses trigger

Author: bluetom

db/upgrade.php

@@ -22,6 +22,8 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
+use tool_lifecycle\local\manager\step_manager;
+use tool_lifecycle\local\manager\trigger_manager;
 use tool_lifecycle\local\manager\workflow_manager;
 
 /**
@@ -562,30 +564,40 @@ function xmldb_tool_lifecycle_upgrade($oldversion) {
             $dbman->add_field($table, $field);
         }
 
-        // Remove sitecourse subplugin if there is one. Otherwise set all workflows to includesitecourse = 1.
+        // Remove sitecourse subplugin if there is one, otherwise set all workflows to includesitecourse = 1.
         $purgecaches = false;
         $pluginmanager = core_plugin_manager::instance();
         if ($plugininfo = $pluginmanager->get_plugin_info('lifecycletrigger_sitecourse')) {
             $trace = new \null_progress_trace();
-            $plugininfo->uninstall($trace);
-            if ($pluginmanager->is_plugin_folder_removable($plugininfo->component)) {
-                $pluginmanager->uninstall_plugin($plugininfo->component, $trace);
-                $pluginmanager->remove_plugin_folder($plugininfo);
+            $instances = trigger_manager::get_instances('lifecycletrigger_sitecourse');
+            foreach ($instances as $instance) {
+                $workflow = workflow_manager::get_workflow($instance->workflowid);
+                if (step_manager::count_steps_of_workflow($workflow->id) > 0) {
+                    throw new \moodle_exception('There should be no steps for the workflow of the trigger ' .
+                        'lifecycletrigger_sitecourse');
+                }
+                workflow_manager::remove($workflow->id);
             }
+            $pluginmanager->uninstall_plugin($plugininfo->component, $trace);
             $purgecaches = true;
         } else {
             $DB->set_field('tool_lifecycle_workflow', 'includesitecourse', 1);
         }
 
-        // Remove delayedcourses subplugin if there is one. Otherwise set all workflows to includedelayedcourses = 1.
+        // Remove delayedcourses subplugin if there is one, otherwise set all workflows to includedelayedcourses = 1.
         $pluginmanager = core_plugin_manager::instance();
         if ($plugininfo = $pluginmanager->get_plugin_info('lifecycletrigger_delayedcourses')) {
             $trace = new \null_progress_trace();
-            $plugininfo->uninstall($trace);
-            if ($pluginmanager->is_plugin_folder_removable($plugininfo->component)) {
-                $pluginmanager->uninstall_plugin($plugininfo->component, $trace);
-                $pluginmanager->remove_plugin_folder($plugininfo);
+            $instances = trigger_manager::get_instances('lifecycletrigger_delayedcourses');
+            foreach ($instances as $instance) {
+                $workflow = workflow_manager::get_workflow($instance->workflowid);
+                if (step_manager::count_steps_of_workflow($workflow->id) > 0) {
+                    throw new \moodle_exception('There should be no steps for the workflow of the trigger ' .
+                        'lifecycletrigger_delayedcourses');
+                }
+                workflow_manager::remove($workflow->id);
             }
+            $pluginmanager->uninstall_plugin($plugininfo->component, $trace);
             $purgecaches = true;
         } else {
             $DB->set_field('tool_lifecycle_workflow', 'includedelayedcourses', 1);